All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] sctp: kzalloc() error handling on deleting last address
@ 2011-06-10  9:06 Michio Honda
  2011-06-11  1:33 ` Wei Yongjun
  2011-06-11 22:54 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Michio Honda @ 2011-06-10  9:06 UTC (permalink / raw)
  To: David Miller; +Cc: Wei Yongjun, netdev

>From be2da529aa45061e77ad96313175e141aaadc16a Mon Sep 17 00:00:00 2001
From: Michio Honda <micchie@sfc.wide.ad.jp>
Date: Fri, 10 Jun 2011 16:42:14 +0900
Subject: [PATCH v1] sctp: kzalloc() error handling on deleting last address

Signed-off-by: Michio Honda <micchie@sfc.wide.ad.jp>
---
 net/sctp/socket.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index e7e1b14..60038fe 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -786,6 +786,10 @@ static int sctp_send_asconf_del_ip(struct sock		*sk,
 				continue;
 			asoc->asconf_addr_del_pending =
 			    kzalloc(sizeof(union sctp_addr), GFP_ATOMIC);
+			if (asoc->asconf_addr_del_pending == NULL) {
+				retval = -ENOMEM;
+				goto out;
+			}
 			asoc->asconf_addr_del_pending->sa.sa_family =
 				    addrs->sa_family;
 			asoc->asconf_addr_del_pending->v4.sin_port =
-- 
1.7.3.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] sctp: kzalloc() error handling on deleting last address
  2011-06-10  9:06 [PATCH v1] sctp: kzalloc() error handling on deleting last address Michio Honda
@ 2011-06-11  1:33 ` Wei Yongjun
  2011-06-11 22:54 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Wei Yongjun @ 2011-06-11  1:33 UTC (permalink / raw)
  To: Michio Honda; +Cc: David Miller, netdev


> From be2da529aa45061e77ad96313175e141aaadc16a Mon Sep 17 00:00:00 2001
> From: Michio Honda <micchie@sfc.wide.ad.jp>
> Date: Fri, 10 Jun 2011 16:42:14 +0900
> Subject: [PATCH v1] sctp: kzalloc() error handling on deleting last address
>
> Signed-off-by: Michio Honda <micchie@sfc.wide.ad.jp>
> ---
>  net/sctp/socket.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
It is OK to me.

Acked-by: Wei Yongjun <yjwei@cn.fujitsu.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] sctp: kzalloc() error handling on deleting last address
  2011-06-10  9:06 [PATCH v1] sctp: kzalloc() error handling on deleting last address Michio Honda
  2011-06-11  1:33 ` Wei Yongjun
@ 2011-06-11 22:54 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2011-06-11 22:54 UTC (permalink / raw)
  To: micchie; +Cc: yjwei, netdev

From: Michio Honda <micchie@sfc.wide.ad.jp>
Date: Fri, 10 Jun 2011 18:06:15 +0900

>>From be2da529aa45061e77ad96313175e141aaadc16a Mon Sep 17 00:00:00 2001
> From: Michio Honda <micchie@sfc.wide.ad.jp>
> Date: Fri, 10 Jun 2011 16:42:14 +0900
> Subject: [PATCH v1] sctp: kzalloc() error handling on deleting last address
> 
> Signed-off-by: Michio Honda <micchie@sfc.wide.ad.jp>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-06-11 22:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-10  9:06 [PATCH v1] sctp: kzalloc() error handling on deleting last address Michio Honda
2011-06-11  1:33 ` Wei Yongjun
2011-06-11 22:54 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.