[PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Shubhrajyoti D]

Currently the fifo depth is set to zero for OMAP4 which disables
the FIFO usage. This patch enables the FIFO usage for I2C transactions
on OMAP4 also.

Reported-By:Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
---
 drivers/i2c/busses/i2c-omap.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 58a58c7..934b52c 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1059,13 +1059,12 @@ omap_i2c_probe(struct platform_device *pdev)
 		 * size. This is to ensure that we can handle the status on int
 		 * call back latencies.
 		 */
-		if (dev->rev >= OMAP_I2C_REV_ON_4430) {
-			dev->fifo_size = 0;
+		dev->fifo_size = (dev->fifo_size / 2);
+		if (dev->rev >= OMAP_I2C_REV_ON_4430)
 			dev->b_hw = 0; /* Disable hardware fixes */
-		} else {
-			dev->fifo_size = (dev->fifo_size / 2);
+		else
 			dev->b_hw = 1; /* Enable hardware fixes */
-		}
+
 		/* calculate wakeup latency constraint for MPU */
 		if (dev->set_mpu_wkup_lat != NULL)
 			dev->latency = (1000000 * dev->fifo_size) /
-- 
1.7.1

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Kevin Hilman]

Shubhrajyoti D <shubhrajyoti@ti.com> writes:

> Currently the fifo depth is set to zero for OMAP4 which disables
> the FIFO usage. This patch enables the FIFO usage for I2C transactions
> on OMAP4 also.

Do you know the history of why the FIFO depth was set to zero?  A
summary of that history would greatly help reviewers.

> Reported-By:Nishanth Menon <nm@ti.com>

minor: missing space after ':'

> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>

Tested on what platforms?   OMAP3 also?

Could you please rebase this onto my for_3.1/i2c-andy branch[1] where we
have a large series of I2C patches queued up for the v3.1 merge window
already? 

Thanks,

Kevin

[1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Shubhrajyoti]

On Thursday 30 June 2011 04:53 AM, Kevin Hilman wrote:
> Shubhrajyoti D<shubhrajyoti@ti.com>  writes:
>
>> Currently the fifo depth is set to zero for OMAP4 which disables
>> the FIFO usage. This patch enables the FIFO usage for I2C transactions
>> on OMAP4 also.
> Do you know the history of why the FIFO depth was set to zero?  A
> summary of that history would greatly help reviewers.
>
>> Reported-By:Nishanth Menon<nm@ti.com>
> minor: missing space after ':'
>
>> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com>
> Tested on what platforms?   OMAP3 also?
OMAP4 and OMAP3
> Could you please rebase this onto my for_3.1/i2c-andy branch[1] where we
> have a large series of I2C patches queued up for the v3.1 merge window
> already?
OK will rebase and resend.
> Thanks,
>
> Kevin
>
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
>

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Kevin Hilman]

Shubhrajyoti <shubhrajyoti@ti.com> writes:

> On Thursday 30 June 2011 04:53 AM, Kevin Hilman wrote:
>> Shubhrajyoti D<shubhrajyoti@ti.com>  writes:
>>
>>> Currently the fifo depth is set to zero for OMAP4 which disables
>>> the FIFO usage. This patch enables the FIFO usage for I2C transactions
>>> on OMAP4 also.
>> Do you know the history of why the FIFO depth was set to zero?  A
>> summary of that history would greatly help reviewers.
>>
>>> Reported-By:Nishanth Menon<nm@ti.com>
>> minor: missing space after ':'
>>
>>> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com>
>> Tested on what platforms?   OMAP3 also?
> OMAP4 and OMAP3

Please add a brief summary of what platforms it was tested on in the
changelog.

>> Could you please rebase this onto my for_3.1/i2c-andy branch[1] where we
>> have a large series of I2C patches queued up for the v3.1 merge window
>> already?
> OK will rebase and resend.

Thanks,

Kevin

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Shubhrajyoti]

On Friday 01 July 2011 04:20 AM, Kevin Hilman wrote:
> Shubhrajyoti<shubhrajyoti-l0cyMroinI0@public.gmane.org>  writes:
>
>> On Thursday 30 June 2011 04:53 AM, Kevin Hilman wrote:
>>> Shubhrajyoti D<shubhrajyoti-l0cyMroinI0@public.gmane.org>   writes:
>>>
>>>> Currently the fifo depth is set to zero for OMAP4 which disables
>>>> the FIFO usage. This patch enables the FIFO usage for I2C transactions
>>>> on OMAP4 also.
>>> Do you know the history of why the FIFO depth was set to zero?  A
>>> summary of that history would greatly help reviewers.
Looks like it is disabled in the initial bring up and some how didn’t 
get enabled.
All I could find is
http://www.mail-archive.com/linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg01404.html

>>>> Reported-By:Nishanth Menon<nm-l0cyMroinI0@public.gmane.org>
>>> minor: missing space after ':'
Yes will fix it.
>>>> Signed-off-by: Shubhrajyoti D<shubhrajyoti-l0cyMroinI0@public.gmane.org>
>>> Tested on what platforms?   OMAP3 also?
>> OMAP4 and OMAP3
> Please add a brief summary of what platforms it was tested on in the
> changelog.
Will update it
>>> Could you please rebase this onto my for_3.1/i2c-andy branch[1] where we
>>> have a large series of I2C patches queued up for the v3.1 merge window
>>> already?
>> OK will rebase and resend.
Sent a rebased version.
> Thanks,
>
> Kevin

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Kevin Hilman]

+Ben Dooks

Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> writes:

> Currently the fifo depth is set to zero for OMAP4 which disables
> the FIFO usage. This patch enables the FIFO usage for I2C transactions
> on OMAP4 also.
>
> Tested on omap4430 and 3430.
>
> Tested-and-Reported-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>

Acked-by: Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org>

Ben, please queue as a fix for the v3.2-rc.  It applies cleanly to
v3.2-rc1.

If you prefer a branch:
https://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.2/fixes/i2c

Thanks,

Kevin

[PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Kevin Hilman]

+Ben Dooks

Shubhrajyoti D <shubhrajyoti@ti.com> writes:

> Currently the fifo depth is set to zero for OMAP4 which disables
> the FIFO usage. This patch enables the FIFO usage for I2C transactions
> on OMAP4 also.
>
> Tested on omap4430 and 3430.
>
> Tested-and-Reported-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>

Acked-by: Kevin Hilman <khilman@ti.com>

Ben, please queue as a fix for the v3.2-rc.  It applies cleanly to
v3.2-rc1.

If you prefer a branch:
https://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.2/fixes/i2c

Thanks,

Kevin

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Shubhrajyoti]

On Thursday 03 November 2011 07:51 PM, Kevin Hilman wrote:
> Shubhrajyoti <shubhrajyoti@ti.com> writes:
>
>> On Thursday 14 July 2011 12:50 AM, Ben Dooks wrote:
>>> On Tue, Jul 05, 2011 at 05:01:01PM -0700, Kevin Hilman wrote:
>>>> Shubhrajyoti D <shubhrajyoti@ti.com> writes:
>>>>
>>>>> Currently the fifo depth is set to zero for OMAP4 which disables
>>>>> the FIFO usage. This patch enables the FIFO usage for I2C transactions
>>>>> on OMAP4 also.
>>>>>
>>>>> Tested on omap4430 and 3430.
>>>>>
>>>>> Reported-By: Nishanth Menon <nm@ti.com>
>>>>> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
>>>>> ---
>>>>> Rebased on top of the series by Andy Green
>>>>> http://www.spinics.net/lists/linux-i2c/msg05632.html
>>>> Thanks.
>>>>
>>>> This is v3.1 material, but would be nice to see a couple tested-by or
>>>> acked-by tags from folks that are more actively using the I2C driver
>>>> before merging
>>>>
>>>> Kevin
>>> guess you'll be picking these up?
>> Ben Could this patch be lined up as well?
> Please update this patch against my for_3.2/i2c-cleanup branch, and add
> the Tested-by from Nishanth Menon.
>
> Then I will push to get this in as a fix for v3.2-rc.
Thanks the patch was already rebased to the 

for_3.2/i2c-cleanup branch and applies on your tree . Resent it adding Nishanth's Tested-by

Thanks.

> Kevin

[PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Shubhrajyoti D]

Currently the fifo depth is set to zero for OMAP4 which disables
the FIFO usage. This patch enables the FIFO usage for I2C transactions
on OMAP4 also.

Tested on omap4430 and 3430.

Tested-and-Reported-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
 drivers/i2c/busses/i2c-omap.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index a43d002..fa23faa 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1047,13 +1047,14 @@ omap_i2c_probe(struct platform_device *pdev)
 		 * size. This is to ensure that we can handle the status on int
 		 * call back latencies.
 		 */
-		if (dev->rev >= OMAP_I2C_REV_ON_3530_4430) {
-			dev->fifo_size = 0;
+
+		dev->fifo_size = (dev->fifo_size / 2);
+
+		if (dev->rev >= OMAP_I2C_REV_ON_3530_4430)
 			dev->b_hw = 0; /* Disable hardware fixes */
-		} else {
-			dev->fifo_size = (dev->fifo_size / 2);
+		else
 			dev->b_hw = 1; /* Enable hardware fixes */
-		}
+
 		/* calculate wakeup latency constraint for MPU */
 		if (dev->set_mpu_wkup_lat != NULL)
 			dev->latency = (1000000 * dev->fifo_size) /
-- 
1.7.1

[PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Shubhrajyoti D]

Currently the fifo depth is set to zero for OMAP4 which disables
the FIFO usage. This patch enables the FIFO usage for I2C transactions
on OMAP4 also.

Tested on omap4430 and 3430.

Tested-and-Reported-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
 drivers/i2c/busses/i2c-omap.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index a43d002..fa23faa 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1047,13 +1047,14 @@ omap_i2c_probe(struct platform_device *pdev)
 		 * size. This is to ensure that we can handle the status on int
 		 * call back latencies.
 		 */
-		if (dev->rev >= OMAP_I2C_REV_ON_3530_4430) {
-			dev->fifo_size = 0;
+
+		dev->fifo_size = (dev->fifo_size / 2);
+
+		if (dev->rev >= OMAP_I2C_REV_ON_3530_4430)
 			dev->b_hw = 0; /* Disable hardware fixes */
-		} else {
-			dev->fifo_size = (dev->fifo_size / 2);
+		else
 			dev->b_hw = 1; /* Enable hardware fixes */
-		}
+
 		/* calculate wakeup latency constraint for MPU */
 		if (dev->set_mpu_wkup_lat != NULL)
 			dev->latency = (1000000 * dev->fifo_size) /
-- 
1.7.1

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Kevin Hilman]

Shubhrajyoti <shubhrajyoti-l0cyMroinI0@public.gmane.org> writes:

> On Thursday 14 July 2011 12:50 AM, Ben Dooks wrote:
>> On Tue, Jul 05, 2011 at 05:01:01PM -0700, Kevin Hilman wrote:
>>> Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> writes:
>>>
>>>> Currently the fifo depth is set to zero for OMAP4 which disables
>>>> the FIFO usage. This patch enables the FIFO usage for I2C transactions
>>>> on OMAP4 also.
>>>>
>>>> Tested on omap4430 and 3430.
>>>>
>>>> Reported-By: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
>>>> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
>>>> ---
>>>> Rebased on top of the series by Andy Green
>>>> http://www.spinics.net/lists/linux-i2c/msg05632.html
>>> Thanks.
>>>
>>> This is v3.1 material, but would be nice to see a couple tested-by or
>>> acked-by tags from folks that are more actively using the I2C driver
>>> before merging
>>>
>>> Kevin
>> guess you'll be picking these up?
>
> Ben Could this patch be lined up as well?

Please update this patch against my for_3.2/i2c-cleanup branch, and add
the Tested-by from Nishanth Menon.

Then I will push to get this in as a fix for v3.2-rc.

Kevin

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Shubhrajyoti]

On Thursday 14 July 2011 12:50 AM, Ben Dooks wrote:
> On Tue, Jul 05, 2011 at 05:01:01PM -0700, Kevin Hilman wrote:
>> Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> writes:
>>
>>> Currently the fifo depth is set to zero for OMAP4 which disables
>>> the FIFO usage. This patch enables the FIFO usage for I2C transactions
>>> on OMAP4 also.
>>>
>>> Tested on omap4430 and 3430.
>>>
>>> Reported-By: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
>>> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
>>> ---
>>> Rebased on top of the series by Andy Green
>>> http://www.spinics.net/lists/linux-i2c/msg05632.html
>> Thanks.
>>
>> This is v3.1 material, but would be nice to see a couple tested-by or
>> acked-by tags from folks that are more actively using the I2C driver
>> before merging
>>
>> Kevin
> guess you'll be picking these up?

Ben Could this patch be lined up as well?
>  
>>>  drivers/i2c/busses/i2c-omap.c |   11 ++++++-----
>>>  1 files changed, 6 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
>>> index d53cd61..8f87a37 100644
>>> --- a/drivers/i2c/busses/i2c-omap.c
>>> +++ b/drivers/i2c/busses/i2c-omap.c
>>> @@ -1068,13 +1068,14 @@ omap_i2c_probe(struct platform_device *pdev)
>>>  		 * size. This is to ensure that we can handle the status on int
>>>  		 * call back latencies.
>>>  		 */
>>> -		if (dev->rev >= OMAP_I2C_REV_ON_3530_4430) {
>>> -			dev->fifo_size = 0;
>>> +
>>> +		dev->fifo_size = (dev->fifo_size / 2);
>>> +
>>> +		if (dev->rev >= OMAP_I2C_REV_ON_3530_4430)
>>>  			dev->b_hw = 0; /* Disable hardware fixes */
>>> -		} else {
>>> -			dev->fifo_size = (dev->fifo_size / 2);
>>> +		else
>>>  			dev->b_hw = 1; /* Enable hardware fixes */
>>> -		}
>>> +
>>>  		/* calculate wakeup latency constraint for MPU */
>>>  		if (dev->set_mpu_wkup_lat != NULL)
>>>  			dev->latency = (1000000 * dev->fifo_size) /
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Ben Dooks]

On Tue, Jul 05, 2011 at 05:01:01PM -0700, Kevin Hilman wrote:
> Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> writes:
> 
> > Currently the fifo depth is set to zero for OMAP4 which disables
> > the FIFO usage. This patch enables the FIFO usage for I2C transactions
> > on OMAP4 also.
> >
> > Tested on omap4430 and 3430.
> >
> > Reported-By: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
> > Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
> > ---
> > Rebased on top of the series by Andy Green
> > http://www.spinics.net/lists/linux-i2c/msg05632.html
> 
> Thanks.
> 
> This is v3.1 material, but would be nice to see a couple tested-by or
> acked-by tags from folks that are more actively using the I2C driver
> before merging
> 
> Kevin

guess you'll be picking these up?
 
> 
> >  drivers/i2c/busses/i2c-omap.c |   11 ++++++-----
> >  1 files changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> > index d53cd61..8f87a37 100644
> > --- a/drivers/i2c/busses/i2c-omap.c
> > +++ b/drivers/i2c/busses/i2c-omap.c
> > @@ -1068,13 +1068,14 @@ omap_i2c_probe(struct platform_device *pdev)
> >  		 * size. This is to ensure that we can handle the status on int
> >  		 * call back latencies.
> >  		 */
> > -		if (dev->rev >= OMAP_I2C_REV_ON_3530_4430) {
> > -			dev->fifo_size = 0;
> > +
> > +		dev->fifo_size = (dev->fifo_size / 2);
> > +
> > +		if (dev->rev >= OMAP_I2C_REV_ON_3530_4430)
> >  			dev->b_hw = 0; /* Disable hardware fixes */
> > -		} else {
> > -			dev->fifo_size = (dev->fifo_size / 2);
> > +		else
> >  			dev->b_hw = 1; /* Enable hardware fixes */
> > -		}
> > +
> >  		/* calculate wakeup latency constraint for MPU */
> >  		if (dev->set_mpu_wkup_lat != NULL)
> >  			dev->latency = (1000000 * dev->fifo_size) /
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Kevin Hilman]

"Menon, Nishanth" <nm-l0cyMroinI0@public.gmane.org> writes:

> On Tue, Jul 5, 2011 at 17:01, Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org> wrote:
>>
>> Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> writes:
>>
>> > Currently the fifo depth is set to zero for OMAP4 which disables
>> > the FIFO usage. This patch enables the FIFO usage for I2C transactions
>> > on OMAP4 also.
>> >
>> > Tested on omap4430 and 3430.
>> >
>> > Reported-By: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
>> > Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
>> > ---
>> > Rebased on top of the series by Andy Green
>> > http://www.spinics.net/lists/linux-i2c/msg05632.html
>>
>> Thanks.
>>
>> This is v3.1 material, but would be nice to see a couple tested-by or
>> acked-by tags from folks that are more actively using the I2C driver
>> before merging
>
> For what it is worth: tested on SDP4460/4430 with 255 multi-byte i2c
> read operation on twl6030.
>
> Tested-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
>

Thanks Nishanth,

Kevin

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Menon, Nishanth]

On Tue, Jul 5, 2011 at 17:01, Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org> wrote:
>
> Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> writes:
>
> > Currently the fifo depth is set to zero for OMAP4 which disables
> > the FIFO usage. This patch enables the FIFO usage for I2C transactions
> > on OMAP4 also.
> >
> > Tested on omap4430 and 3430.
> >
> > Reported-By: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
> > Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
> > ---
> > Rebased on top of the series by Andy Green
> > http://www.spinics.net/lists/linux-i2c/msg05632.html
>
> Thanks.
>
> This is v3.1 material, but would be nice to see a couple tested-by or
> acked-by tags from folks that are more actively using the I2C driver
> before merging

For what it is worth: tested on SDP4460/4430 with 255 multi-byte i2c
read operation on twl6030.

Tested-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>

Regards,
Nishanth Menon



>
> Kevin
>
>
> >  drivers/i2c/busses/i2c-omap.c |   11 ++++++-----
> >  1 files changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> > index d53cd61..8f87a37 100644
> > --- a/drivers/i2c/busses/i2c-omap.c
> > +++ b/drivers/i2c/busses/i2c-omap.c
> > @@ -1068,13 +1068,14 @@ omap_i2c_probe(struct platform_device *pdev)
> >                * size. This is to ensure that we can handle the status on int
> >                * call back latencies.
> >                */
> > -             if (dev->rev >= OMAP_I2C_REV_ON_3530_4430) {
> > -                     dev->fifo_size = 0;
> > +
> > +             dev->fifo_size = (dev->fifo_size / 2);
> > +
> > +             if (dev->rev >= OMAP_I2C_REV_ON_3530_4430)
> >                       dev->b_hw = 0; /* Disable hardware fixes */
> > -             } else {
> > -                     dev->fifo_size = (dev->fifo_size / 2);
> > +             else
> >                       dev->b_hw = 1; /* Enable hardware fixes */
> > -             }
> > +
> >               /* calculate wakeup latency constraint for MPU */
> >               if (dev->set_mpu_wkup_lat != NULL)
> >                       dev->latency = (1000000 * dev->fifo_size) /
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Kevin Hilman]

Shubhrajyoti D <shubhrajyoti@ti.com> writes:

> Currently the fifo depth is set to zero for OMAP4 which disables
> the FIFO usage. This patch enables the FIFO usage for I2C transactions
> on OMAP4 also.
>
> Tested on omap4430 and 3430.
>
> Reported-By: Nishanth Menon <nm@ti.com>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> ---
> Rebased on top of the series by Andy Green
> http://www.spinics.net/lists/linux-i2c/msg05632.html

Thanks.

This is v3.1 material, but would be nice to see a couple tested-by or
acked-by tags from folks that are more actively using the I2C driver
before merging

Kevin


>  drivers/i2c/busses/i2c-omap.c |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index d53cd61..8f87a37 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -1068,13 +1068,14 @@ omap_i2c_probe(struct platform_device *pdev)
>  		 * size. This is to ensure that we can handle the status on int
>  		 * call back latencies.
>  		 */
> -		if (dev->rev >= OMAP_I2C_REV_ON_3530_4430) {
> -			dev->fifo_size = 0;
> +
> +		dev->fifo_size = (dev->fifo_size / 2);
> +
> +		if (dev->rev >= OMAP_I2C_REV_ON_3530_4430)
>  			dev->b_hw = 0; /* Disable hardware fixes */
> -		} else {
> -			dev->fifo_size = (dev->fifo_size / 2);
> +		else
>  			dev->b_hw = 1; /* Enable hardware fixes */
> -		}
> +
>  		/* calculate wakeup latency constraint for MPU */
>  		if (dev->set_mpu_wkup_lat != NULL)
>  			dev->latency = (1000000 * dev->fifo_size) /

[PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Shubhrajyoti D]

Currently the fifo depth is set to zero for OMAP4 which disables
the FIFO usage. This patch enables the FIFO usage for I2C transactions
on OMAP4 also.

Tested on omap4430 and 3430.

Reported-By: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
---
Rebased on top of the series by Andy Green
http://www.spinics.net/lists/linux-i2c/msg05632.html

 drivers/i2c/busses/i2c-omap.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index d53cd61..8f87a37 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1068,13 +1068,14 @@ omap_i2c_probe(struct platform_device *pdev)
 		 * size. This is to ensure that we can handle the status on int
 		 * call back latencies.
 		 */
-		if (dev->rev >= OMAP_I2C_REV_ON_3530_4430) {
-			dev->fifo_size = 0;
+
+		dev->fifo_size = (dev->fifo_size / 2);
+
+		if (dev->rev >= OMAP_I2C_REV_ON_3530_4430)
 			dev->b_hw = 0; /* Disable hardware fixes */
-		} else {
-			dev->fifo_size = (dev->fifo_size / 2);
+		else
 			dev->b_hw = 1; /* Enable hardware fixes */
-		}
+
 		/* calculate wakeup latency constraint for MPU */
 		if (dev->set_mpu_wkup_lat != NULL)
 			dev->latency = (1000000 * dev->fifo_size) /
-- 
1.7.1