All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: xen-devel@lists.xensource.com, mst@redhat.com,
	stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org,
	armbru@redhat.com, anthony.perard@citrix.com
Subject: Re: [Qemu-devel] [PATCH v3] xen: implement unplug protocol in xen_platform
Date: Thu, 30 Jun 2011 14:16:05 +0200	[thread overview]
Message-ID: <4E0C6905.2040604@redhat.com> (raw)
In-Reply-To: <4E0C61DF.2050606@suse.de>

Am 30.06.2011 13:45, schrieb Alexander Graf:
> On 06/28/2011 01:29 PM, stefano.stabellini@eu.citrix.com wrote:
>> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>>
>> The unplug protocol is necessary to support PV drivers in the guest: the
>> drivers expect to be able to "unplug" emulated disks and nics before
>> initializing the Xen PV interfaces.
>> It is responsibility of the guest to make sure that the unplug is done
>> before the emulated devices or the PV interface start to be used.
>>
>> We use pci_for_each_device to walk the PCI bus, identify the devices and
>> disks that we want to disable and dynamically unplug them.
> 
> $ ~/git/qemu/scripts/checkpatch.pl *
> ERROR: space required after that ',' (ctx:VxV)
> #158: FILE: hw/ide/piix.c:240:
> +    },{
>        ^
> 
> total: 1 errors, 0 warnings, 130 lines checked

I think checkpatch.pl should be fixed in this case. We do have this
pattern all over the place in qemu and I don't see why it's bad.

> I definitely want to see an ack from Kevin here first though.

The approach looks good enough for me, unless someone has a better idea
on how to do it cleanly. I commented on the implementation.

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: xen-devel@lists.xensource.com, mst@redhat.com,
	stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org,
	armbru@redhat.com, anthony@codemonkey.ws,
	anthony.perard@citrix.com
Subject: Re: [PATCH v3] xen: implement unplug protocol in xen_platform
Date: Thu, 30 Jun 2011 14:16:05 +0200	[thread overview]
Message-ID: <4E0C6905.2040604@redhat.com> (raw)
In-Reply-To: <4E0C61DF.2050606@suse.de>

Am 30.06.2011 13:45, schrieb Alexander Graf:
> On 06/28/2011 01:29 PM, stefano.stabellini@eu.citrix.com wrote:
>> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>>
>> The unplug protocol is necessary to support PV drivers in the guest: the
>> drivers expect to be able to "unplug" emulated disks and nics before
>> initializing the Xen PV interfaces.
>> It is responsibility of the guest to make sure that the unplug is done
>> before the emulated devices or the PV interface start to be used.
>>
>> We use pci_for_each_device to walk the PCI bus, identify the devices and
>> disks that we want to disable and dynamically unplug them.
> 
> $ ~/git/qemu/scripts/checkpatch.pl *
> ERROR: space required after that ',' (ctx:VxV)
> #158: FILE: hw/ide/piix.c:240:
> +    },{
>        ^
> 
> total: 1 errors, 0 warnings, 130 lines checked

I think checkpatch.pl should be fixed in this case. We do have this
pattern all over the place in qemu and I don't see why it's bad.

> I definitely want to see an ack from Kevin here first though.

The approach looks good enough for me, unless someone has a better idea
on how to do it cleanly. I commented on the implementation.

Kevin

  reply	other threads:[~2011-06-30 12:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-28 11:29 [Qemu-devel] [PATCH v3] xen: implement unplug protocol in xen_platform stefano.stabellini
2011-06-28 11:29 ` stefano.stabellini
2011-06-30 11:45 ` [Qemu-devel] " Alexander Graf
2011-06-30 11:45   ` Alexander Graf
2011-06-30 12:16   ` Kevin Wolf [this message]
2011-06-30 12:16     ` Kevin Wolf
2011-06-30 12:14     ` [Qemu-devel] " Alexander Graf
2011-06-30 12:14       ` Alexander Graf
2011-06-30 12:12 ` [Qemu-devel] " Kevin Wolf
2011-06-30 14:16   ` Stefano Stabellini
2011-07-01  8:05     ` Kevin Wolf
2011-07-01 17:30       ` Stefano Stabellini
2011-07-15 10:34         ` Stefano Stabellini
2011-07-15 10:52           ` Kevin Wolf
2011-07-18 12:25             ` Alexander Graf
2011-07-18 16:03               ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0C6905.2040604@redhat.com \
    --to=kwolf@redhat.com \
    --cc=agraf@suse.de \
    --cc=anthony.perard@citrix.com \
    --cc=armbru@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.