All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel@nongnu.org,
	Stefan Haynoczi <stefanha@linux.vnet.ibm.com>,
	kvm@vger.kernel.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation
Date: Wed, 06 Jul 2011 10:39:57 +0200	[thread overview]
Message-ID: <4E141F5D.6010609@redhat.com> (raw)
In-Reply-To: <4E13FECA.10101@suse.de>

On 07/06/2011 08:20 AM, Hannes Reinecke wrote:
>>
>> We cannot map control structures from guest memory and treating them
>> as valid request state later on.
>>
> Yes, I've been working on that one already.
> What I'll be doing is to read in the sge count during 'map_sgl' and
> store this value internally (in ->iov_cnt). And during unmap I'll be
> using this value instead of the frame-provided one.
>
> That way we'll be checking the sge_count field only once when we slurp
> in the entire frame.

Note the flags too.  Perhaps it's easier to simply copy the entire frame 
header...

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	Alexander Graf <agraf@suse.de>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Stefan Haynoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation
Date: Wed, 06 Jul 2011 10:39:57 +0200	[thread overview]
Message-ID: <4E141F5D.6010609@redhat.com> (raw)
In-Reply-To: <4E13FECA.10101@suse.de>

On 07/06/2011 08:20 AM, Hannes Reinecke wrote:
>>
>> We cannot map control structures from guest memory and treating them
>> as valid request state later on.
>>
> Yes, I've been working on that one already.
> What I'll be doing is to read in the sge count during 'map_sgl' and
> store this value internally (in ->iov_cnt). And during unmap I'll be
> using this value instead of the frame-provided one.
>
> That way we'll be checking the sge_count field only once when we slurp
> in the entire frame.

Note the flags too.  Perhaps it's easier to simply copy the entire frame 
header...

Paolo

  reply	other threads:[~2011-07-06  8:40 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 11:03 [PATCH 0/5][v6] Megasas HBA emulation Hannes Reinecke
2011-07-05 11:03 ` [Qemu-devel] " Hannes Reinecke
2011-07-05 11:03 ` [PATCH 1/5] iov: Update parameter usage in iov_(to|from)_buf() Hannes Reinecke
2011-07-05 11:03   ` [Qemu-devel] " Hannes Reinecke
2011-07-05 11:03   ` [PATCH 2/5] scsi: Add 'hba_private' to SCSIRequest Hannes Reinecke
2011-07-05 11:03     ` [Qemu-devel] " Hannes Reinecke
2011-07-05 11:03     ` [PATCH 3/5] scsi-disk: Fixup debugging statement Hannes Reinecke
2011-07-05 11:03       ` [Qemu-devel] " Hannes Reinecke
2011-07-05 11:03       ` [PATCH 4/5] scsi-disk: Mask out serial number EVPD Hannes Reinecke
2011-07-05 11:03         ` [Qemu-devel] " Hannes Reinecke
2011-07-05 11:03         ` [PATCH 5/5] megasas: LSI Megaraid SAS emulation Hannes Reinecke
2011-07-05 11:03           ` [Qemu-devel] " Hannes Reinecke
2011-07-05 13:06           ` Alexander Graf
2011-07-05 13:06             ` [Qemu-devel] " Alexander Graf
2011-07-05 13:38           ` Alexander Graf
2011-07-05 13:38             ` [Qemu-devel] " Alexander Graf
2011-07-05 13:59             ` Paolo Bonzini
2011-07-05 13:59               ` [Qemu-devel] " Paolo Bonzini
2011-07-05 14:05               ` Alexander Graf
2011-07-05 14:05                 ` [Qemu-devel] " Alexander Graf
2011-07-05 15:21           ` Stefan Hajnoczi
2011-07-05 15:21             ` Stefan Hajnoczi
2011-07-06  6:20             ` Hannes Reinecke
2011-07-06  6:20               ` Hannes Reinecke
2011-07-06  8:39               ` Paolo Bonzini [this message]
2011-07-06  8:39                 ` Paolo Bonzini
2011-07-05 11:06         ` [PATCH 4/5] scsi-disk: Mask out serial number EVPD Paolo Bonzini
2011-07-05 11:06           ` [Qemu-devel] " Paolo Bonzini
2011-07-05 11:05       ` [PATCH 3/5] scsi-disk: Fixup debugging statement Paolo Bonzini
2011-07-05 11:05         ` [Qemu-devel] " Paolo Bonzini
2011-07-05 13:01 ` [PATCH 0/5][v6] Megasas HBA emulation Alexander Graf
2011-07-05 13:01   ` [Qemu-devel] " Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E141F5D.6010609@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=hare@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.