All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86: Make Dell Latitude E6320 use reboot=pci
@ 2011-06-28 13:57 Maxime Ripard
  2011-06-28 17:41 ` Matthew Garrett
  2011-07-13  4:48 ` [tip:x86/urgent] x86. reboot: " tip-bot for Maxime Ripard
  0 siblings, 2 replies; 8+ messages in thread
From: Maxime Ripard @ 2011-06-28 13:57 UTC (permalink / raw)
  To: tglx, mingo, hpa; +Cc: linux-kernel

The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.
Force it thanks to DMI.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 arch/x86/kernel/reboot.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 0c016f7..d712043 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -411,6 +411,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"),
 		},
 	},
+	{	/* Handle problems with rebooting on the Latitude E6320. */
+		.callback = set_pci_reboot,
+		.ident = "Dell Latitude E6320",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6320"),
+		},
+	},
 	{ }
 };
 
-- 
1.7.4.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] x86: Make Dell Latitude E6320 use reboot=pci
  2011-06-28 13:57 [PATCH] x86: Make Dell Latitude E6320 use reboot=pci Maxime Ripard
@ 2011-06-28 17:41 ` Matthew Garrett
  2011-06-28 19:35   ` Maxime Ripard
  2011-07-13  4:48 ` [tip:x86/urgent] x86. reboot: " tip-bot for Maxime Ripard
  1 sibling, 1 reply; 8+ messages in thread
From: Matthew Garrett @ 2011-06-28 17:41 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: tglx, mingo, hpa, linux-kernel

On Tue, Jun 28, 2011 at 03:57:31PM +0200, Maxime Ripard wrote:
> The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.

On which kernel versions?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] x86: Make Dell Latitude E6320 use reboot=pci
  2011-06-28 17:41 ` Matthew Garrett
@ 2011-06-28 19:35   ` Maxime Ripard
  2011-06-28 19:53     ` Maxime Ripard
  2011-06-28 20:03     ` Matthew Garrett
  0 siblings, 2 replies; 8+ messages in thread
From: Maxime Ripard @ 2011-06-28 19:35 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: tglx, mingo, hpa, linux-kernel

On 28/06/2011 19:41, Matthew Garrett wrote:
> On Tue, Jun 28, 2011 at 03:57:31PM +0200, Maxime Ripard wrote:
>> The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.
>
> On which kernel versions?

All the versions from 2.6.38 to 3.0-rc5.


-- 
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] x86: Make Dell Latitude E6320 use reboot=pci
  2011-06-28 19:35   ` Maxime Ripard
@ 2011-06-28 19:53     ` Maxime Ripard
  2011-06-28 20:03     ` Matthew Garrett
  1 sibling, 0 replies; 8+ messages in thread
From: Maxime Ripard @ 2011-06-28 19:53 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: tglx, mingo, hpa, linux-kernel

On 28/06/2011 21:35, Maxime Ripard wrote:
> On 28/06/2011 19:41, Matthew Garrett wrote:
>> On Tue, Jun 28, 2011 at 03:57:31PM +0200, Maxime Ripard wrote:
>>> The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.
>>
>> On which kernel versions?
>
> All the versions from 2.6.38 to 3.0-rc5.

I am not saying this is a regression though. I just didn't test it with 
an earlier kernel.


-- 
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] x86: Make Dell Latitude E6320 use reboot=pci
  2011-06-28 19:35   ` Maxime Ripard
  2011-06-28 19:53     ` Maxime Ripard
@ 2011-06-28 20:03     ` Matthew Garrett
  2011-06-29  7:33       ` Maxime Ripard
  1 sibling, 1 reply; 8+ messages in thread
From: Matthew Garrett @ 2011-06-28 20:03 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: tglx, mingo, hpa, linux-kernel

On Tue, Jun 28, 2011 at 09:35:40PM +0200, Maxime Ripard wrote:
> On 28/06/2011 19:41, Matthew Garrett wrote:
> >On Tue, Jun 28, 2011 at 03:57:31PM +0200, Maxime Ripard wrote:
> >>The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.
> >
> >On which kernel versions?
> 
> All the versions from 2.6.38 to 3.0-rc5.

Could you provide the acpidump output for the system?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] x86: Make Dell Latitude E6320 use reboot=pci
  2011-06-28 20:03     ` Matthew Garrett
@ 2011-06-29  7:33       ` Maxime Ripard
  2011-07-12  9:44         ` Maxime Ripard
  0 siblings, 1 reply; 8+ messages in thread
From: Maxime Ripard @ 2011-06-29  7:33 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: tglx, mingo, hpa, linux-kernel

On 28/06/2011 22:03, Matthew Garrett wrote:
> On Tue, Jun 28, 2011 at 09:35:40PM +0200, Maxime Ripard wrote:
>> On 28/06/2011 19:41, Matthew Garrett wrote:
>>> On Tue, Jun 28, 2011 at 03:57:31PM +0200, Maxime Ripard wrote:
>>>> The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.
>>>
>>> On which kernel versions?
>>
>> All the versions from 2.6.38 to 3.0-rc5.
> 
> Could you provide the acpidump output for the system?
> 

Sure, here it is :
http://free-electrons.com/~maxime/pub/acpidumb-e6320.log

-- 
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] x86: Make Dell Latitude E6320 use reboot=pci
  2011-06-29  7:33       ` Maxime Ripard
@ 2011-07-12  9:44         ` Maxime Ripard
  0 siblings, 0 replies; 8+ messages in thread
From: Maxime Ripard @ 2011-07-12  9:44 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: tglx, mingo, hpa, linux-kernel

Hi Matthew,

I've seen that you have worked on the reboot part, however the problem
is still present on this laptop with 3.0-rc7.

Do you need anything else ?

On 29/06/2011 09:33, Maxime Ripard wrote:
> On 28/06/2011 22:03, Matthew Garrett wrote:
>> On Tue, Jun 28, 2011 at 09:35:40PM +0200, Maxime Ripard wrote:
>>> On 28/06/2011 19:41, Matthew Garrett wrote:
>>>> On Tue, Jun 28, 2011 at 03:57:31PM +0200, Maxime Ripard wrote:
>>>>> The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.
>>>>
>>>> On which kernel versions?
>>>
>>> All the versions from 2.6.38 to 3.0-rc5.
>>
>> Could you provide the acpidump output for the system?
>>
> 
> Sure, here it is :
> http://free-electrons.com/~maxime/pub/acpidumb-e6320.log
-- 
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [tip:x86/urgent] x86. reboot: Make Dell Latitude E6320 use reboot=pci
  2011-06-28 13:57 [PATCH] x86: Make Dell Latitude E6320 use reboot=pci Maxime Ripard
  2011-06-28 17:41 ` Matthew Garrett
@ 2011-07-13  4:48 ` tip-bot for Maxime Ripard
  1 sibling, 0 replies; 8+ messages in thread
From: tip-bot for Maxime Ripard @ 2011-07-13  4:48 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: mjg, linux-kernel, hpa, mingo, tglx, maxime.ripard

Commit-ID:  3628c3f5c818cfc6e588d1ccb31f19aa12345c02
Gitweb:     http://git.kernel.org/tip/3628c3f5c818cfc6e588d1ccb31f19aa12345c02
Author:     Maxime Ripard <maxime.ripard@free-electrons.com>
AuthorDate: Tue, 28 Jun 2011 15:57:31 +0200
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Tue, 12 Jul 2011 21:42:48 -0700

x86. reboot: Make Dell Latitude E6320 use reboot=pci

The Dell Latitude E6320 doesn't reboot unless reboot=pci is set.
Force it thanks to DMI.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Link: http://lkml.kernel.org/r/1309269451-4966-1-git-send-email-maxime.ripard@free-electrons.com
Cc: Matthew Garrett <mjg@redhat.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 arch/x86/kernel/reboot.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 4f0d46f..14eed21 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -419,6 +419,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"),
 		},
 	},
+	{	/* Handle problems with rebooting on the Latitude E6320. */
+		.callback = set_pci_reboot,
+		.ident = "Dell Latitude E6320",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6320"),
+		},
+	},
 	{ }
 };
 

^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-07-13  4:49 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-28 13:57 [PATCH] x86: Make Dell Latitude E6320 use reboot=pci Maxime Ripard
2011-06-28 17:41 ` Matthew Garrett
2011-06-28 19:35   ` Maxime Ripard
2011-06-28 19:53     ` Maxime Ripard
2011-06-28 20:03     ` Matthew Garrett
2011-06-29  7:33       ` Maxime Ripard
2011-07-12  9:44         ` Maxime Ripard
2011-07-13  4:48 ` [tip:x86/urgent] x86. reboot: " tip-bot for Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.