Re: [Qemu-devel] [PATCH] Introduce "info migrate-times" monitor command

[Michal Novotny <minovotn@redhat.com>]

On 07/13/2011 04:11 PM, Paolo Bonzini wrote:
> On 07/13/2011 03:06 PM, Michal Novotny wrote:
>> +uint64_t time_get(const char *name, int stage);
>> +void time_set(const char *name, int stage, uint64_t tv);
>> +void time_add(const char *name, int stage, uint64_t tv);
>> +void time_add2(const char *name, int stage, uint64_t time1, uint64_t time2);
>> +uint64_t save_total_time(void);
> Please inline all these instead of adding new functions.

Do you mean to implement as macros? I'm trying since yesterday and it's
not that simple because the variable has to be accessible from 3 files -
arch_init.c, savevm.c and migration.c. So I need to figure out what file
to put the variables to to make it working fine.

Also, I'm thinking about extending it not just to measure save process
times but also measure load process times.
Thanks,
Michal

-- 
Michal Novotny <minovotn@redhat.com>, RHCE, Red Hat
Virtualization | libvirt-php bindings | php-virt-control.org