From: Paolo Bonzini <pbonzini@redhat.com>
To: Michal Novotny <minovotn@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Introduce "info migrate-times" monitor command
Date: Thu, 14 Jul 2011 11:44:22 +0200 [thread overview]
Message-ID: <4E1EBA76.8020603@redhat.com> (raw)
In-Reply-To: <4E1EACB9.4040701@redhat.com>
On 07/14/2011 10:45 AM, Michal Novotny wrote:
> > Please inline all these instead of adding new functions.
>
> Do you mean to implement as macros? I'm trying since yesterday and it's
> not that simple because the variable has to be accessible from 3 files -
> arch_init.c, savevm.c and migration.c. So I need to figure out what file
> to put the variables to to make it working fine.
I would like to avoid using them in multiple files.
The simplest change is to remove migration.c from the list. The
"waiting for input" handling can be moved to qemu_savevm_state_begin and
qemu_savevm_state_iterate. The monitor code can be moved to savevm.c as
well.
And also, it makes no sense that arch_init.c includes savevm-related
code. It was done simply to avoid compiling savevm more than once (to
put it in Makefile.objs instead of Makefile.target). If you move that
code back to savevm.c, the list of files goes down to one.
Paolo
next prev parent reply other threads:[~2011-07-14 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 13:06 [Qemu-devel] [PATCH] Introduce "info migrate-times" monitor command Michal Novotny
2011-07-13 14:11 ` Paolo Bonzini
2011-07-14 8:45 ` Michal Novotny
2011-07-14 9:44 ` Paolo Bonzini [this message]
2011-07-14 10:05 ` Michal Novotny
2011-07-14 10:15 ` Paolo Bonzini
2011-07-14 10:20 ` Michal Novotny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1EBA76.8020603@redhat.com \
--to=pbonzini@redhat.com \
--cc=minovotn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.