* [PATCH 2/2] g3dvl: disable iDCT for now
@ 2011-07-20 18:48 Bryan Cain
[not found] ` <1311187717-3621-2-git-send-email-bryancain3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Bryan Cain @ 2011-07-20 18:48 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
---
src/vl_hwmc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/vl_hwmc.c b/src/vl_hwmc.c
index 6e9e0c7..8e24786 100644
--- a/src/vl_hwmc.c
+++ b/src/vl_hwmc.c
@@ -55,7 +55,7 @@ static XF86MCSurfaceInfoRec yv12_mpeg2_surface =
2048,
2048,
2048,
- XVMC_IDCT | XVMC_MOCOMP | XVMC_MPEG_2,
+ /*XVMC_IDCT |*/ XVMC_MOCOMP | XVMC_MPEG_2,
XVMC_SUBPICTURE_INDEPENDENT_SCALING | XVMC_BACKEND_SUBPICTURE,
&subpicture_list
};
@@ -69,7 +69,7 @@ static XF86MCSurfaceInfoRec uyvy_mpeg2_surface =
2048,
2048,
2048,
- XVMC_IDCT | XVMC_MOCOMP | XVMC_MPEG_2,
+ /*XVMC_IDCT |*/ XVMC_MOCOMP | XVMC_MPEG_2,
XVMC_SUBPICTURE_INDEPENDENT_SCALING | XVMC_BACKEND_SUBPICTURE,
&subpicture_list
};
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] g3dvl: disable iDCT for now
[not found] ` <1311187717-3621-2-git-send-email-bryancain3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2011-07-27 7:42 ` Ben Skeggs
2011-07-27 19:08 ` Bryan Cain
0 siblings, 1 reply; 5+ messages in thread
From: Ben Skeggs @ 2011-07-27 7:42 UTC (permalink / raw)
To: Bryan Cain; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Wed, 2011-07-20 at 13:48 -0500, Bryan Cain wrote:
> ---
> src/vl_hwmc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
The obvious question I have for this is, why?
Ben.
>
> diff --git a/src/vl_hwmc.c b/src/vl_hwmc.c
> index 6e9e0c7..8e24786 100644
> --- a/src/vl_hwmc.c
> +++ b/src/vl_hwmc.c
> @@ -55,7 +55,7 @@ static XF86MCSurfaceInfoRec yv12_mpeg2_surface =
> 2048,
> 2048,
> 2048,
> - XVMC_IDCT | XVMC_MOCOMP | XVMC_MPEG_2,
> + /*XVMC_IDCT |*/ XVMC_MOCOMP | XVMC_MPEG_2,
> XVMC_SUBPICTURE_INDEPENDENT_SCALING | XVMC_BACKEND_SUBPICTURE,
> &subpicture_list
> };
> @@ -69,7 +69,7 @@ static XF86MCSurfaceInfoRec uyvy_mpeg2_surface =
> 2048,
> 2048,
> 2048,
> - XVMC_IDCT | XVMC_MOCOMP | XVMC_MPEG_2,
> + /*XVMC_IDCT |*/ XVMC_MOCOMP | XVMC_MPEG_2,
> XVMC_SUBPICTURE_INDEPENDENT_SCALING | XVMC_BACKEND_SUBPICTURE,
> &subpicture_list
> };
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] g3dvl: disable iDCT for now
2011-07-27 7:42 ` Ben Skeggs
@ 2011-07-27 19:08 ` Bryan Cain
[not found] ` <4E306234.5040502-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Bryan Cain @ 2011-07-27 19:08 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 07/27/2011 02:42 AM, Ben Skeggs wrote:
> On Wed, 2011-07-20 at 13:48 -0500, Bryan Cain wrote:
>> ---
>> src/vl_hwmc.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
> The obvious question I have for this is, why?
>
> Ben
At least at the time I wrote these patches (in April), the iDCT stage
didn't work correctly with nv50. If it's fixed now, this patch can be
ignored.
Bryan
>> diff --git a/src/vl_hwmc.c b/src/vl_hwmc.c
>> index 6e9e0c7..8e24786 100644
>> --- a/src/vl_hwmc.c
>> +++ b/src/vl_hwmc.c
>> @@ -55,7 +55,7 @@ static XF86MCSurfaceInfoRec yv12_mpeg2_surface =
>> 2048,
>> 2048,
>> 2048,
>> - XVMC_IDCT | XVMC_MOCOMP | XVMC_MPEG_2,
>> + /*XVMC_IDCT |*/ XVMC_MOCOMP | XVMC_MPEG_2,
>> XVMC_SUBPICTURE_INDEPENDENT_SCALING | XVMC_BACKEND_SUBPICTURE,
>> &subpicture_list
>> };
>> @@ -69,7 +69,7 @@ static XF86MCSurfaceInfoRec uyvy_mpeg2_surface =
>> 2048,
>> 2048,
>> 2048,
>> - XVMC_IDCT | XVMC_MOCOMP | XVMC_MPEG_2,
>> + /*XVMC_IDCT |*/ XVMC_MOCOMP | XVMC_MPEG_2,
>> XVMC_SUBPICTURE_INDEPENDENT_SCALING | XVMC_BACKEND_SUBPICTURE,
>> &subpicture_list
>> };
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] g3dvl: disable iDCT for now
[not found] ` <4E306234.5040502-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2011-07-27 22:54 ` Ben Skeggs
2011-07-28 18:03 ` Maarten Lankhorst
0 siblings, 1 reply; 5+ messages in thread
From: Ben Skeggs @ 2011-07-27 22:54 UTC (permalink / raw)
To: Bryan Cain; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Wed, 2011-07-27 at 14:08 -0500, Bryan Cain wrote:
> On 07/27/2011 02:42 AM, Ben Skeggs wrote:
> > On Wed, 2011-07-20 at 13:48 -0500, Bryan Cain wrote:
> >> ---
> >> src/vl_hwmc.c | 4 ++--
> >> 1 files changed, 2 insertions(+), 2 deletions(-)
> > The obvious question I have for this is, why?
> >
> > Ben
>
> At least at the time I wrote these patches (in April), the iDCT stage
> didn't work correctly with nv50. If it's fixed now, this patch can be
> ignored.
Then it should be fixed in mesa if that's the case, not disabled in the
DDX, that helps nothing.
Some time down the track, when it *does* work, we'll re-enable it, and
someone will update just the DDX and see the breakage because they
haven't updated mesa yet too..
Ben.
>
> Bryan
>
>
> >> diff --git a/src/vl_hwmc.c b/src/vl_hwmc.c
> >> index 6e9e0c7..8e24786 100644
> >> --- a/src/vl_hwmc.c
> >> +++ b/src/vl_hwmc.c
> >> @@ -55,7 +55,7 @@ static XF86MCSurfaceInfoRec yv12_mpeg2_surface =
> >> 2048,
> >> 2048,
> >> 2048,
> >> - XVMC_IDCT | XVMC_MOCOMP | XVMC_MPEG_2,
> >> + /*XVMC_IDCT |*/ XVMC_MOCOMP | XVMC_MPEG_2,
> >> XVMC_SUBPICTURE_INDEPENDENT_SCALING | XVMC_BACKEND_SUBPICTURE,
> >> &subpicture_list
> >> };
> >> @@ -69,7 +69,7 @@ static XF86MCSurfaceInfoRec uyvy_mpeg2_surface =
> >> 2048,
> >> 2048,
> >> 2048,
> >> - XVMC_IDCT | XVMC_MOCOMP | XVMC_MPEG_2,
> >> + /*XVMC_IDCT |*/ XVMC_MOCOMP | XVMC_MPEG_2,
> >> XVMC_SUBPICTURE_INDEPENDENT_SCALING | XVMC_BACKEND_SUBPICTURE,
> >> &subpicture_list
> >> };
> >
> >
>
> _______________________________________________
> Nouveau mailing list
> Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] g3dvl: disable iDCT for now
2011-07-27 22:54 ` Ben Skeggs
@ 2011-07-28 18:03 ` Maarten Lankhorst
0 siblings, 0 replies; 5+ messages in thread
From: Maarten Lankhorst @ 2011-07-28 18:03 UTC (permalink / raw)
To: skeggsb-Re5JQEeQqe8AvxtiuMwx3w
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Bryan Cain
[-- Attachment #1.1: Type: text/plain, Size: 2095 bytes --]
Also nacking nouveau almost has xvmc acceleration
Op 28 jul. 2011 00:55 schreef "Ben Skeggs" <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> het volgende:
> On Wed, 2011-07-27 at 14:08 -0500, Bryan Cain wrote:
>> On 07/27/2011 02:42 AM, Ben Skeggs wrote:
>> > On Wed, 2011-07-20 at 13:48 -0500, Bryan Cain wrote:
>> >> ---
>> >> src/vl_hwmc.c | 4 ++--
>> >> 1 files changed, 2 insertions(+), 2 deletions(-)
>> > The obvious question I have for this is, why?
>> >
>> > Ben
>>
>> At least at the time I wrote these patches (in April), the iDCT stage
>> didn't work correctly with nv50. If it's fixed now, this patch can be
>> ignored.
> Then it should be fixed in mesa if that's the case, not disabled in the
> DDX, that helps nothing.
>
> Some time down the track, when it *does* work, we'll re-enable it, and
> someone will update just the DDX and see the breakage because they
> haven't updated mesa yet too..
>
> Ben.
>
>>
>> Bryan
>>
>>
>> >> diff --git a/src/vl_hwmc.c b/src/vl_hwmc.c
>> >> index 6e9e0c7..8e24786 100644
>> >> --- a/src/vl_hwmc.c
>> >> +++ b/src/vl_hwmc.c
>> >> @@ -55,7 +55,7 @@ static XF86MCSurfaceInfoRec yv12_mpeg2_surface =
>> >> 2048,
>> >> 2048,
>> >> 2048,
>> >> - XVMC_IDCT | XVMC_MOCOMP | XVMC_MPEG_2,
>> >> + /*XVMC_IDCT |*/ XVMC_MOCOMP | XVMC_MPEG_2,
>> >> XVMC_SUBPICTURE_INDEPENDENT_SCALING | XVMC_BACKEND_SUBPICTURE,
>> >> &subpicture_list
>> >> };
>> >> @@ -69,7 +69,7 @@ static XF86MCSurfaceInfoRec uyvy_mpeg2_surface =
>> >> 2048,
>> >> 2048,
>> >> 2048,
>> >> - XVMC_IDCT | XVMC_MOCOMP | XVMC_MPEG_2,
>> >> + /*XVMC_IDCT |*/ XVMC_MOCOMP | XVMC_MPEG_2,
>> >> XVMC_SUBPICTURE_INDEPENDENT_SCALING | XVMC_BACKEND_SUBPICTURE,
>> >> &subpicture_list
>> >> };
>> >
>> >
>>
>> _______________________________________________
>> Nouveau mailing list
>> Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
>> http://lists.freedesktop.org/mailman/listinfo/nouveau
>
>
> _______________________________________________
> Nouveau mailing list
> Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau
[-- Attachment #1.2: Type: text/html, Size: 3268 bytes --]
[-- Attachment #2: Type: text/plain, Size: 181 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-07-28 18:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-20 18:48 [PATCH 2/2] g3dvl: disable iDCT for now Bryan Cain
[not found] ` <1311187717-3621-2-git-send-email-bryancain3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-07-27 7:42 ` Ben Skeggs
2011-07-27 19:08 ` Bryan Cain
[not found] ` <4E306234.5040502-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-07-27 22:54 ` Ben Skeggs
2011-07-28 18:03 ` Maarten Lankhorst
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.