From: Michael Tokarev <mjt@tls.msk.ru>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: Blue Swirl <blauwirbel@gmail.com>,
John Baboval <john.baboval@virtualcomputer.com>,
qemu-devel@nongnu.org,
Anthony Liguori <aliguori@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] v6 revamp acpitable parsing and allow to specify complete (headerful) table
Date: Fri, 29 Jul 2011 09:51:56 +0400 [thread overview]
Message-ID: <4E324A7C.3020207@msgid.tls.msk.ru> (raw)
In-Reply-To: <20110729014943.GK14976@valinux.co.jp>
29.07.2011 05:49, Isaku Yamahata wrote:
> On Fri, Jul 15, 2011 at 07:51:43PM +0300, Blue Swirl wrote:
>> On Fri, Jul 15, 2011 at 6:18 PM, John Baboval
>> <john.baboval@virtualcomputer.com> wrote:
>>> Is there something I can do to help take this patch the rest of the way?
>>>
>>> I'd hate to see it die because of a style issue and a compiler warning.
>>
>> There's also suspicious missing 'break' statement. How about fixing
>> the issues and submitting the patch?
>
> I fixed the compile error.
Oh, another one? :)
> I think the missing break is intentional, so added an comment there. Michael?
Yes it's intentional, you're right.
> Blue, can you please take a look of it?
I think it's hopeless.
/mjt
next prev parent reply other threads:[~2011-07-29 5:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 8:35 [Qemu-devel] [PATCH] v6 revamp acpitable parsing and allow to specify complete (headerful) table Michael Tokarev
2011-06-10 22:29 ` Michael Tokarev
2011-06-13 3:38 ` Isaku Yamahata
2011-06-15 18:19 ` Blue Swirl
2011-07-06 22:41 ` John Baboval
2011-07-15 15:18 ` John Baboval
2011-07-15 16:51 ` Blue Swirl
2011-07-29 1:49 ` Isaku Yamahata
2011-07-29 5:51 ` Michael Tokarev [this message]
2011-07-30 9:40 ` Blue Swirl
2011-07-30 16:37 ` John Baboval
2011-06-06 8:37 Michael Tokarev
2013-01-17 9:50 ` TeLeMan
2013-01-17 10:49 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E324A7C.3020207@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=aliguori@linux.vnet.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=john.baboval@virtualcomputer.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.