All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: TeLeMan <geleman@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	Isaku Yamahata <yamahata@valinux.co.jp>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] v6 revamp acpitable parsing and allow to specify complete (headerful) table
Date: Thu, 17 Jan 2013 14:49:50 +0400	[thread overview]
Message-ID: <50F7D74E.6090006@msgid.tls.msk.ru> (raw)
In-Reply-To: <CAETRQWkXZRsLggyjB_vnqAwDHoMxtRMTNUppOfrVjf9Wou7EBw@mail.gmail.com>

Wow you're replying to an old post... ;)

17.01.2013 13:50, TeLeMan wrote:
> On Thu, May 12, 2011 at 10:44 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> This patch almost rewrites acpi_table_add() function
[]
>> +
>> +    /* now read in the data files, reallocating buffer as needed */
>> +
>> +    for (f = strtok(buf, ":"); f; f = strtok(NULL, ":")) {
>> +        int fd = open(f, O_RDONLY);
>
> The acpi table is the binary file, so it should be opened by O_RDONLY
> | O_BINARY.

On Unix, O_BINARY is defined as 0, it has no effect whatsoever.
But yes it is a bug on other platforms.  I'll fix that in a moment.

Thanks,

/mnt

  reply	other threads:[~2013-01-17 14:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06  8:37 [Qemu-devel] [PATCH] v6 revamp acpitable parsing and allow to specify complete (headerful) table Michael Tokarev
2013-01-17  9:50 ` TeLeMan
2013-01-17 10:49   ` Michael Tokarev [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-06-06  8:35 Michael Tokarev
2011-06-10 22:29 ` Michael Tokarev
2011-06-13  3:38   ` Isaku Yamahata
2011-06-15 18:19   ` Blue Swirl
2011-07-06 22:41     ` John Baboval
2011-07-15 15:18     ` John Baboval
2011-07-15 16:51       ` Blue Swirl
2011-07-29  1:49         ` Isaku Yamahata
2011-07-29  5:51           ` Michael Tokarev
2011-07-30  9:40           ` Blue Swirl
2011-07-30 16:37             ` John Baboval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F7D74E.6090006@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=blauwirbel@gmail.com \
    --cc=geleman@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.