* [PATCH] Skip archive --remote tests on Windows
@ 2011-08-03 8:20 Johannes Sixt
2011-08-03 9:09 ` Jakub Narebski
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Sixt @ 2011-08-03 8:20 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Jeff King, Git Mailing List, Erik Faye-Lund
From: Johannes Sixt <j6t@kdbg.org>
These depend on a working git-upload-archive, which is broken on Windows,
because it depends on fork().
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
These prerequisites are needed in current master, but would have to be
patched out again by Erik's upload-archive series.
t/t5000-tar-tree.sh | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh
index 9e3ba98..d906898 100755
--- a/t/t5000-tar-tree.sh
+++ b/t/t5000-tar-tree.sh
@@ -266,7 +266,7 @@ test_expect_success 'archive --list mentions user filter' '
grep "^bar\$" output
'
-test_expect_success 'archive --list shows only enabled remote filters' '
+test_expect_success NOT_MINGW 'archive --list shows only enabled remote filters' '
git archive --list --remote=. >output &&
! grep "^tar\.foo\$" output &&
grep "^bar\$" output
@@ -298,7 +298,7 @@ test_expect_success 'extension matching requires dot' '
test_cmp b.tar config-implicittar.foo
'
-test_expect_success 'only enabled filters are available remotely' '
+test_expect_success NOT_MINGW 'only enabled filters are available remotely' '
test_must_fail git archive --remote=. --format=tar.foo HEAD \
>remote.tar.foo &&
git archive --remote=. --format=bar >remote.bar HEAD &&
@@ -341,12 +341,12 @@ test_expect_success GZIP,GUNZIP 'extract tgz file' '
test_cmp b.tar j.tar
'
-test_expect_success GZIP 'remote tar.gz is allowed by default' '
+test_expect_success GZIP,NOT_MINGW 'remote tar.gz is allowed by default' '
git archive --remote=. --format=tar.gz HEAD >remote.tar.gz &&
test_cmp j.tgz remote.tar.gz
'
-test_expect_success GZIP 'remote tar.gz can be disabled' '
+test_expect_success GZIP,NOT_MINGW 'remote tar.gz can be disabled' '
git config tar.tar.gz.remote false &&
test_must_fail git archive --remote=. --format=tar.gz HEAD \
>remote.tar.gz
--
1.7.6.1572.g1f80c3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Skip archive --remote tests on Windows
2011-08-03 8:20 [PATCH] Skip archive --remote tests on Windows Johannes Sixt
@ 2011-08-03 9:09 ` Jakub Narebski
2011-08-03 10:40 ` Johannes Sixt
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Narebski @ 2011-08-03 9:09 UTC (permalink / raw)
To: Johannes Sixt; +Cc: Junio C Hamano, Jeff King, Git Mailing List, Erik Faye-Lund
Johannes Sixt <j.sixt@viscovery.net> writes:
> From: Johannes Sixt <j6t@kdbg.org>
>
> These depend on a working git-upload-archive, which is broken on Windows,
> because it depends on fork().
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> These prerequisites are needed in current master, but would have to be
> patched out again by Erik's upload-archive series.
[...]
> -test_expect_success 'archive --list shows only enabled remote filters' '
> +test_expect_success NOT_MINGW 'archive --list shows only enabled remote filters' '
Shouldn't the prerequisite be called FORK rather than NON_MINGW?
--
Jakub Narębski
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Skip archive --remote tests on Windows
2011-08-03 9:09 ` Jakub Narebski
@ 2011-08-03 10:40 ` Johannes Sixt
0 siblings, 0 replies; 3+ messages in thread
From: Johannes Sixt @ 2011-08-03 10:40 UTC (permalink / raw)
To: Jakub Narebski
Cc: Junio C Hamano, Jeff King, Git Mailing List, Erik Faye-Lund
Am 8/3/2011 11:09, schrieb Jakub Narebski:
> Johannes Sixt <j.sixt@viscovery.net> writes:
>> -test_expect_success 'archive --list shows only enabled remote filters' '
>> +test_expect_success NOT_MINGW 'archive --list shows only enabled remote filters' '
>
> Shouldn't the prerequisite be called FORK rather than NON_MINGW?
Yes, it should. But we already have one instance of NOT_MINGW in
connection with archive --remote in this file before this patch, and with
Erik's efforts, these particular prerequisites should go away anyway RSN.
-- Hannes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-03 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-03 8:20 [PATCH] Skip archive --remote tests on Windows Johannes Sixt
2011-08-03 9:09 ` Jakub Narebski
2011-08-03 10:40 ` Johannes Sixt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.