From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Koen Kooi <koen@dominion.thruhere.net>,
Koen Kooi <koen@openembedded.org>
Subject: Re: [PATCH] gtk-icon-cache bbclass: only add runtime dependencies on hicolor-icon-theme when installing icons
Date: Thu, 04 Aug 2011 19:23:40 -0700 [thread overview]
Message-ID: <4E3B542C.1070306@linux.intel.com> (raw)
In-Reply-To: <1312196922-20019-1-git-send-email-koen@dominion.thruhere.net>
On 08/01/2011 04:08 AM, Koen Kooi wrote:
> Tested with gnome-icon-theme and libsoup recipes on angstrom.
>
But you did not test it against anything in oe-core, it has broken the
build for connman-gnome and oprofileui, which use this bbclass.
The oe-core gnome-icon-theme does not include this class.
Please correct this.
Processing task-base-extended...
| error: Failed dependencies:
| hicolor-icon-theme is needed by tasks-0.19-r0.armv5te
| hicolor-icon-theme is needed by connman-gnome-0.5-r6.armv5te
| hicolor-icon-theme is needed by
oprofileui-server-0.0+git1+0c3c32fa754c1d0b70e65767ea7048914f776396-r4.armv5te
Thanks
Sau!
> Signed-off-by: Koen Kooi<koen@openembedded.org>
> ---
> meta/classes/gtk-icon-cache.bbclass | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-icon-cache.bbclass
> index dcabaf5..d9b5d1b 100644
> --- a/meta/classes/gtk-icon-cache.bbclass
> +++ b/meta/classes/gtk-icon-cache.bbclass
> @@ -1,5 +1,4 @@
> FILES_${PN} += "${datadir}/icons/hicolor"
> -RDEPENDS += "hicolor-icon-theme"
>
> # This could run on the host as icon cache files are architecture independent,
> # but there is no gtk-update-icon-cache built natively.
> @@ -34,7 +33,12 @@ python populate_packages_append () {
> icon_dir = '%s/%s/%s/icons' % (pkgdest, pkg, bb.data.getVar('datadir', d, 1))
> if not os.path.exists(icon_dir):
> continue
> -
> +
> + bb.note("adding hicolor-icon-theme dependency to %s" % pkg)
> + rdepends = bb.data.getVar('RDEPENDS', d, 1)
> + rdepends += "hicolor-icon-theme"
> + bb.data.setVar('RDEPENDS', rdepends, d)
> +
> bb.note("adding gtk-icon-cache postinst and postrm scripts to %s" % pkg)
>
> postinst = bb.data.getVar('pkg_postinst_%s' % pkg, d, 1) or bb.data.getVar('pkg_postinst', d, 1)
next prev parent reply other threads:[~2011-08-05 2:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 11:08 [PATCH] gtk-icon-cache bbclass: only add runtime dependencies on hicolor-icon-theme when installing icons Koen Kooi
2011-08-04 14:47 ` Saul Wold
2011-08-05 2:23 ` Saul Wold [this message]
2011-08-05 5:28 ` Koen Kooi
2011-08-05 5:32 ` Saul Wold
2011-08-05 5:48 ` Koen Kooi
2011-08-05 5:51 ` Chris Larson
2011-08-05 5:55 ` Koen Kooi
2011-08-05 7:00 ` Chris Larson
2011-08-05 7:16 ` Koen Kooi
2011-08-05 16:27 ` Richard Purdie
2011-08-05 17:34 ` Koen Kooi
2011-08-05 6:44 ` Koen Kooi
2011-08-05 6:51 ` Koen Kooi
2011-08-05 12:42 ` Kumar Gala
2011-08-05 13:19 ` Richard Purdie
2011-08-05 14:16 ` Koen Kooi
-- strict thread matches above, loose matches on Subject: below --
2011-08-01 9:59 Koen Kooi
2011-08-01 13:31 ` Steffen Sledz
2011-08-04 7:15 ` Steffen Sledz
2011-08-04 7:38 ` Koen Kooi
2011-08-04 7:51 ` Steffen Sledz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3B542C.1070306@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=koen@dominion.thruhere.net \
--cc=koen@openembedded.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.