From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] gtk-icon-cache bbclass: only add runtime dependencies on hicolor-icon-theme when installing icons
Date: Thu, 04 Aug 2011 09:38:54 +0200 [thread overview]
Message-ID: <j1diae$tc1$1@dough.gmane.org> (raw)
In-Reply-To: <4E3A472D.3030001@dresearch-fe.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 04-08-11 09:15, Steffen Sledz schreef:
> On 01.08.2011 15:31, Steffen Sledz wrote:
>> On 01.08.2011 11:59, Koen Kooi wrote:
>>> Also import a fix from OE-core for setting the loader dir.
>>>
>>> Tested with gnome-icon-theme and libsoup recipes on angstrom.
>>>
>>> Signed-off-by: Koen Kooi <koen@openembedded.org>
>>
>> Acked-by: Steffen Sledz <sledz@dresearch-fe.de>
>
> Ping!
>
>> Thx for this. Would be nice, if this patch could find it's way to 2011.03-maintenance branch too.
Wasn't this in the pull request you did this week?
>>
>>> --- classes/gtk-icon-cache.bbclass | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/classes/gtk-icon-cache.bbclass b/classes/gtk-icon-cache.bbclass index 2449e95..d9b5d1b 100644 --- a/classes/gtk-icon-cache.bbclass +++ b/classes/gtk-icon-cache.bbclass @@ -1,6 +1,4 @@ FILES_${PN} += "${datadir}/icons/hicolor" -# Only add runtime dependency on hicolor-icon-theme
>>> for target recipes -RDEPENDS_${PN} += "${@['', 'hicolor-icon-theme']['${PN}' == '${BPN}']}"
>>>
>>> # This could run on the host as icon cache files are architecture independent, # but there is no gtk-update-icon-cache built natively. @@ -10,7 +8,7 @@ if [ "x$D" != "x" ]; then fi
>>>
>>> # Update the pixbuf loaders in case they haven't been registered yet -gdk-pixbuf-query-loaders > /etc/gtk-2.0/gdk-pixbuf.loaders +GDK_PIXBUF_MODULEDIR=${libdir}/gdk-pixbuf-2.0/2.10.0/loaders gdk-pixbuf-query-loaders --update-cache
>>>
>>> for icondir in /usr/share/icons/* ; do if [ -d $icondir ] ; then @@ -35,7 +33,12 @@ python populate_packages_append () { icon_dir = '%s/%s/%s/icons' % (pkgdest, pkg, bb.data.getVar('datadir', d, 1)) if not os.path.exists(icon_dir): continue - + + bb.note("adding hicolor-icon-theme dependency
>>> to %s" % pkg) + rdepends = bb.data.getVar('RDEPENDS', d, 1) + rdepends += "hicolor-icon-theme" + bb.data.setVar('RDEPENDS', rdepends, d) + bb.note("adding gtk-icon-cache postinst and postrm scripts to %s" % pkg) postinst = bb.data.getVar('pkg_postinst_%s' % pkg, d, 1) or
>>> bb.data.getVar('pkg_postinst', d, 1)
>>
>>
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFOOkyOMkyGM64RGpERAu38AKCbLXcD5+k5mD+zqBZ1vrmqD2MhyQCfeu8q
FWqQAhn7kDc46b8BkBlIuf8=
=NfMW
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-08-04 7:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 9:59 [PATCH] gtk-icon-cache bbclass: only add runtime dependencies on hicolor-icon-theme when installing icons Koen Kooi
2011-08-01 13:31 ` Steffen Sledz
2011-08-04 7:15 ` Steffen Sledz
2011-08-04 7:38 ` Koen Kooi [this message]
2011-08-04 7:51 ` Steffen Sledz
2011-08-01 11:08 Koen Kooi
2011-08-04 14:47 ` Saul Wold
2011-08-05 2:23 ` Saul Wold
2011-08-05 5:28 ` Koen Kooi
2011-08-05 5:32 ` Saul Wold
2011-08-05 5:48 ` Koen Kooi
2011-08-05 5:51 ` Chris Larson
2011-08-05 5:55 ` Koen Kooi
2011-08-05 7:00 ` Chris Larson
2011-08-05 7:16 ` Koen Kooi
2011-08-05 16:27 ` Richard Purdie
2011-08-05 17:34 ` Koen Kooi
2011-08-05 6:44 ` Koen Kooi
2011-08-05 6:51 ` Koen Kooi
2011-08-05 12:42 ` Kumar Gala
2011-08-05 13:19 ` Richard Purdie
2011-08-05 14:16 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='j1diae$tc1$1@dough.gmane.org' \
--to=koen@dominion.thruhere.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.