All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
Cc: "socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org"
	<socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org>,
	Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	U Bhaskar-B22300 <B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 4/4] [powerpc] Add flexcan device support for p1010rdb.
Date: Tue, 09 Aug 2011 17:10:32 +0200	[thread overview]
Message-ID: <4E414DE8.4050909@grandegger.com> (raw)
In-Reply-To: <20110809145507.GY4926-sJ/iWh9BUns@public.gmane.org>

On 08/09/2011 04:55 PM, Robin Holt wrote:
> On Tue, Aug 09, 2011 at 02:45:58PM +0000, U Bhaskar-B22300 wrote:
>> Hi Robin,
>> 	Where are you doing the irq handling ie request_irq() for the powerpc based P1010.
>> 	Or the existing code of ARM based FlexCAN will work for P1010 ??
> 
> It appears that the of_device stuff got moved under the struct device
> and that allows the request_irq() to just magically work.

Cool! Actually I was also missing of_address_to_resource (or of_iomap)
and irq_of_parse_and_map(). But the resources seem to be filled in here:

  http://lxr.linux.no/#linux+v3.0.1/drivers/of/platform.c#L121

Wolfgang.

WARNING: multiple messages have this Message-ID (diff)
From: Wolfgang Grandegger <wg@grandegger.com>
To: Robin Holt <holt@sgi.com>
Cc: "socketcan-core@lists.berlios.de"
	<socketcan-core@lists.berlios.de>,
	U Bhaskar-B22300 <B22300@freescale.com>,
	PPC list <linuxppc-dev@lists.ozlabs.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/4] [powerpc] Add flexcan device support for p1010rdb.
Date: Tue, 09 Aug 2011 17:10:32 +0200	[thread overview]
Message-ID: <4E414DE8.4050909@grandegger.com> (raw)
In-Reply-To: <20110809145507.GY4926@sgi.com>

On 08/09/2011 04:55 PM, Robin Holt wrote:
> On Tue, Aug 09, 2011 at 02:45:58PM +0000, U Bhaskar-B22300 wrote:
>> Hi Robin,
>> 	Where are you doing the irq handling ie request_irq() for the powerpc based P1010.
>> 	Or the existing code of ARM based FlexCAN will work for P1010 ??
> 
> It appears that the of_device stuff got moved under the struct device
> and that allows the request_irq() to just magically work.

Cool! Actually I was also missing of_address_to_resource (or of_iomap)
and irq_of_parse_and_map(). But the resources seem to be filled in here:

  http://lxr.linux.no/#linux+v3.0.1/drivers/of/platform.c#L121

Wolfgang.

  parent reply	other threads:[~2011-08-09 15:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 12:28 [Patch 0/4] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) -V8 Robin Holt
2011-08-09 12:28 ` Robin Holt
2011-08-09 12:28 ` [PATCH 2/4] [flexcan] Abstract off read/write for big/little endian Robin Holt
2011-08-09 12:28   ` Robin Holt
     [not found] ` <1312892907-20419-1-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-09 12:28   ` [PATCH 1/4] [flexcan] Remove #include <mach/clock.h> Robin Holt
2011-08-09 12:28     ` Robin Holt
2011-08-09 12:28   ` [PATCH 3/4] [flexcan] Add of_match to platform_device definition Robin Holt
2011-08-09 12:28     ` Robin Holt
2011-08-09 12:28   ` [PATCH 4/4] [powerpc] Add flexcan device support for p1010rdb Robin Holt
2011-08-09 12:28     ` Robin Holt
     [not found]     ` <1312892907-20419-5-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-09 13:00       ` Wolfgang Grandegger
2011-08-09 13:00         ` Wolfgang Grandegger
2011-08-09 14:45       ` U Bhaskar-B22300
2011-08-09 14:45         ` U Bhaskar-B22300
     [not found]         ` <9C64B7751C3BCA41B64A68E23005A7BE1C4A88-TcFNo7jSaXPiTqIcKZ1S2K4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-08-09 14:55           ` Robin Holt
2011-08-09 14:55             ` Robin Holt
     [not found]             ` <20110809145507.GY4926-sJ/iWh9BUns@public.gmane.org>
2011-08-09 15:10               ` Wolfgang Grandegger [this message]
2011-08-09 15:10                 ` Wolfgang Grandegger
2011-08-09 15:11               ` Marc Kleine-Budde
2011-08-09 15:11                 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E414DE8.4050909@grandegger.com \
    --to=wg-5yr1bzd7o62+xt7jha+gda@public.gmane.org \
    --cc=B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=holt-sJ/iWh9BUns@public.gmane.org \
    --cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.