* [PATCH] ASoC: Ensure we only run Speyside WM8962 bias level callbacks once
@ 2011-08-21 11:20 Mark Brown
2011-08-22 10:23 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2011-08-21 11:20 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown
We get called once per DAPM context but only need to run once. When DAPM
was serialized this was a series of noops but now it can run in parallel
we need to take proper care.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/samsung/speyside_wm8962.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/sound/soc/samsung/speyside_wm8962.c b/sound/soc/samsung/speyside_wm8962.c
index 753e1c2..3820a6b 100644
--- a/sound/soc/samsung/speyside_wm8962.c
+++ b/sound/soc/samsung/speyside_wm8962.c
@@ -23,6 +23,9 @@ static int speyside_wm8962_set_bias_level(struct snd_soc_card *card,
struct snd_soc_dai *codec_dai = card->rtd[0].codec_dai;
int ret;
+ if (dapm->dev != codec_dai->dev)
+ return 0;
+
switch (level) {
case SND_SOC_BIAS_PREPARE:
if (dapm->bias_level == SND_SOC_BIAS_STANDBY) {
@@ -57,6 +60,9 @@ static int speyside_wm8962_set_bias_level_post(struct snd_soc_card *card,
struct snd_soc_dai *codec_dai = card->rtd[0].codec_dai;
int ret;
+ if (dapm->dev != codec_dai->dev)
+ return 0;
+
switch (level) {
case SND_SOC_BIAS_STANDBY:
ret = snd_soc_dai_set_sysclk(codec_dai, WM8962_SYSCLK_MCLK,
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: Ensure we only run Speyside WM8962 bias level callbacks once
2011-08-21 11:20 [PATCH] ASoC: Ensure we only run Speyside WM8962 bias level callbacks once Mark Brown
@ 2011-08-22 10:23 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2011-08-22 10:23 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, patches
On 21/08/11 12:20, Mark Brown wrote:
> We get called once per DAPM context but only need to run once. When DAPM
> was serialized this was a series of noops but now it can run in parallel
> we need to take proper care.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/samsung/speyside_wm8962.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/samsung/speyside_wm8962.c b/sound/soc/samsung/speyside_wm8962.c
> index 753e1c2..3820a6b 100644
> --- a/sound/soc/samsung/speyside_wm8962.c
> +++ b/sound/soc/samsung/speyside_wm8962.c
> @@ -23,6 +23,9 @@ static int speyside_wm8962_set_bias_level(struct snd_soc_card *card,
> struct snd_soc_dai *codec_dai = card->rtd[0].codec_dai;
> int ret;
>
> + if (dapm->dev != codec_dai->dev)
> + return 0;
> +
> switch (level) {
> case SND_SOC_BIAS_PREPARE:
> if (dapm->bias_level == SND_SOC_BIAS_STANDBY) {
> @@ -57,6 +60,9 @@ static int speyside_wm8962_set_bias_level_post(struct snd_soc_card *card,
> struct snd_soc_dai *codec_dai = card->rtd[0].codec_dai;
> int ret;
>
> + if (dapm->dev != codec_dai->dev)
> + return 0;
> +
> switch (level) {
> case SND_SOC_BIAS_STANDBY:
> ret = snd_soc_dai_set_sysclk(codec_dai, WM8962_SYSCLK_MCLK,
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-22 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-21 11:20 [PATCH] ASoC: Ensure we only run Speyside WM8962 bias level callbacks once Mark Brown
2011-08-22 10:23 ` Liam Girdwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.