* tpm: suppress durations sysfs output if not set
@ 2011-08-22 10:49 Stefan Berger
2011-08-23 0:49 ` James Morris
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Berger @ 2011-08-22 10:49 UTC (permalink / raw)
To: Linux kernel mailing list, Rajiv Andrade, Marcel Selhorst, James Morris
Suppress the output of durations if they were not read during driver
initialization.
This is similar to other sysfs entries that return nothing if for some
reason sending the commands to the TPM fails.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
---
drivers/char/tpm/tpm.c | 3 +++
1 file changed, 3 insertions(+)
Index: linux-2.6/drivers/char/tpm/tpm.c
===================================================================
--- linux-2.6.orig/drivers/char/tpm/tpm.c
+++ linux-2.6/drivers/char/tpm/tpm.c
@@ -963,6 +963,9 @@ ssize_t tpm_show_durations(struct device
{
struct tpm_chip *chip = dev_get_drvdata(dev);
+ if (chip->vendor.duration[TPM_LONG] == 0)
+ return 0;
+
return sprintf(buf, "%d %d %d [%s]\n",
jiffies_to_usecs(chip->vendor.duration[TPM_SHORT]),
jiffies_to_usecs(chip->vendor.duration[TPM_MEDIUM]),
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: tpm: suppress durations sysfs output if not set
2011-08-22 10:49 tpm: suppress durations sysfs output if not set Stefan Berger
@ 2011-08-23 0:49 ` James Morris
0 siblings, 0 replies; 2+ messages in thread
From: James Morris @ 2011-08-23 0:49 UTC (permalink / raw)
To: Stefan Berger; +Cc: Linux kernel mailing list, Rajiv Andrade, Marcel Selhorst
On Mon, 22 Aug 2011, Stefan Berger wrote:
> Suppress the output of durations if they were not read during driver
> initialization.
> This is similar to other sysfs entries that return nothing if for some reason
> sending the commands to the TPM fails.
>
This patch appears to be tab-damaged.
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>
> ---
> drivers/char/tpm/tpm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: linux-2.6/drivers/char/tpm/tpm.c
> ===================================================================
> --- linux-2.6.orig/drivers/char/tpm/tpm.c
> +++ linux-2.6/drivers/char/tpm/tpm.c
> @@ -963,6 +963,9 @@ ssize_t tpm_show_durations(struct device
> {
> struct tpm_chip *chip = dev_get_drvdata(dev);
>
> + if (chip->vendor.duration[TPM_LONG] == 0)
> + return 0;
> +
> return sprintf(buf, "%d %d %d [%s]\n",
> jiffies_to_usecs(chip->vendor.duration[TPM_SHORT]),
> jiffies_to_usecs(chip->vendor.duration[TPM_MEDIUM]),
>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-23 0:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-22 10:49 tpm: suppress durations sysfs output if not set Stefan Berger
2011-08-23 0:49 ` James Morris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.