From: "H. Peter Anvin" <hpa@zytor.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
kernel-hardening@lists.openwall.com,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC] x86, mm: start mmap allocation for libs from low addresses
Date: Mon, 22 Aug 2011 10:24:38 -0700 [thread overview]
Message-ID: <4E5290D6.5050406@zytor.com> (raw)
In-Reply-To: <20110822101730.GA3346@albatros>
On 08/22/2011 03:17 AM, Vasiliy Kulikov wrote:
> Hi Ingo, Peter, Thomas,
>
> On Tue, Aug 16, 2011 at 13:05 +0400, Vasiliy Kulikov wrote:
>> As the changes are not intrusive, we'd want to see this feature in the
>> upstream kernel. If you know why the patch cannot be a part of the
>> upstream kernel - please tell me, I'll try to address the issues.
>
> Any comments on the RFC? Otherwise, may I resend it as a PATCH for
> inclusion?
>
> Thanks!
Conceptually:
I also have to admit to being somewhat skeptical to the concept on a
littleendian architecture like x86.
Code-wise:
The code is horrific; it is full of open-coded magic numbers; it also
puts a function called arch_get_unmapped_exec_area() in a generic file,
which could best be described as "WTF" -- the arch_ prefix we use
specifically to denote a per-architecture hook function.
As such, your claim that the changes are not intrusive is plain false.
-hpa
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
kernel-hardening@lists.openwall.com,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC] x86, mm: start mmap allocation for libs from low addresses
Date: Mon, 22 Aug 2011 10:24:38 -0700 [thread overview]
Message-ID: <4E5290D6.5050406@zytor.com> (raw)
In-Reply-To: <20110822101730.GA3346@albatros>
On 08/22/2011 03:17 AM, Vasiliy Kulikov wrote:
> Hi Ingo, Peter, Thomas,
>
> On Tue, Aug 16, 2011 at 13:05 +0400, Vasiliy Kulikov wrote:
>> As the changes are not intrusive, we'd want to see this feature in the
>> upstream kernel. If you know why the patch cannot be a part of the
>> upstream kernel - please tell me, I'll try to address the issues.
>
> Any comments on the RFC? Otherwise, may I resend it as a PATCH for
> inclusion?
>
> Thanks!
Conceptually:
I also have to admit to being somewhat skeptical to the concept on a
littleendian architecture like x86.
Code-wise:
The code is horrific; it is full of open-coded magic numbers; it also
puts a function called arch_get_unmapped_exec_area() in a generic file,
which could best be described as "WTF" -- the arch_ prefix we use
specifically to denote a per-architecture hook function.
As such, your claim that the changes are not intrusive is plain false.
-hpa
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
kernel-hardening@lists.openwall.com,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [kernel-hardening] Re: [RFC] x86, mm: start mmap allocation for libs from low addresses
Date: Mon, 22 Aug 2011 10:24:38 -0700 [thread overview]
Message-ID: <4E5290D6.5050406@zytor.com> (raw)
In-Reply-To: <20110822101730.GA3346@albatros>
On 08/22/2011 03:17 AM, Vasiliy Kulikov wrote:
> Hi Ingo, Peter, Thomas,
>
> On Tue, Aug 16, 2011 at 13:05 +0400, Vasiliy Kulikov wrote:
>> As the changes are not intrusive, we'd want to see this feature in the
>> upstream kernel. If you know why the patch cannot be a part of the
>> upstream kernel - please tell me, I'll try to address the issues.
>
> Any comments on the RFC? Otherwise, may I resend it as a PATCH for
> inclusion?
>
> Thanks!
Conceptually:
I also have to admit to being somewhat skeptical to the concept on a
littleendian architecture like x86.
Code-wise:
The code is horrific; it is full of open-coded magic numbers; it also
puts a function called arch_get_unmapped_exec_area() in a generic file,
which could best be described as "WTF" -- the arch_ prefix we use
specifically to denote a per-architecture hook function.
As such, your claim that the changes are not intrusive is plain false.
-hpa
next prev parent reply other threads:[~2011-08-22 17:26 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 10:29 [RFC] x86, mm: start mmap allocation for libs from low addresses Vasiliy Kulikov
2011-08-12 10:29 ` [kernel-hardening] " Vasiliy Kulikov
2011-08-12 10:29 ` Vasiliy Kulikov
2011-08-12 10:58 ` [kernel-hardening] " Solar Designer
2011-08-12 11:05 ` Vasiliy Kulikov
2011-08-25 17:19 ` Vasiliy Kulikov
2011-08-25 17:39 ` Solar Designer
2011-09-02 18:29 ` Solar Designer
2011-09-03 11:18 ` Vasiliy Kulikov
2011-09-03 23:57 ` Solar Designer
2011-09-05 12:46 ` Vasiliy Kulikov
2011-09-06 5:05 ` Solar Designer
2011-09-07 9:09 ` Vasiliy Kulikov
2011-09-07 9:30 ` Solar Designer
2011-09-07 9:34 ` Vasiliy Kulikov
2011-09-07 9:43 ` Solar Designer
2011-09-07 9:55 ` Vasiliy Kulikov
2011-09-07 10:16 ` Solar Designer
2011-09-07 11:01 ` Vasiliy Kulikov
2011-09-02 23:34 ` Solar Designer
2011-09-03 12:12 ` Vasiliy Kulikov
2011-09-03 23:40 ` Solar Designer
2011-09-04 7:21 ` Vasiliy Kulikov
2011-08-12 23:19 ` H. Peter Anvin
2011-08-12 23:19 ` [kernel-hardening] " H. Peter Anvin
2011-08-12 23:19 ` H. Peter Anvin
2011-08-13 6:26 ` Vasiliy Kulikov
2011-08-13 6:26 ` [kernel-hardening] " Vasiliy Kulikov
2011-08-13 6:26 ` Vasiliy Kulikov
2011-08-16 9:05 ` Vasiliy Kulikov
2011-08-16 9:05 ` [kernel-hardening] " Vasiliy Kulikov
2011-08-16 9:05 ` Vasiliy Kulikov
2011-08-22 10:17 ` Vasiliy Kulikov
2011-08-22 10:17 ` [kernel-hardening] " Vasiliy Kulikov
2011-08-22 10:17 ` Vasiliy Kulikov
2011-08-22 17:24 ` H. Peter Anvin [this message]
2011-08-22 17:24 ` [kernel-hardening] " H. Peter Anvin
2011-08-22 17:24 ` H. Peter Anvin
2011-08-22 20:14 ` Vasiliy Kulikov
2011-08-22 20:14 ` [kernel-hardening] " Vasiliy Kulikov
2011-08-22 20:14 ` Vasiliy Kulikov
2011-08-22 20:17 ` H. Peter Anvin
2011-08-22 20:17 ` [kernel-hardening] " H. Peter Anvin
2011-08-22 20:17 ` H. Peter Anvin
2011-08-23 6:41 ` Vasiliy Kulikov
2011-08-23 6:41 ` [kernel-hardening] " Vasiliy Kulikov
2011-08-23 6:41 ` Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5290D6.5050406@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=segoon@openwall.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.