All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Kristian Amlie <kristian@amlie.name>
Cc: alsa-devel@alsa-project.org, Daniel Mack <zonque@gmail.com>
Subject: Re: How to add a new MIDI device to the usbaudio driver
Date: Wed, 24 Aug 2011 21:51:34 +0200	[thread overview]
Message-ID: <4E555646.2030209@ladisch.de> (raw)
In-Reply-To: <CACTFLANav3woJuXjdpsYEqvvbbTb53S0d2MtVoq9EByv-j-cxw@mail.gmail.com>

Daniel Mack wrote:
> Ok, then let's try the attached patch.

> +		/* reset the port */
> +		err = snd_usbmidi_ftdi_command(umidi, 0, 0);
> +		if (err < 0)
> +			break;
> +
> +		/* set mctrl */
> +		err = snd_usbmidi_ftdi_command(umidi, 1, 0x303);
> +		if (err < 0)
> +			break;

The chip reads its initial configuration from the EEPROM, so these
commands might not be necessary.

> +		/* set baud rate */
> +		err = snd_usbmidi_ftdi_command(umidi, 3, 0xc04e);

Replace 0xc04e with 0x60 to get exactly 31250 baud.

Furthermore, the FT232RL chip sends two modem status bytes in its
packets, so we need something like this to prevent them from being
interpreted as MIDI:

--- a/sound/usb/midi.c
+++ b/sound/usb/midi.c
@@ -791,7 +791,8 @@ static struct usb_protocol_ops snd_usbmidi_novation_ops = {
 static void snd_usbmidi_raw_input(struct snd_usb_midi_in_endpoint* ep,
 				  uint8_t* buffer, int buffer_length)
 {
-	snd_usbmidi_input_data(ep, 0, buffer, buffer_length);
+	if (buffer_length > 2)
+		snd_usbmidi_input_data(ep, 0, buffer + 2, buffer_length - 2);
 }

 static void snd_usbmidi_raw_output(struct snd_usb_midi_out_endpoint* ep,


Regards,
Clemens

  parent reply	other threads:[~2011-08-24 19:51 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 10:52 How to add a new MIDI device to the usbaudio driver Kristian Amlie
2011-08-22 10:54 ` Daniel Mack
2011-08-22 11:40   ` Kristian Amlie
2011-08-22 11:49     ` Daniel Mack
2011-08-23  7:35       ` Kristian Amlie
2011-08-23  8:43         ` Daniel Mack
2011-08-23  9:03           ` Paul Menzel
2011-08-23  9:22             ` Daniel Mack
2011-08-23  9:42               ` Kristian Amlie
2011-08-23 10:02                 ` Paul Menzel
2011-08-27 10:38                   ` Kristian Amlie
2011-08-23  9:38     ` Clemens Ladisch
2011-08-23  9:42       ` Daniel Mack
2011-08-23 10:07       ` Kristian Amlie
2011-08-23 10:16         ` Daniel Mack
2011-08-23 11:57           ` Kristian Amlie
2011-08-23 12:20             ` Daniel Mack
2011-08-23 13:12               ` Kristian Amlie
2011-08-23 13:16                 ` Daniel Mack
2011-08-23 13:28                   ` Kristian Amlie
2011-08-23 13:44                     ` Daniel Mack
2011-08-24  8:09                       ` Kristian Amlie
2011-08-24  8:32                         ` Daniel Mack
2011-08-24 10:14                           ` Kristian Amlie
2011-08-24 10:29                             ` Daniel Mack
2011-08-24 13:14                               ` Kristian Amlie
2011-08-24 13:18                                 ` Daniel Mack
2011-08-24 19:51                       ` Clemens Ladisch [this message]
2011-08-25 11:28                         ` Kristian Amlie
2011-08-25 11:35                           ` [PATCH] Added support for Starr Labs USB MIDI devices Kristian Amlie
2011-08-25 12:20                             ` Daniel Mack
2011-08-25 13:40                               ` Kristian Amlie
2011-08-26 11:24                                 ` Clemens Ladisch
2011-08-25 12:38                           ` How to add a new MIDI device to the usbaudio driver Daniel Mack
2011-08-24 11:44             ` Clemens Ladisch
2011-08-24 12:05               ` Daniel Mack
2011-08-24 13:19               ` Kristian Amlie
2011-08-24 16:01                 ` Clemens Ladisch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E555646.2030209@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=kristian@amlie.name \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.