[Qemu-devel] [PULL] Memory API conversions, batch 5

[Qemu-devel] [PULL] Memory API conversions, batch 5

[Avi Kivity]

Please pull from

   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch

to receive the fifth memory API conversions batch.  There is really 
nothing notable, except perhaps the first use of the transaction API.

While the patches have been on the list for just a short time, they have 
received quite extensive review, for which I am thankful.

Avi Kivity (22):
       stellaris_enet: convert to memory API
       sysbus: add helpers to add and delete memory regions to the 
system bus
       pci_host: convert conf index and data ports to memory API
       ReadWriteHandler: remove
       an5206: convert to memory API
       armv7m: convert to memory API
       axis_dev88: convert to memory API (RAM only)
       sysbus: add sysbus_add_memory_overlap()
       integratorcp: convert to memory API (RAM/flash only)
       leon3: convert to memory API
       cirrus: wrap memory update in a transaction
       piix_pci: wrap memory update in a transaction
       Makefile.hw: allow hw/ files to include glib headers
       pflash_cfi01/pflash_cfi02: convert to memory API
       dummy_m68k: convert to memory API
       g364fb: convert to memory API
       lm32_boards: convert to memory API
       mainstone: convert to memory API
       mcf5208: convert to memory API
       milkymist-minimac2: convert to memory API
       milkymist-softusb: convert to memory API
       milkymist: convert to memory API

  Makefile.hw                   |    1 +
  Makefile.target               |    1 -
  hw/an5206.c                   |   12 ++++--
  hw/arm-misc.h                 |    5 ++-
  hw/armv7m.c                   |   22 +++++----
  hw/axis_dev88.c               |   16 ++++----
  hw/cirrus_vga.c               |    2 +
  hw/collie.c                   |   16 ++++---
  hw/dec_pci.c                  |   13 +++---
  hw/dummy_m68k.c               |    7 ++-
  hw/flash.h                    |   16 +++++--
  hw/g364fb.c                   |   60 ++++++++++++++------------
  hw/grackle_pci.c              |   13 +++---
  hw/gumstix.c                  |   28 +++++++-----
  hw/integratorcp.c             |   28 +++++++++----
  hw/leon3.c                    |   15 ++++---
  hw/lm32_boards.c              |   29 +++++++-----
  hw/mainstone.c                |   33 ++++++++------
  hw/mcf5208.c                  |   72 ++++++++++++++-----------------
  hw/milkymist-minimac2.c       |   43 +++++++++----------
  hw/milkymist-softusb.c        |   48 +++++++++++-----------
  hw/milkymist.c                |   16 ++++---
  hw/mips.h                     |    4 +-
  hw/mips_jazz.c                |    3 +-
  hw/mips_malta.c               |   45 +++++++++++---------
  hw/mips_r4k.c                 |   20 +++++----
  hw/musicpal.c                 |   15 ++++---
  hw/omap_sx1.c                 |   21 +++++----
  hw/pci_host.c                 |   86 
+++++++++++++++++---------------------
  hw/pci_host.h                 |   16 +++----
  hw/petalogix_ml605_mmu.c      |    7 ++-
  hw/petalogix_s3adsp1800_mmu.c |    8 ++-
  hw/pflash_cfi01.c             |   67 ++++++++++-------------------
  hw/pflash_cfi02.c             |   93 
++++++++++++++++++++---------------------
  hw/piix_pci.c                 |   13 +++++-
  hw/ppc405_boards.c            |   63 +++++++++++++++------------
  hw/ppc4xx_pci.c               |   10 +++--
  hw/ppce500_pci.c              |   21 ++++-----
  hw/prep_pci.c                 |   12 ++++-
  hw/r2d.c                      |    7 ++-
  hw/stellaris.c                |    5 ++-
  hw/stellaris_enet.c           |   29 +++++-------
  hw/sysbus.c                   |   29 +++++++++++++
  hw/sysbus.h                   |    8 ++++
  hw/unin_pci.c                 |   82 ++++++++++++++++++------------------
  hw/virtex_ml507.c             |    7 ++-
  hw/z2.c                       |   15 ++++---
  rwhandler.c                   |   87 
--------------------------------------
  rwhandler.h                   |   27 ------------
  49 files changed, 638 insertions(+), 658 deletions(-)
  delete mode 100644 rwhandler.c
  delete mode 100644 rwhandler.h

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

[Anthony Liguori]

On 08/25/2011 03:01 AM, Avi Kivity wrote:
> Please pull from
>
> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch
>
> to receive the fifth memory API conversions batch. There is really
> nothing notable, except perhaps the first use of the transaction API.
>
> While the patches have been on the list for just a short time, they have
> received quite extensive review, for which I am thankful.

Pulled.  Thanks.

Regards,

Anthony Liguori

>
> Avi Kivity (22):
> stellaris_enet: convert to memory API
> sysbus: add helpers to add and delete memory regions to the system bus
> pci_host: convert conf index and data ports to memory API
> ReadWriteHandler: remove
> an5206: convert to memory API
> armv7m: convert to memory API
> axis_dev88: convert to memory API (RAM only)
> sysbus: add sysbus_add_memory_overlap()
> integratorcp: convert to memory API (RAM/flash only)
> leon3: convert to memory API
> cirrus: wrap memory update in a transaction
> piix_pci: wrap memory update in a transaction
> Makefile.hw: allow hw/ files to include glib headers
> pflash_cfi01/pflash_cfi02: convert to memory API
> dummy_m68k: convert to memory API
> g364fb: convert to memory API
> lm32_boards: convert to memory API
> mainstone: convert to memory API
> mcf5208: convert to memory API
> milkymist-minimac2: convert to memory API
> milkymist-softusb: convert to memory API
> milkymist: convert to memory API
>
> Makefile.hw | 1 +
> Makefile.target | 1 -
> hw/an5206.c | 12 ++++--
> hw/arm-misc.h | 5 ++-
> hw/armv7m.c | 22 +++++----
> hw/axis_dev88.c | 16 ++++----
> hw/cirrus_vga.c | 2 +
> hw/collie.c | 16 ++++---
> hw/dec_pci.c | 13 +++---
> hw/dummy_m68k.c | 7 ++-
> hw/flash.h | 16 +++++--
> hw/g364fb.c | 60 ++++++++++++++------------
> hw/grackle_pci.c | 13 +++---
> hw/gumstix.c | 28 +++++++-----
> hw/integratorcp.c | 28 +++++++++----
> hw/leon3.c | 15 ++++---
> hw/lm32_boards.c | 29 +++++++-----
> hw/mainstone.c | 33 ++++++++------
> hw/mcf5208.c | 72 ++++++++++++++-----------------
> hw/milkymist-minimac2.c | 43 +++++++++----------
> hw/milkymist-softusb.c | 48 +++++++++++-----------
> hw/milkymist.c | 16 ++++---
> hw/mips.h | 4 +-
> hw/mips_jazz.c | 3 +-
> hw/mips_malta.c | 45 +++++++++++---------
> hw/mips_r4k.c | 20 +++++----
> hw/musicpal.c | 15 ++++---
> hw/omap_sx1.c | 21 +++++----
> hw/pci_host.c | 86 +++++++++++++++++---------------------
> hw/pci_host.h | 16 +++----
> hw/petalogix_ml605_mmu.c | 7 ++-
> hw/petalogix_s3adsp1800_mmu.c | 8 ++-
> hw/pflash_cfi01.c | 67 ++++++++++-------------------
> hw/pflash_cfi02.c | 93 ++++++++++++++++++++---------------------
> hw/piix_pci.c | 13 +++++-
> hw/ppc405_boards.c | 63 +++++++++++++++------------
> hw/ppc4xx_pci.c | 10 +++--
> hw/ppce500_pci.c | 21 ++++-----
> hw/prep_pci.c | 12 ++++-
> hw/r2d.c | 7 ++-
> hw/stellaris.c | 5 ++-
> hw/stellaris_enet.c | 29 +++++-------
> hw/sysbus.c | 29 +++++++++++++
> hw/sysbus.h | 8 ++++
> hw/unin_pci.c | 82 ++++++++++++++++++------------------
> hw/virtex_ml507.c | 7 ++-
> hw/z2.c | 15 ++++---
> rwhandler.c | 87 --------------------------------------
> rwhandler.h | 27 ------------
> 49 files changed, 638 insertions(+), 658 deletions(-)
> delete mode 100644 rwhandler.c
> delete mode 100644 rwhandler.h
>

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

[Edgar E. Iglesias]

On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote:
> On 08/25/2011 03:01 AM, Avi Kivity wrote:
> >Please pull from
> >
> >git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch
> >
> >to receive the fifth memory API conversions batch. There is really
> >nothing notable, except perhaps the first use of the transaction API.
> >
> >While the patches have been on the list for just a short time, they have
> >received quite extensive review, for which I am thankful.
> 
> Pulled.  Thanks.

Guys, please start testing before applying these patches. It's not hard,
there are images on the wiki with scripts that area easy to run.

Cheers

$ gdb --args ~/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze -kernel linux.bin -serial stdio
GNU gdb (Ubuntu/Linaro 7.3-0ubuntu1) 7.3-2011.08~bzr
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /home/edgar/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze...done.
(gdb) run
Starting program: /home/edgar/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze -kernel linux.bin -serial stdio
[Thread debugging using libthread_db enabled]
[New Thread 0x7fffeef3e700 (LWP 25891)]

Program received signal SIGSEGV, Segmentation fault.
0x000000000041be54 in memory_region_init_rom_device (mr=0xfb6900, 
    ops=<optimized out>, dev=<optimized out>, 
    name=0x564c5d "petalogix_s3adsp1800.flash", size=16777216)
    at /home/edgar/src/c/qemu/qemu/memory.c:973
973         mr->ram_addr |= cpu_register_io_memory(memory_region_read_thunk,
(gdb) 

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

[Blue Swirl]

On Thu, Aug 25, 2011 at 6:27 PM, Edgar E. Iglesias
<edgar.iglesias@gmail.com> wrote:
> On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote:
>> On 08/25/2011 03:01 AM, Avi Kivity wrote:
>> >Please pull from
>> >
>> >git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch
>> >
>> >to receive the fifth memory API conversions batch. There is really
>> >nothing notable, except perhaps the first use of the transaction API.
>> >
>> >While the patches have been on the list for just a short time, they have
>> >received quite extensive review, for which I am thankful.
>>
>> Pulled.  Thanks.
>
> Guys, please start testing before applying these patches. It's not hard,
> there are images on the wiki with scripts that area easy to run.

It's also possible to revert offending patches. But a better solution
would be to have a comprehensive test setup to do builds and run
checks on selected trees. Before a pull to main tree, the test results
should be available.

>
> Cheers
>
> $ gdb --args ~/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze -kernel linux.bin -serial stdio
> GNU gdb (Ubuntu/Linaro 7.3-0ubuntu1) 7.3-2011.08~bzr
> Copyright (C) 2011 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "x86_64-linux-gnu".
> For bug reporting instructions, please see:
> <http://www.gnu.org/software/gdb/bugs/>...
> Reading symbols from /home/edgar/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze...done.
> (gdb) run
> Starting program: /home/edgar/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze -kernel linux.bin -serial stdio
> [Thread debugging using libthread_db enabled]
> [New Thread 0x7fffeef3e700 (LWP 25891)]
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x000000000041be54 in memory_region_init_rom_device (mr=0xfb6900,
>    ops=<optimized out>, dev=<optimized out>,
>    name=0x564c5d "petalogix_s3adsp1800.flash", size=16777216)
>    at /home/edgar/src/c/qemu/qemu/memory.c:973
> 973         mr->ram_addr |= cpu_register_io_memory(memory_region_read_thunk,
> (gdb)
>
>

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

[Anthony Liguori]

On 08/25/2011 01:58 PM, Blue Swirl wrote:
> On Thu, Aug 25, 2011 at 6:27 PM, Edgar E. Iglesias
> <edgar.iglesias@gmail.com>  wrote:
>> On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote:
>>> On 08/25/2011 03:01 AM, Avi Kivity wrote:
>>>> Please pull from
>>>>
>>>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch
>>>>
>>>> to receive the fifth memory API conversions batch. There is really
>>>> nothing notable, except perhaps the first use of the transaction API.
>>>>
>>>> While the patches have been on the list for just a short time, they have
>>>> received quite extensive review, for which I am thankful.
>>>
>>> Pulled.  Thanks.
>>
>> Guys, please start testing before applying these patches. It's not hard,
>> there are images on the wiki with scripts that area easy to run.
>
> It's also possible to revert offending patches. But a better solution
> would be to have a comprehensive test setup to do builds and run
> checks on selected trees. Before a pull to main tree, the test results
> should be available.

Before a pull *request*.  Semantically, pull requests should be treated 
as a push.  It's the submaintainers responsibility to test the bits they 
do a pull request for.

That said, the logistics of testing a series like this is mind numbingly 
complex.  We really need to all work on better automation for this.  In 
the interim, I think we're just going to have to leave with occasional 
breakage from changes like this and make sure it doesn't happen too 
frequently.

Regards,

Anthony Liguori

>
>>
>> Cheers
>>
>> $ gdb --args ~/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze -kernel linux.bin -serial stdio
>> GNU gdb (Ubuntu/Linaro 7.3-0ubuntu1) 7.3-2011.08~bzr
>> Copyright (C) 2011 Free Software Foundation, Inc.
>> License GPLv3+: GNU GPL version 3 or later<http://gnu.org/licenses/gpl.html>
>> This is free software: you are free to change and redistribute it.
>> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
>> and "show warranty" for details.
>> This GDB was configured as "x86_64-linux-gnu".
>> For bug reporting instructions, please see:
>> <http://www.gnu.org/software/gdb/bugs/>...
>> Reading symbols from /home/edgar/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze...done.
>> (gdb) run
>> Starting program: /home/edgar/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze -kernel linux.bin -serial stdio
>> [Thread debugging using libthread_db enabled]
>> [New Thread 0x7fffeef3e700 (LWP 25891)]
>>
>> Program received signal SIGSEGV, Segmentation fault.
>> 0x000000000041be54 in memory_region_init_rom_device (mr=0xfb6900,
>>     ops=<optimized out>, dev=<optimized out>,
>>     name=0x564c5d "petalogix_s3adsp1800.flash", size=16777216)
>>     at /home/edgar/src/c/qemu/qemu/memory.c:973
>> 973         mr->ram_addr |= cpu_register_io_memory(memory_region_read_thunk,
>> (gdb)
>>
>>
>
>

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

[Blue Swirl]

On Thu, Aug 25, 2011 at 7:02 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 08/25/2011 01:58 PM, Blue Swirl wrote:
>>
>> On Thu, Aug 25, 2011 at 6:27 PM, Edgar E. Iglesias
>> <edgar.iglesias@gmail.com>  wrote:
>>>
>>> On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote:
>>>>
>>>> On 08/25/2011 03:01 AM, Avi Kivity wrote:
>>>>>
>>>>> Please pull from
>>>>>
>>>>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch
>>>>>
>>>>> to receive the fifth memory API conversions batch. There is really
>>>>> nothing notable, except perhaps the first use of the transaction API.
>>>>>
>>>>> While the patches have been on the list for just a short time, they
>>>>> have
>>>>> received quite extensive review, for which I am thankful.
>>>>
>>>> Pulled.  Thanks.
>>>
>>> Guys, please start testing before applying these patches. It's not hard,
>>> there are images on the wiki with scripts that area easy to run.
>>
>> It's also possible to revert offending patches. But a better solution
>> would be to have a comprehensive test setup to do builds and run
>> checks on selected trees. Before a pull to main tree, the test results
>> should be available.
>
> Before a pull *request*.  Semantically, pull requests should be treated as a
> push.  It's the submaintainers responsibility to test the bits they do a
> pull request for.

Then all maintainers should have the same understanding of what to test.

> That said, the logistics of testing a series like this is mind numbingly
> complex.  We really need to all work on better automation for this.  In the
> interim, I think we're just going to have to leave with occasional breakage
> from changes like this and make sure it doesn't happen too frequently.

Alex's simple script idea for kernel devs could be reused here. The
following would already catch a few errors:
#!/bin/sh
set -e
mkdir obj
cd obj
../configure
make -j
for f in ./*-softmmu/qemu-system-* ./i386-softmmu/qemu; do
  echo running $f, exit with Ctrl-a x:
  $f
done

This could be integrated to Makefile as well, maybe even generate
timestamp files which would be read by git commit hooks to add extra
lines about test status.

> Regards,
>
> Anthony Liguori
>
>>
>>>
>>> Cheers
>>>
>>> $ gdb --args
>>> ~/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze -kernel
>>> linux.bin -serial stdio
>>> GNU gdb (Ubuntu/Linaro 7.3-0ubuntu1) 7.3-2011.08~bzr
>>> Copyright (C) 2011 Free Software Foundation, Inc.
>>> License GPLv3+: GNU GPL version 3 or
>>> later<http://gnu.org/licenses/gpl.html>
>>> This is free software: you are free to change and redistribute it.
>>> There is NO WARRANTY, to the extent permitted by law.  Type "show
>>> copying"
>>> and "show warranty" for details.
>>> This GDB was configured as "x86_64-linux-gnu".
>>> For bug reporting instructions, please see:
>>> <http://www.gnu.org/software/gdb/bugs/>...
>>> Reading symbols from
>>> /home/edgar/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze...done.
>>> (gdb) run
>>> Starting program:
>>> /home/edgar/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze
>>> -kernel linux.bin -serial stdio
>>> [Thread debugging using libthread_db enabled]
>>> [New Thread 0x7fffeef3e700 (LWP 25891)]
>>>
>>> Program received signal SIGSEGV, Segmentation fault.
>>> 0x000000000041be54 in memory_region_init_rom_device (mr=0xfb6900,
>>>    ops=<optimized out>, dev=<optimized out>,
>>>    name=0x564c5d "petalogix_s3adsp1800.flash", size=16777216)
>>>    at /home/edgar/src/c/qemu/qemu/memory.c:973
>>> 973         mr->ram_addr |=
>>> cpu_register_io_memory(memory_region_read_thunk,
>>> (gdb)
>>>
>>>
>>
>>
>
>

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

[Edgar E. Iglesias]

On Thu, Aug 25, 2011 at 02:02:24PM -0500, Anthony Liguori wrote:
> On 08/25/2011 01:58 PM, Blue Swirl wrote:
> >On Thu, Aug 25, 2011 at 6:27 PM, Edgar E. Iglesias
> ><edgar.iglesias@gmail.com>  wrote:
> >>On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote:
> >>>On 08/25/2011 03:01 AM, Avi Kivity wrote:
> >>>>Please pull from
> >>>>
> >>>>git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch
> >>>>
> >>>>to receive the fifth memory API conversions batch. There is really
> >>>>nothing notable, except perhaps the first use of the transaction API.
> >>>>
> >>>>While the patches have been on the list for just a short time, they have
> >>>>received quite extensive review, for which I am thankful.
> >>>
> >>>Pulled.  Thanks.
> >>
> >>Guys, please start testing before applying these patches. It's not hard,
> >>there are images on the wiki with scripts that area easy to run.
> >
> >It's also possible to revert offending patches. But a better solution
> >would be to have a comprehensive test setup to do builds and run
> >checks on selected trees. Before a pull to main tree, the test results
> >should be available.
> 
> Before a pull *request*.  Semantically, pull requests should be
> treated as a push.  It's the submaintainers responsibility to test
> the bits they do a pull request for.

Yup.

> That said, the logistics of testing a series like this is mind
> numbingly complex.  We really need to all work on better automation
> for this.  In the interim, I think we're just going to have to leave
> with occasional breakage from changes like this and make sure it
> doesn't happen too frequently.

Yes, I understand its not an easy to test all combinations. But there
are scripts that testrun various targets on the wiki. It doesnt take
long to run those. You can also explicitely ask for help with the testing.
I'm happy to assist if the test scripts dont run or if you CC me on
a testme request.

Avi's done a great job with these series, converting all targets and all.
I dont mean to misscredit that.

Cheers

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

[Avi Kivity]

On 08/25/2011 09:58 PM, Blue Swirl wrote:
> >
> >  Guys, please start testing before applying these patches. It's not hard,
> >  there are images on the wiki with scripts that area easy to run.
>
> It's also possible to revert offending patches.

Please revert the entire pull (git revert 8ef9ea85a2cc1) while I work 
this out - it isn't trivial.

> But a better solution
> would be to have a comprehensive test setup to do builds and run
> checks on selected trees. Before a pull to main tree, the test results
> should be available.
>

True, we should be able to get kvm-autotest to do a sanity test.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 2292 bytes --]

On 2011-08-25 20:27, Edgar E. Iglesias wrote:
> On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote:
>> On 08/25/2011 03:01 AM, Avi Kivity wrote:
>>> Please pull from
>>>
>>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch
>>>
>>> to receive the fifth memory API conversions batch. There is really
>>> nothing notable, except perhaps the first use of the transaction API.
>>>
>>> While the patches have been on the list for just a short time, they have
>>> received quite extensive review, for which I am thankful.
>>
>> Pulled.  Thanks.
> 
> Guys, please start testing before applying these patches. It's not hard,
> there are images on the wiki with scripts that area easy to run.
> 
> Cheers
> 
> $ gdb --args ~/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze -kernel linux.bin -serial stdio
> GNU gdb (Ubuntu/Linaro 7.3-0ubuntu1) 7.3-2011.08~bzr
> Copyright (C) 2011 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "x86_64-linux-gnu".
> For bug reporting instructions, please see:
> <http://www.gnu.org/software/gdb/bugs/>...
> Reading symbols from /home/edgar/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze...done.
> (gdb) run
> Starting program: /home/edgar/src/c/qemu/build-qemu/microblaze-softmmu/qemu-system-microblaze -kernel linux.bin -serial stdio
> [Thread debugging using libthread_db enabled]
> [New Thread 0x7fffeef3e700 (LWP 25891)]
> 
> Program received signal SIGSEGV, Segmentation fault.
> 0x000000000041be54 in memory_region_init_rom_device (mr=0xfb6900, 
>     ops=<optimized out>, dev=<optimized out>, 
>     name=0x564c5d "petalogix_s3adsp1800.flash", size=16777216)
>     at /home/edgar/src/c/qemu/qemu/memory.c:973
> 973         mr->ram_addr |= cpu_register_io_memory(memory_region_read_thunk,
> (gdb) 

That looks pretty much like what I stumbled over today as well. Should
be fine with [1], need to test again.

Jan

[1] http://thread.gmane.org/gmane.comp.emulators.qemu/114619


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

[Avi Kivity]

On 08/25/2011 10:32 PM, Jan Kiszka wrote:
> >
> >  Program received signal SIGSEGV, Segmentation fault.
> >  0x000000000041be54 in memory_region_init_rom_device (mr=0xfb6900,
> >      ops=<optimized out>, dev=<optimized out>,
> >      name=0x564c5d "petalogix_s3adsp1800.flash", size=16777216)
> >      at /home/edgar/src/c/qemu/qemu/memory.c:973
> >  973         mr->ram_addr |= cpu_register_io_memory(memory_region_read_thunk,
> >  (gdb)
>
> That looks pretty much like what I stumbled over today as well. Should
> be fine with [1], need to test again.

I did and it's not, need to find an opaque from somewhere and initialize 
that too.


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

On 2011-08-25 21:36, Avi Kivity wrote:
> On 08/25/2011 10:32 PM, Jan Kiszka wrote:
>> >
>> >  Program received signal SIGSEGV, Segmentation fault.
>> >  0x000000000041be54 in memory_region_init_rom_device (mr=0xfb6900,
>> >      ops=<optimized out>, dev=<optimized out>,
>> >      name=0x564c5d "petalogix_s3adsp1800.flash", size=16777216)
>> >      at /home/edgar/src/c/qemu/qemu/memory.c:973
>> >  973         mr->ram_addr |=
>> cpu_register_io_memory(memory_region_read_thunk,
>> >  (gdb)
>>
>> That looks pretty much like what I stumbled over today as well. Should
>> be fine with [1], need to test again.
> 
> I did and it's not, need to find an opaque from somewhere and initialize
> that too.

Ugh, yeah, the result is different but still broken.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

[Markus Armbruster]

Blue Swirl <blauwirbel@gmail.com> writes:

> On Thu, Aug 25, 2011 at 7:02 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
>> On 08/25/2011 01:58 PM, Blue Swirl wrote:
>>>
>>> On Thu, Aug 25, 2011 at 6:27 PM, Edgar E. Iglesias
>>> <edgar.iglesias@gmail.com>  wrote:
[...]
>>>> Guys, please start testing before applying these patches. It's not hard,
>>>> there are images on the wiki with scripts that area easy to run.
>>>
>>> It's also possible to revert offending patches. But a better solution
>>> would be to have a comprehensive test setup to do builds and run
>>> checks on selected trees. Before a pull to main tree, the test results
>>> should be available.
>>
>> Before a pull *request*.  Semantically, pull requests should be treated as a
>> push.  It's the submaintainers responsibility to test the bits they do a
>> pull request for.
>
> Then all maintainers should have the same understanding of what to test.

In my opinion, the way to spread that understanding is a working "make
check".  Make it fail constructively when it needs more stuff installed,
like test images, or additional software.

Anything more complicated than such a one-liner is bound to be misused,
forgotten, or ignored.

Heck, if it's that simple, even non-maintainers could use it ;)

[...]