* help? need to enable VT-d for 2.6.27 @ 2011-08-30 16:29 Chris Friesen 2011-08-30 17:55 ` David Ahern 0 siblings, 1 reply; 16+ messages in thread From: Chris Friesen @ 2011-08-30 16:29 UTC (permalink / raw) To: Avi Kivity, mtosatti, kvm I'm in a bit of an odd situation. We run an embedded version of linux on many different boards with different vendor agreements so it's painful to upgrade kernel versions. I've been asked to provide VT-d support for KVM on our kernel (primarily for mapping NIC VFs into the guests), and I'm trying to figure out my best option to get a working implementation. Looking at the kvm git tree, kvm-77 seems to be based off 2.6.27. Should I look at porting that? Would I be better off just scanning for anything VT-d related in 2.6.28 and backporting it? Are there any better options? Any advice you could provide would be appreciated. Thanks, Chris -- Chris Friesen Software Developer GENBAND chris.friesen@genband.com www.genband.com ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: help? need to enable VT-d for 2.6.27 2011-08-30 16:29 help? need to enable VT-d for 2.6.27 Chris Friesen @ 2011-08-30 17:55 ` David Ahern 2011-08-30 18:11 ` Chris Friesen 0 siblings, 1 reply; 16+ messages in thread From: David Ahern @ 2011-08-30 17:55 UTC (permalink / raw) To: Chris Friesen; +Cc: Avi Kivity, mtosatti, kvm On 08/30/2011 10:29 AM, Chris Friesen wrote: > > I'm in a bit of an odd situation. We run an embedded version of linux > on many different boards with different vendor agreements so it's > painful to upgrade kernel versions. > > I've been asked to provide VT-d support for KVM on our kernel (primarily > for mapping NIC VFs into the guests), and I'm trying to figure out my > best option to get a working implementation. I've had pains with VF passthrough with as late as a Fedora 14 kernel (2.6.35). Ended up punting and moving to 2.6.39. > > Looking at the kvm git tree, kvm-77 seems to be based off 2.6.27. Should > I look at porting that? By 2.6.27 do you mean WRL3 or something else? David > > Would I be better off just scanning for anything VT-d related in 2.6.28 > and backporting it? > > Are there any better options? Any advice you could provide would be > appreciated. > > Thanks, > Chris > > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: help? need to enable VT-d for 2.6.27 2011-08-30 17:55 ` David Ahern @ 2011-08-30 18:11 ` Chris Friesen 2011-08-30 18:31 ` David Ahern 0 siblings, 1 reply; 16+ messages in thread From: Chris Friesen @ 2011-08-30 18:11 UTC (permalink / raw) To: David Ahern; +Cc: Avi Kivity, mtosatti, kvm On 08/30/2011 11:55 AM, David Ahern wrote: > On 08/30/2011 10:29 AM, Chris Friesen wrote: >> >> I'm in a bit of an odd situation. We run an embedded version of linux >> on many different boards with different vendor agreements so it's >> painful to upgrade kernel versions. >> >> I've been asked to provide VT-d support for KVM on our kernel (primarily >> for mapping NIC VFs into the guests), and I'm trying to figure out my >> best option to get a working implementation. > > I've had pains with VF passthrough with as late as a Fedora 14 kernel > (2.6.35). Ended up punting and moving to 2.6.39. Ouch. Not good news, but not entirely unexpected. Are you doing anything complicated, or was this just basic functionality that wasn't working? >> Looking at the kvm git tree, kvm-77 seems to be based off 2.6.27. Should >> I look at porting that? > > By 2.6.27 do you mean WRL3 or something else? Yes, that's correct. (Wind River Linux 3, for the non-embedded types out there.) Chris -- Chris Friesen Software Developer GENBAND chris.friesen@genband.com www.genband.com ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: help? need to enable VT-d for 2.6.27 2011-08-30 18:11 ` Chris Friesen @ 2011-08-30 18:31 ` David Ahern 2011-08-30 19:39 ` Chris Friesen 0 siblings, 1 reply; 16+ messages in thread From: David Ahern @ 2011-08-30 18:31 UTC (permalink / raw) To: Chris Friesen; +Cc: Avi Kivity, mtosatti, kvm On 08/30/2011 12:11 PM, Chris Friesen wrote: > On 08/30/2011 11:55 AM, David Ahern wrote: >> On 08/30/2011 10:29 AM, Chris Friesen wrote: >>> >>> I'm in a bit of an odd situation. We run an embedded version of linux >>> on many different boards with different vendor agreements so it's >>> painful to upgrade kernel versions. >>> >>> I've been asked to provide VT-d support for KVM on our kernel (primarily >>> for mapping NIC VFs into the guests), and I'm trying to figure out my >>> best option to get a working implementation. >> >> I've had pains with VF passthrough with as late as a Fedora 14 kernel >> (2.6.35). Ended up punting and moving to 2.6.39. > > Ouch. Not good news, but not entirely unexpected. Are you doing > anything complicated, or was this just basic functionality that wasn't > working? In my case I am setting the MAC address for the VFs in the host at boot; they are getting reset on passthrough so the VM driver creates a random one. A backport of commit a6b5ea3 fixes one aspect. Looking at the code for the igb driver I think commit 8fa7e0f fixes the other reset problem. On the plus side I can tell you that the VF driver for the VM http://sourceforge.net/projects/e1000/files/igbvf%20stable/ compiles cleaning against WRL3 and appears to work fine (limited testing with benchmarks). kernel module wise I ran some basic KVM tests with kvm-kmod-2.6.32.27; I have not tried VF passthrough. This is on my radar as well, so I would be interested in what you learn. David > >>> Looking at the kvm git tree, kvm-77 seems to be based off 2.6.27. Should >>> I look at porting that? >> >> By 2.6.27 do you mean WRL3 or something else? > > Yes, that's correct. (Wind River Linux 3, for the non-embedded types > out there.) > > Chris > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: help? need to enable VT-d for 2.6.27 2011-08-30 18:31 ` David Ahern @ 2011-08-30 19:39 ` Chris Friesen 2011-08-30 19:54 ` David Ahern 2011-08-30 19:59 ` Jan Kiszka 0 siblings, 2 replies; 16+ messages in thread From: Chris Friesen @ 2011-08-30 19:39 UTC (permalink / raw) To: David Ahern; +Cc: Avi Kivity, mtosatti, kvm On 08/30/2011 12:31 PM, David Ahern wrote: > In my case I am setting the MAC address for the VFs in the host at boot; > they are getting reset on passthrough so the VM driver creates a random > one. A backport of commit a6b5ea3 fixes one aspect. Looking at the code > for the igb driver I think commit 8fa7e0f fixes the other reset problem. > > On the plus side I can tell you that the VF driver for the VM > http://sourceforge.net/projects/e1000/files/igbvf%20stable/ > > compiles cleaning against WRL3 and appears to work fine (limited testing > with benchmarks). > > kernel module wise I ran some basic KVM tests with kvm-kmod-2.6.32.27; I > have not tried VF passthrough. This is on my radar as well, so I would > be interested in what you learn. I downloaded the latest kvm-kmod release. It looks interesting, but it has some issues: 1) I use separate source and build output directories. kvm-kmod assumes that there is a "source" link in my build output directory pointing back to the source directory. This doesn't exist, so the build breaks. 2) If I create such a link, it builds a few files, and then gives the following: /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c: In function ‘vcpu_enter_guest’: /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c:5539:26: error: ‘prof_on’ undeclared (first use in this function) /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c:5539:26: note: each undeclared identifier is reported only once for each function it appears in This appears to be due to the fact that KVM_PROFILING is defined unconditionally in my kernel, but "prof_on" is only defined if CONFIG_PROFILING is enabled. Commenting out that chunk of code in x86.c lets everything build. I haven't tried actually loading it yet, that will be next. Thanks for the pointer. Chris -- Chris Friesen Software Developer GENBAND chris.friesen@genband.com www.genband.com ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: help? need to enable VT-d for 2.6.27 2011-08-30 19:39 ` Chris Friesen @ 2011-08-30 19:54 ` David Ahern 2011-08-30 19:59 ` Jan Kiszka 1 sibling, 0 replies; 16+ messages in thread From: David Ahern @ 2011-08-30 19:54 UTC (permalink / raw) To: Chris Friesen; +Cc: Avi Kivity, mtosatti, kvm On 08/30/2011 01:39 PM, Chris Friesen wrote: > On 08/30/2011 12:31 PM, David Ahern wrote: > >> In my case I am setting the MAC address for the VFs in the host at boot; >> they are getting reset on passthrough so the VM driver creates a random >> one. A backport of commit a6b5ea3 fixes one aspect. Looking at the code >> for the igb driver I think commit 8fa7e0f fixes the other reset problem. >> >> On the plus side I can tell you that the VF driver for the VM >> http://sourceforge.net/projects/e1000/files/igbvf%20stable/ >> >> compiles cleaning against WRL3 and appears to work fine (limited testing >> with benchmarks). >> >> kernel module wise I ran some basic KVM tests with kvm-kmod-2.6.32.27; I >> have not tried VF passthrough. This is on my radar as well, so I would >> be interested in what you learn. > > I downloaded the latest kvm-kmod release. It looks interesting, but it > has some issues: > > 1) I use separate source and build output directories. kvm-kmod assumes > that there is a "source" link in my build output directory pointing back > to the source directory. This doesn't exist, so the build breaks. > > 2) If I create such a link, it builds a few files, and then gives the > following: > > /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c: In function > ‘vcpu_enter_guest’: > /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c:5539:26: error: > ‘prof_on’ undeclared (first use in this function) > /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c:5539:26: note: each > undeclared identifier is reported only once for each function it appears in > > > This appears to be due to the fact that KVM_PROFILING is defined > unconditionally in my kernel, but "prof_on" is only defined if > CONFIG_PROFILING is enabled. Commenting out that chunk of code in x86.c > lets everything build. I was a bit nervous trying kmod's from that much ahead of 2.6.27; that's why I picked the 2.6.32 train. Also, the notes for adding the device assignment to Fedora 11 might come in handy: http://fedoraproject.org/wiki/Features/KVM_PCI_Device_Assignment I have not walked through the bug references yet, but Fedora 11 is not too far ahead of WRL3. When I backported perf to WRL3 I used Fedora 10 as a reference. For VT-d, Fedora 11 would be interesting to look at -- is the support complete in F-11 and if so take a look at its kernel source. David > > I haven't tried actually loading it yet, that will be next. > > Thanks for the pointer. > Chris > > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: help? need to enable VT-d for 2.6.27 2011-08-30 19:39 ` Chris Friesen 2011-08-30 19:54 ` David Ahern @ 2011-08-30 19:59 ` Jan Kiszka 2011-08-30 23:03 ` Chris Friesen 2011-08-31 0:03 ` [BUG] error compiling qemu-kvm-0.15.0 without vnc Chris Friesen 1 sibling, 2 replies; 16+ messages in thread From: Jan Kiszka @ 2011-08-30 19:59 UTC (permalink / raw) To: Chris Friesen; +Cc: David Ahern, Avi Kivity, mtosatti, kvm [-- Attachment #1: Type: text/plain, Size: 2328 bytes --] On 2011-08-30 21:39, Chris Friesen wrote: > On 08/30/2011 12:31 PM, David Ahern wrote: > >> In my case I am setting the MAC address for the VFs in the host at boot; >> they are getting reset on passthrough so the VM driver creates a random >> one. A backport of commit a6b5ea3 fixes one aspect. Looking at the code >> for the igb driver I think commit 8fa7e0f fixes the other reset problem. >> >> On the plus side I can tell you that the VF driver for the VM >> http://sourceforge.net/projects/e1000/files/igbvf%20stable/ >> >> compiles cleaning against WRL3 and appears to work fine (limited testing >> with benchmarks). >> >> kernel module wise I ran some basic KVM tests with kvm-kmod-2.6.32.27; I >> have not tried VF passthrough. This is on my radar as well, so I would >> be interested in what you learn. > > I downloaded the latest kvm-kmod release. It looks interesting, but it > has some issues: > > 1) I use separate source and build output directories. kvm-kmod assumes > that there is a "source" link in my build output directory pointing back > to the source directory. This doesn't exist, so the build breaks. That's at least how recent vanilla kernels work. I think to remember that my old OpenSUSE 11.1 (2.6.27) used to work fine with kvm-kmod as well, and that was an out-of-tree setup too (but maybe a post-processed one). Anyway, if you have some patch to fix this, it will always be welcome. > > 2) If I create such a link, it builds a few files, and then gives the > following: > > /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c: In function > ‘vcpu_enter_guest’: > /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c:5539:26: error: > ‘prof_on’ undeclared (first use in this function) > /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c:5539:26: note: each > undeclared identifier is reported only once for each function it appears in > > > This appears to be due to the fact that KVM_PROFILING is defined > unconditionally in my kernel, but "prof_on" is only defined if > CONFIG_PROFILING is enabled. Commenting out that chunk of code in x86.c > lets everything build. If CONFIG_PROFILING is off, prof_on is defined to 0. But we may miss some include on older kernels. Does adding linux/profile.h to x86.c solve the issue as well? Jan [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 262 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: help? need to enable VT-d for 2.6.27 2011-08-30 19:59 ` Jan Kiszka @ 2011-08-30 23:03 ` Chris Friesen 2011-08-31 7:30 ` Jan Kiszka 2011-08-31 0:03 ` [BUG] error compiling qemu-kvm-0.15.0 without vnc Chris Friesen 1 sibling, 1 reply; 16+ messages in thread From: Chris Friesen @ 2011-08-30 23:03 UTC (permalink / raw) To: Jan Kiszka; +Cc: David Ahern, Avi Kivity, mtosatti, kvm On 08/30/2011 01:59 PM, Jan Kiszka wrote: > On 2011-08-30 21:39, Chris Friesen wrote: >> 2) If I create such a link, it builds a few files, and then gives the >> following: >> >> /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c: In function >> ‘vcpu_enter_guest’: >> /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c:5539:26: error: >> ‘prof_on’ undeclared (first use in this function) >> /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c:5539:26: note: each >> undeclared identifier is reported only once for each function it appears in >> >> >> This appears to be due to the fact that KVM_PROFILING is defined >> unconditionally in my kernel, but "prof_on" is only defined if >> CONFIG_PROFILING is enabled. Commenting out that chunk of code in x86.c >> lets everything build. > > If CONFIG_PROFILING is off, prof_on is defined to 0. But we may miss > some include on older kernels. Does adding linux/profile.h to x86.c > solve the issue as well? It would appear that I got the explanation wrong. CONFIG_PROFILING is enabled on my kernel. The problem is that our OS vendor has included a patch to convert prof_on to immediate values, which requires a change in x86.c. Never mind, nothing to see here. Chris -- Chris Friesen Software Developer GENBAND chris.friesen@genband.com www.genband.com ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: help? need to enable VT-d for 2.6.27 2011-08-30 23:03 ` Chris Friesen @ 2011-08-31 7:30 ` Jan Kiszka 0 siblings, 0 replies; 16+ messages in thread From: Jan Kiszka @ 2011-08-31 7:30 UTC (permalink / raw) To: Chris Friesen; +Cc: David Ahern, Avi Kivity, mtosatti, kvm [-- Attachment #1: Type: text/plain, Size: 1420 bytes --] On 2011-08-31 01:03, Chris Friesen wrote: > On 08/30/2011 01:59 PM, Jan Kiszka wrote: >> On 2011-08-30 21:39, Chris Friesen wrote: > >>> 2) If I create such a link, it builds a few files, and then gives the >>> following: >>> >>> /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c: In function >>> ‘vcpu_enter_guest’: >>> /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c:5539:26: error: >>> ‘prof_on’ undeclared (first use in this function) >>> /home/cfriesen/Download/kvm-kmod-3.0b/x86/x86.c:5539:26: note: each >>> undeclared identifier is reported only once for each function it >>> appears in >>> >>> >>> This appears to be due to the fact that KVM_PROFILING is defined >>> unconditionally in my kernel, but "prof_on" is only defined if >>> CONFIG_PROFILING is enabled. Commenting out that chunk of code in x86.c >>> lets everything build. >> >> If CONFIG_PROFILING is off, prof_on is defined to 0. But we may miss >> some include on older kernels. Does adding linux/profile.h to x86.c >> solve the issue as well? > > > It would appear that I got the explanation wrong. CONFIG_PROFILING is > enabled on my kernel. The problem is that our OS vendor has included a > patch to convert prof_on to immediate values, which requires a change in > x86.c. Ah, now I remember: LTTng fallouts. I think there was just some EXPORT_SYMBOL missing in the kernel, but my memory is weak. Jan [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 262 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* [BUG] error compiling qemu-kvm-0.15.0 without vnc 2011-08-30 19:59 ` Jan Kiszka 2011-08-30 23:03 ` Chris Friesen @ 2011-08-31 0:03 ` Chris Friesen 2011-08-31 7:40 ` [Qemu-devel] " Jan Kiszka 1 sibling, 1 reply; 16+ messages in thread From: Chris Friesen @ 2011-08-31 0:03 UTC (permalink / raw) To: Jan Kiszka; +Cc: Avi Kivity, mtosatti, kvm Hi, I've run into another problem. I configured qemu-kvm-0.15.0 as: ./configure --target-list="i386-softmmu,x86_64-softmmu" --disable-sdl --disable-vnc --disable-curses Building it, I get: CC i386-softmmu/pcspk.o CC i386-softmmu/i8254.o CC i386-softmmu/i8254-kvm.o CC i386-softmmu/device-assignment.o LINK i386-softmmu/qemu monitor.o: In function `add_graphics_client': /home/cfriesen/Download/qemu-kvm-0.15.0/monitor.c:1226: undefined reference to `vnc_display_add_client' collect2: ld returned 1 exit status make[1]: *** [qemu] Error 1 make: *** [subdir-i386-softmmu] Error 2 The following patch allowed it to compile, but I don't know enough about kvm to know if this is the proper thing to do. Chris Index: cfriesen/Download/qemu-kvm-0.15.0/console.h =================================================================== --- cfriesen.orig/Download/qemu-kvm-0.15.0/console.h +++ cfriesen/Download/qemu-kvm-0.15.0/console.h @@ -372,15 +372,18 @@ void cocoa_display_init(DisplayState *ds void vnc_display_init(DisplayState *ds); void vnc_display_close(DisplayState *ds); int vnc_display_open(DisplayState *ds, const char *display); -void vnc_display_add_client(DisplayState *ds, int csock, int skipauth); int vnc_display_disable_login(DisplayState *ds); char *vnc_display_local_addr(DisplayState *ds); #ifdef CONFIG_VNC +void vnc_display_add_client(DisplayState *ds, int csock, int skipauth); int vnc_display_password(DisplayState *ds, const char *password); int vnc_display_pw_expire(DisplayState *ds, time_t expires); void do_info_vnc_print(Monitor *mon, const QObject *data); void do_info_vnc(Monitor *mon, QObject **ret_data); #else +static inline void vnc_display_add_client(DisplayState *ds, int csock, int skipauth) +{ +} static inline int vnc_display_password(DisplayState *ds, const char *password) { qerror_report(QERR_FEATURE_DISABLED, "vnc"); -- Chris Friesen Software Developer GENBAND chris.friesen@genband.com www.genband.com ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [BUG] error compiling qemu-kvm-0.15.0 without vnc 2011-08-31 0:03 ` [BUG] error compiling qemu-kvm-0.15.0 without vnc Chris Friesen @ 2011-08-31 7:40 ` Jan Kiszka 0 siblings, 0 replies; 16+ messages in thread From: Jan Kiszka @ 2011-08-31 7:40 UTC (permalink / raw) To: Chris Friesen; +Cc: mtosatti, Avi Kivity, kvm, qemu-devel [-- Attachment #1: Type: text/plain, Size: 2267 bytes --] On 2011-08-31 02:03, Chris Friesen wrote: > Hi, > > I've run into another problem. I configured qemu-kvm-0.15.0 as: > > ./configure --target-list="i386-softmmu,x86_64-softmmu" --disable-sdl --disable-vnc --disable-curses > > > Building it, I get: > > CC i386-softmmu/pcspk.o > CC i386-softmmu/i8254.o > CC i386-softmmu/i8254-kvm.o > CC i386-softmmu/device-assignment.o > LINK i386-softmmu/qemu > monitor.o: In function `add_graphics_client': > /home/cfriesen/Download/qemu-kvm-0.15.0/monitor.c:1226: undefined reference to `vnc_display_add_client' > collect2: ld returned 1 exit status > make[1]: *** [qemu] Error 1 > make: *** [subdir-i386-softmmu] Error 2 > > > The following patch allowed it to compile, but I don't know enough about kvm to know if this is the proper thing to do. > > Chris > > > > Index: cfriesen/Download/qemu-kvm-0.15.0/console.h > =================================================================== > --- cfriesen.orig/Download/qemu-kvm-0.15.0/console.h > +++ cfriesen/Download/qemu-kvm-0.15.0/console.h > @@ -372,15 +372,18 @@ void cocoa_display_init(DisplayState *ds > void vnc_display_init(DisplayState *ds); > void vnc_display_close(DisplayState *ds); > int vnc_display_open(DisplayState *ds, const char *display); > -void vnc_display_add_client(DisplayState *ds, int csock, int skipauth); > int vnc_display_disable_login(DisplayState *ds); > char *vnc_display_local_addr(DisplayState *ds); > #ifdef CONFIG_VNC > +void vnc_display_add_client(DisplayState *ds, int csock, int skipauth); > int vnc_display_password(DisplayState *ds, const char *password); > int vnc_display_pw_expire(DisplayState *ds, time_t expires); > void do_info_vnc_print(Monitor *mon, const QObject *data); > void do_info_vnc(Monitor *mon, QObject **ret_data); > #else > +static inline void vnc_display_add_client(DisplayState *ds, int csock, int skipauth) > +{ > +} > static inline int vnc_display_password(DisplayState *ds, const char *password) > { > qerror_report(QERR_FEATURE_DISABLED, "vnc"); > > > c62f6d1d76aea587556c85b6b7b5c44167006264 and 860341f60582959698d2e1d839a5b7a004a2d76f need to be applied to stable-0.15 of upstream QEMU. Jan [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 262 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [BUG] error compiling qemu-kvm-0.15.0 without vnc @ 2011-08-31 7:40 ` Jan Kiszka 0 siblings, 0 replies; 16+ messages in thread From: Jan Kiszka @ 2011-08-31 7:40 UTC (permalink / raw) To: Chris Friesen; +Cc: mtosatti, Avi Kivity, kvm, qemu-devel [-- Attachment #1: Type: text/plain, Size: 2267 bytes --] On 2011-08-31 02:03, Chris Friesen wrote: > Hi, > > I've run into another problem. I configured qemu-kvm-0.15.0 as: > > ./configure --target-list="i386-softmmu,x86_64-softmmu" --disable-sdl --disable-vnc --disable-curses > > > Building it, I get: > > CC i386-softmmu/pcspk.o > CC i386-softmmu/i8254.o > CC i386-softmmu/i8254-kvm.o > CC i386-softmmu/device-assignment.o > LINK i386-softmmu/qemu > monitor.o: In function `add_graphics_client': > /home/cfriesen/Download/qemu-kvm-0.15.0/monitor.c:1226: undefined reference to `vnc_display_add_client' > collect2: ld returned 1 exit status > make[1]: *** [qemu] Error 1 > make: *** [subdir-i386-softmmu] Error 2 > > > The following patch allowed it to compile, but I don't know enough about kvm to know if this is the proper thing to do. > > Chris > > > > Index: cfriesen/Download/qemu-kvm-0.15.0/console.h > =================================================================== > --- cfriesen.orig/Download/qemu-kvm-0.15.0/console.h > +++ cfriesen/Download/qemu-kvm-0.15.0/console.h > @@ -372,15 +372,18 @@ void cocoa_display_init(DisplayState *ds > void vnc_display_init(DisplayState *ds); > void vnc_display_close(DisplayState *ds); > int vnc_display_open(DisplayState *ds, const char *display); > -void vnc_display_add_client(DisplayState *ds, int csock, int skipauth); > int vnc_display_disable_login(DisplayState *ds); > char *vnc_display_local_addr(DisplayState *ds); > #ifdef CONFIG_VNC > +void vnc_display_add_client(DisplayState *ds, int csock, int skipauth); > int vnc_display_password(DisplayState *ds, const char *password); > int vnc_display_pw_expire(DisplayState *ds, time_t expires); > void do_info_vnc_print(Monitor *mon, const QObject *data); > void do_info_vnc(Monitor *mon, QObject **ret_data); > #else > +static inline void vnc_display_add_client(DisplayState *ds, int csock, int skipauth) > +{ > +} > static inline int vnc_display_password(DisplayState *ds, const char *password) > { > qerror_report(QERR_FEATURE_DISABLED, "vnc"); > > > c62f6d1d76aea587556c85b6b7b5c44167006264 and 860341f60582959698d2e1d839a5b7a004a2d76f need to be applied to stable-0.15 of upstream QEMU. Jan [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 262 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [BUG] error compiling qemu-kvm-0.15.0 without vnc 2011-08-31 7:40 ` [Qemu-devel] " Jan Kiszka @ 2011-08-31 8:14 ` Kevin Wolf -1 siblings, 0 replies; 16+ messages in thread From: Kevin Wolf @ 2011-08-31 8:14 UTC (permalink / raw) To: Jan Kiszka Cc: kvm, Chris Friesen, mtosatti, Justin M. Forbes, qemu-devel, Avi Kivity Am 31.08.2011 09:40, schrieb Jan Kiszka: > On 2011-08-31 02:03, Chris Friesen wrote: >> Hi, >> >> I've run into another problem. I configured qemu-kvm-0.15.0 as: >> >> ./configure --target-list="i386-softmmu,x86_64-softmmu" --disable-sdl --disable-vnc --disable-curses >> >> >> Building it, I get: >> >> CC i386-softmmu/pcspk.o >> CC i386-softmmu/i8254.o >> CC i386-softmmu/i8254-kvm.o >> CC i386-softmmu/device-assignment.o >> LINK i386-softmmu/qemu >> monitor.o: In function `add_graphics_client': >> /home/cfriesen/Download/qemu-kvm-0.15.0/monitor.c:1226: undefined reference to `vnc_display_add_client' >> collect2: ld returned 1 exit status >> make[1]: *** [qemu] Error 1 >> make: *** [subdir-i386-softmmu] Error 2 >> >> >> The following patch allowed it to compile, but I don't know enough about kvm to know if this is the proper thing to do. >> >> Chris >> >> >> >> Index: cfriesen/Download/qemu-kvm-0.15.0/console.h >> =================================================================== >> --- cfriesen.orig/Download/qemu-kvm-0.15.0/console.h >> +++ cfriesen/Download/qemu-kvm-0.15.0/console.h >> @@ -372,15 +372,18 @@ void cocoa_display_init(DisplayState *ds >> void vnc_display_init(DisplayState *ds); >> void vnc_display_close(DisplayState *ds); >> int vnc_display_open(DisplayState *ds, const char *display); >> -void vnc_display_add_client(DisplayState *ds, int csock, int skipauth); >> int vnc_display_disable_login(DisplayState *ds); >> char *vnc_display_local_addr(DisplayState *ds); >> #ifdef CONFIG_VNC >> +void vnc_display_add_client(DisplayState *ds, int csock, int skipauth); >> int vnc_display_password(DisplayState *ds, const char *password); >> int vnc_display_pw_expire(DisplayState *ds, time_t expires); >> void do_info_vnc_print(Monitor *mon, const QObject *data); >> void do_info_vnc(Monitor *mon, QObject **ret_data); >> #else >> +static inline void vnc_display_add_client(DisplayState *ds, int csock, int skipauth) >> +{ >> +} >> static inline int vnc_display_password(DisplayState *ds, const char *password) >> { >> qerror_report(QERR_FEATURE_DISABLED, "vnc"); >> >> >> > > c62f6d1d76aea587556c85b6b7b5c44167006264 and > 860341f60582959698d2e1d839a5b7a004a2d76f need to be applied to > stable-0.15 of upstream QEMU. So I guess Justin should be CCed? Kevin ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [BUG] error compiling qemu-kvm-0.15.0 without vnc @ 2011-08-31 8:14 ` Kevin Wolf 0 siblings, 0 replies; 16+ messages in thread From: Kevin Wolf @ 2011-08-31 8:14 UTC (permalink / raw) To: Jan Kiszka Cc: kvm, Chris Friesen, mtosatti, Justin M. Forbes, qemu-devel, Avi Kivity Am 31.08.2011 09:40, schrieb Jan Kiszka: > On 2011-08-31 02:03, Chris Friesen wrote: >> Hi, >> >> I've run into another problem. I configured qemu-kvm-0.15.0 as: >> >> ./configure --target-list="i386-softmmu,x86_64-softmmu" --disable-sdl --disable-vnc --disable-curses >> >> >> Building it, I get: >> >> CC i386-softmmu/pcspk.o >> CC i386-softmmu/i8254.o >> CC i386-softmmu/i8254-kvm.o >> CC i386-softmmu/device-assignment.o >> LINK i386-softmmu/qemu >> monitor.o: In function `add_graphics_client': >> /home/cfriesen/Download/qemu-kvm-0.15.0/monitor.c:1226: undefined reference to `vnc_display_add_client' >> collect2: ld returned 1 exit status >> make[1]: *** [qemu] Error 1 >> make: *** [subdir-i386-softmmu] Error 2 >> >> >> The following patch allowed it to compile, but I don't know enough about kvm to know if this is the proper thing to do. >> >> Chris >> >> >> >> Index: cfriesen/Download/qemu-kvm-0.15.0/console.h >> =================================================================== >> --- cfriesen.orig/Download/qemu-kvm-0.15.0/console.h >> +++ cfriesen/Download/qemu-kvm-0.15.0/console.h >> @@ -372,15 +372,18 @@ void cocoa_display_init(DisplayState *ds >> void vnc_display_init(DisplayState *ds); >> void vnc_display_close(DisplayState *ds); >> int vnc_display_open(DisplayState *ds, const char *display); >> -void vnc_display_add_client(DisplayState *ds, int csock, int skipauth); >> int vnc_display_disable_login(DisplayState *ds); >> char *vnc_display_local_addr(DisplayState *ds); >> #ifdef CONFIG_VNC >> +void vnc_display_add_client(DisplayState *ds, int csock, int skipauth); >> int vnc_display_password(DisplayState *ds, const char *password); >> int vnc_display_pw_expire(DisplayState *ds, time_t expires); >> void do_info_vnc_print(Monitor *mon, const QObject *data); >> void do_info_vnc(Monitor *mon, QObject **ret_data); >> #else >> +static inline void vnc_display_add_client(DisplayState *ds, int csock, int skipauth) >> +{ >> +} >> static inline int vnc_display_password(DisplayState *ds, const char *password) >> { >> qerror_report(QERR_FEATURE_DISABLED, "vnc"); >> >> >> > > c62f6d1d76aea587556c85b6b7b5c44167006264 and > 860341f60582959698d2e1d839a5b7a004a2d76f need to be applied to > stable-0.15 of upstream QEMU. So I guess Justin should be CCed? Kevin ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [BUG] error compiling qemu-kvm-0.15.0 without vnc 2011-08-31 8:14 ` [Qemu-devel] " Kevin Wolf @ 2011-08-31 20:11 ` Justin M. Forbes -1 siblings, 0 replies; 16+ messages in thread From: Justin M. Forbes @ 2011-08-31 20:11 UTC (permalink / raw) To: Kevin Wolf Cc: Jan Kiszka, Chris Friesen, mtosatti, Avi Kivity, kvm, qemu-devel On Wed, 2011-08-31 at 10:14 +0200, Kevin Wolf wrote: > Am 31.08.2011 09:40, schrieb Jan Kiszka: > > On 2011-08-31 02:03, Chris Friesen wrote: > > c62f6d1d76aea587556c85b6b7b5c44167006264 and > > 860341f60582959698d2e1d839a5b7a004a2d76f need to be applied to > > stable-0.15 of upstream QEMU. > > So I guess Justin should be CCed? > > Kevin Thanks for the CC, and pulled. Justin ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [BUG] error compiling qemu-kvm-0.15.0 without vnc @ 2011-08-31 20:11 ` Justin M. Forbes 0 siblings, 0 replies; 16+ messages in thread From: Justin M. Forbes @ 2011-08-31 20:11 UTC (permalink / raw) To: Kevin Wolf Cc: kvm, Chris Friesen, mtosatti, qemu-devel, Jan Kiszka, Avi Kivity On Wed, 2011-08-31 at 10:14 +0200, Kevin Wolf wrote: > Am 31.08.2011 09:40, schrieb Jan Kiszka: > > On 2011-08-31 02:03, Chris Friesen wrote: > > c62f6d1d76aea587556c85b6b7b5c44167006264 and > > 860341f60582959698d2e1d839a5b7a004a2d76f need to be applied to > > stable-0.15 of upstream QEMU. > > So I guess Justin should be CCed? > > Kevin Thanks for the CC, and pulled. Justin ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2011-08-31 20:11 UTC | newest] Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2011-08-30 16:29 help? need to enable VT-d for 2.6.27 Chris Friesen 2011-08-30 17:55 ` David Ahern 2011-08-30 18:11 ` Chris Friesen 2011-08-30 18:31 ` David Ahern 2011-08-30 19:39 ` Chris Friesen 2011-08-30 19:54 ` David Ahern 2011-08-30 19:59 ` Jan Kiszka 2011-08-30 23:03 ` Chris Friesen 2011-08-31 7:30 ` Jan Kiszka 2011-08-31 0:03 ` [BUG] error compiling qemu-kvm-0.15.0 without vnc Chris Friesen 2011-08-31 7:40 ` Jan Kiszka 2011-08-31 7:40 ` [Qemu-devel] " Jan Kiszka 2011-08-31 8:14 ` Kevin Wolf 2011-08-31 8:14 ` [Qemu-devel] " Kevin Wolf 2011-08-31 20:11 ` Justin M. Forbes 2011-08-31 20:11 ` Justin M. Forbes
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.