From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
"Juha Riihimäki" <juha.riihimaki@nokia.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/2] omap_intc: Qdevify
Date: Thu, 01 Sep 2011 11:50:12 +0300 [thread overview]
Message-ID: <4E5F4744.1090809@redhat.com> (raw)
In-Reply-To: <1314806132-32389-3-git-send-email-peter.maydell@linaro.org>
On 08/31/2011 06:55 PM, Peter Maydell wrote:
> Convert the omap_intc devices to qdev. This includes adding
> a 'revision' property which will be needed for omap3.
>
> The bulk of this patch is the replacement of "s->irq[x][y]"
> with "qdev_get_gpio_in(s->ih[x], y)" now that the interrupt
> controller exposes its input lines as qdev gpio inputs.
>
> The devices are named "omap-intc" and "omap2-intc", following
> the filename and the OMAP2/3 hardware names, although some
> internal functions are still named "omap_inth_*".
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> hw/nseries.c | 4 +-
> hw/omap.h | 19 +--------
> hw/omap1.c | 127 +++++++++++++++++++++++++++++++++++--------------------
> hw/omap2.c | 92 ++++++++++++++++++++++++-----------------
> hw/omap_intc.c | 125 +++++++++++++++++++++++++++++++++---------------------
> 5 files changed, 215 insertions(+), 152 deletions(-)
>
This is likely to conflict with my omap1 patches in memory/queue.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-09-01 8:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 15:55 [Qemu-devel] [PATCH 0/2] omap_intc: convert to MemoryRegion, qdev Peter Maydell
2011-08-31 15:55 ` [Qemu-devel] [PATCH 1/2] omap_intc: Use MemoryRegion API Peter Maydell
2011-09-17 0:34 ` andrzej zaborowski
2011-08-31 15:55 ` [Qemu-devel] [PATCH 2/2] omap_intc: Qdevify Peter Maydell
2011-08-31 16:07 ` Peter Maydell
2011-09-01 8:50 ` Avi Kivity [this message]
2011-09-01 9:26 ` Peter Maydell
2011-09-09 16:48 ` [Qemu-devel] [PATCH 0/2] omap_intc: convert to MemoryRegion, qdev Peter Maydell
2011-09-16 13:05 ` Anthony Liguori
2011-09-16 14:32 ` Peter Maydell
2011-09-17 0:09 ` andrzej zaborowski
2011-09-16 23:19 ` Edgar E. Iglesias
2011-09-17 0:20 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5F4744.1090809@redhat.com \
--to=avi@redhat.com \
--cc=juha.riihimaki@nokia.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.