All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] net: fix warning not initializing MAC address
@ 2011-09-02  5:55 Heiko Schocher
  2011-09-02  6:44 ` Kumar Gala
  0 siblings, 1 reply; 3+ messages in thread
From: Heiko Schocher @ 2011-09-02  5:55 UTC (permalink / raw)
  To: u-boot

following warning message blobs up, when initializing for example
DaVinci EMAC:

Net:   Ethernet PHY: KSZ8873 @ 0x02
DaVinci-EMACWarning: failed to set MAC address

Introduced from commit

commit 7616e7850804c7c69e0a22c179dfcba9e8f3f587
Author: Simon Glass <sjg@chromium.org>
Date:   Mon Jun 13 16:13:10 2011 -0700

    Add Ethernet hardware MAC address framework to usbnet

    Built-in Ethernet adapters support setting the mac address by means of a
    ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr).

    This adds similar support to the USB network side, using the names
    usbethaddr, usbeth1addr, etc. They are kept separate since we don't want
    a USB device taking the MAC address of a built-in device or vice versa.

    Signed-off-by: Simon Glass <sjg@chromium.org>
    Tested-by: Eric B?nard <eric@eukrea.com>

Fix this!

Signed-off-by: Heiko Schocher <hs@denx.de>
cc: Simon Glass <sjg@chromium.org>
---
 net/eth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/eth.c b/net/eth.c
index a34fe59..2caaf60 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -296,7 +296,7 @@ int eth_initialize(bd_t *bis)
 			if (strchr(dev->name, ' '))
 				puts("\nWarning: eth device name has a space!\n");
 
-			if (eth_write_hwaddr(dev, NULL, eth_number))
+			if (eth_write_hwaddr(dev, "eth", eth_number))
 				puts("Warning: failed to set MAC address\n");
 
 			eth_number++;
-- 
1.7.6

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] net: fix warning not initializing MAC address
  2011-09-02  5:55 [U-Boot] [PATCH] net: fix warning not initializing MAC address Heiko Schocher
@ 2011-09-02  6:44 ` Kumar Gala
  2011-09-02  7:04   ` Heiko Schocher
  0 siblings, 1 reply; 3+ messages in thread
From: Kumar Gala @ 2011-09-02  6:44 UTC (permalink / raw)
  To: u-boot


On Sep 2, 2011, at 12:55 AM, Heiko Schocher wrote:

> following warning message blobs up, when initializing for example
> DaVinci EMAC:
> 
> Net:   Ethernet PHY: KSZ8873 @ 0x02
> DaVinci-EMACWarning: failed to set MAC address
> 
> Introduced from commit
> 
> commit 7616e7850804c7c69e0a22c179dfcba9e8f3f587
> Author: Simon Glass <sjg@chromium.org>
> Date:   Mon Jun 13 16:13:10 2011 -0700
> 
>    Add Ethernet hardware MAC address framework to usbnet
> 
>    Built-in Ethernet adapters support setting the mac address by means of a
>    ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr).
> 
>    This adds similar support to the USB network side, using the names
>    usbethaddr, usbeth1addr, etc. They are kept separate since we don't want
>    a USB device taking the MAC address of a built-in device or vice versa.
> 
>    Signed-off-by: Simon Glass <sjg@chromium.org>
>    Tested-by: Eric B?nard <eric@eukrea.com>
> 
> Fix this!
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> cc: Simon Glass <sjg@chromium.org>
> ---
> net/eth.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/eth.c b/net/eth.c
> index a34fe59..2caaf60 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -296,7 +296,7 @@ int eth_initialize(bd_t *bis)
> 			if (strchr(dev->name, ' '))
> 				puts("\nWarning: eth device name has a space!\n");
> 
> -			if (eth_write_hwaddr(dev, NULL, eth_number))
> +			if (eth_write_hwaddr(dev, "eth", eth_number))
> 				puts("Warning: failed to set MAC address\n");
> 
> 			eth_number++;
> -- 
> 1.7.6

We keep fixing this one ;)

http://patchwork.ozlabs.org/patch/112361/

- k

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] net: fix warning not initializing MAC address
  2011-09-02  6:44 ` Kumar Gala
@ 2011-09-02  7:04   ` Heiko Schocher
  0 siblings, 0 replies; 3+ messages in thread
From: Heiko Schocher @ 2011-09-02  7:04 UTC (permalink / raw)
  To: u-boot

Hello Kumar,

Kumar Gala wrote:
> On Sep 2, 2011, at 12:55 AM, Heiko Schocher wrote:
> 
>> following warning message blobs up, when initializing for example
>> DaVinci EMAC:
>>
>> Net:   Ethernet PHY: KSZ8873 @ 0x02
>> DaVinci-EMACWarning: failed to set MAC address
>>
>> Introduced from commit
>>
>> commit 7616e7850804c7c69e0a22c179dfcba9e8f3f587
>> Author: Simon Glass <sjg@chromium.org>
>> Date:   Mon Jun 13 16:13:10 2011 -0700
>>
>>    Add Ethernet hardware MAC address framework to usbnet
>>
>>    Built-in Ethernet adapters support setting the mac address by means of a
>>    ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr).
>>
>>    This adds similar support to the USB network side, using the names
>>    usbethaddr, usbeth1addr, etc. They are kept separate since we don't want
>>    a USB device taking the MAC address of a built-in device or vice versa.
>>
>>    Signed-off-by: Simon Glass <sjg@chromium.org>
>>    Tested-by: Eric B?nard <eric@eukrea.com>
>>
>> Fix this!
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> cc: Simon Glass <sjg@chromium.org>
>> ---
>> net/eth.c |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/eth.c b/net/eth.c
>> index a34fe59..2caaf60 100644
>> --- a/net/eth.c
>> +++ b/net/eth.c
>> @@ -296,7 +296,7 @@ int eth_initialize(bd_t *bis)
>> 			if (strchr(dev->name, ' '))
>> 				puts("\nWarning: eth device name has a space!\n");
>>
>> -			if (eth_write_hwaddr(dev, NULL, eth_number))
>> +			if (eth_write_hwaddr(dev, "eth", eth_number))
>> 				puts("Warning: failed to set MAC address\n");
>>
>> 			eth_number++;
>> -- 
>> 1.7.6
> 
> We keep fixing this one ;)
> 
> http://patchwork.ozlabs.org/patch/112361/

Good!
(Sorry for posting another fix, but just back from vacation, and
didn;t found time for looking in the u-boot ml ... :-(

Thanks for the hint!
bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-02  7:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-02  5:55 [U-Boot] [PATCH] net: fix warning not initializing MAC address Heiko Schocher
2011-09-02  6:44 ` Kumar Gala
2011-09-02  7:04   ` Heiko Schocher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.