From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] pseries: Implement hcall-bulk hypervisor interface
Date: Fri, 02 Sep 2011 15:26:27 +0200 [thread overview]
Message-ID: <4E60D983.60808@suse.de> (raw)
In-Reply-To: <20110901015050.GI11906@yookeroo.fritz.box>
On 09/01/2011 03:50 AM, David Gibson wrote:
> On Wed, Aug 31, 2011 at 11:22:18AM +0200, Alexander Graf wrote:
>> On 11.08.2011, at 04:36, David Gibson wrote:
> [snip]
>>> +#define H_BULK_REMOVE_TYPE 0xc000000000000000ULL
>>> +#define H_BULK_REMOVE_REQUEST 0x4000000000000000ULL
>>> +#define H_BULK_REMOVE_RESPONSE 0x8000000000000000ULL
>>> +#define H_BULK_REMOVE_END 0xc000000000000000ULL
>>> +#define H_BULK_REMOVE_CODE 0x3000000000000000ULL
>>> +#define H_BULK_REMOVE_SUCCESS 0x0000000000000000ULL
>>> +#define H_BULK_REMOVE_NOT_FOUND 0x1000000000000000ULL
>>> +#define H_BULK_REMOVE_PARM 0x2000000000000000ULL
>>> +#define H_BULK_REMOVE_HW 0x3000000000000000ULL
>>> +#define H_BULK_REMOVE_RC 0x0c00000000000000ULL
>>> +#define H_BULK_REMOVE_FLAGS 0x0300000000000000ULL
>>> +#define H_BULK_REMOVE_ABSOLUTE 0x0000000000000000ULL
>>> +#define H_BULK_REMOVE_ANDCOND 0x0100000000000000ULL
>>> +#define H_BULK_REMOVE_AVPN 0x0200000000000000ULL
>>> +#define H_BULK_REMOVE_PTEX 0x00ffffffffffffffULL
>> indenting looks broken.
> Nope, that's intended. The unindented ones are the field masks in the
> parameter, the intended ones are the defined values for the
> corresponding field.
Interesting :). Makes sense now that you explain it - looked awkward at
first.
>>> +
>>> +static target_ulong h_bulk_remove(CPUState *env, sPAPREnvironment *spapr,
>>> + target_ulong opcode, target_ulong *args)
>>> +{
>>> + int i;
>>> +
>>> + for (i = 0; i< 4; i++) {
>>> + target_ulong *tsh =&args[i*2];
>>> + target_ulong tsl = args[i*2 + 1];
>> Mind to replace all those magic numbers by something more verbose?
> So, "all those" == 2. I can replace the 4 with something I guess, but
> changing the 2 would just be silly - that code is just taking the
> arguments a pair at a time.
Yup. Thanks! Applied.
Alex
prev parent reply other threads:[~2011-09-02 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 2:36 [Qemu-devel] [0/2] pseries: Further updates David Gibson
2011-08-11 2:36 ` [Qemu-devel] [PATCH 1/2] pseries: use macro for firmware filename David Gibson
2011-08-31 9:18 ` Alexander Graf
2011-08-11 2:36 ` [Qemu-devel] [PATCH 2/2] pseries: Implement hcall-bulk hypervisor interface David Gibson
2011-08-31 9:22 ` Alexander Graf
2011-09-01 1:50 ` David Gibson
2011-09-02 13:26 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E60D983.60808@suse.de \
--to=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.