From: Wang Sheng-Hui <shhuiw@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] elevator.c: use ELV_NAME_MAX instead of magic number 16 for chosen_elevator
Date: Thu, 08 Sep 2011 12:23:13 +0800 [thread overview]
Message-ID: <4E684331.501@gmail.com> (raw)
In-Reply-To: <4E637BA8.6030300@gmail.com>
On 2011年09月04日 21:22, Wang Sheng-Hui wrote:
> We have ELV_NAME_MAX defined to 16, and hence we should use it
> instead of the magic nubmer 16 for elevator's name string.
>
> The patch is against 3.1-rc3.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
> block/elevator.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/elevator.c b/block/elevator.c
> index a3b64bc..cb332cb 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -182,7 +182,7 @@ static void elevator_attach(struct request_queue *q, struct elevator_queue *eq,
> eq->elevator_data = data;
> }
>
> -static char chosen_elevator[16];
> +static char chosen_elevator[ELV_NAME_MAX];
>
> static int __init elevator_setup(char *str)
> {
Any comment?
next prev parent reply other threads:[~2011-09-08 4:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-04 13:22 [PATCH] elevator.c: use ELV_NAME_MAX instead of magic number 16 for chosen_elevator Wang Sheng-Hui
2011-09-08 4:23 ` Wang Sheng-Hui [this message]
2011-09-08 10:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E684331.501@gmail.com \
--to=shhuiw@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.