All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] memory: simple memory tree printer
Date: Mon, 12 Sep 2011 13:53:35 +0300	[thread overview]
Message-ID: <4E6DE4AF.1050604@redhat.com> (raw)
In-Reply-To: <4E6DE104.1090204@redhat.com>

On 09/12/2011 01:37 PM, Gerd Hoffmann wrote:
>> I/O
>> io addr 0000000000000000 off 0000000000000000 size 10000
>> -e1000-io addr 000000000000c000 off 0000000000000000 size 40
>> -piix-bmdma-container addr 000000000000c040 off 0000000000000000 size 10
>> --bmdma addr 000000000000000c off 0000000000000000 size 4
>> --piix-bmdma addr 0000000000000008 off 0000000000000000 size 4
>> --bmdma addr 0000000000000004 off 0000000000000000 size 4
>> --piix-bmdma addr 0000000000000000 off 0000000000000000 size 4
>> -pci-conf-data addr 0000000000000cfc off 0000000000000000 size 4
>> -pci-conf-idx addr 0000000000000cf8 off 0000000000000000 size 4
>
> Could you put the (variable-length) name field last?  That should make 
> the whole list more readable as the addresses are aligned then.
>

Makes sense.  Can adopt other features from /proc/iomem - like using 
start/end instead of start/length - makes it easier to see if an address 
fits in a range.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2011-09-12 10:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-11 20:31 [Qemu-devel] [PATCH] memory: simple memory tree printer Blue Swirl
2011-09-12  6:43 ` Richard Henderson
2011-09-12  9:01   ` Jan Kiszka
2011-09-12  9:11     ` Avi Kivity
2011-09-12  9:19       ` Jan Kiszka
2011-09-14 15:10         ` Richard Henderson
2011-09-14 15:23           ` Avi Kivity
2011-09-14 15:27             ` Richard Henderson
2011-09-14 15:29               ` Avi Kivity
2011-09-14 15:36                 ` Richard Henderson
2011-09-14 15:46                   ` Avi Kivity
2011-09-14 17:58           ` Jan Kiszka
2011-09-14 18:10             ` Jan Kiszka
2011-09-14 19:24               ` Avi Kivity
2011-09-15  9:30                 ` Jan Kiszka
2011-09-15  9:53                   ` Avi Kivity
2011-09-15 10:18                     ` Jan Kiszka
2011-09-15 11:21                       ` Avi Kivity
2011-09-14 18:26             ` Richard Henderson
2011-09-12  7:00 ` Peter Maydell
2011-09-12  8:46 ` Avi Kivity
2011-09-12  8:53   ` Jan Kiszka
2011-09-12  9:12     ` Avi Kivity
2011-09-12 10:37 ` Gerd Hoffmann
2011-09-12 10:53   ` Avi Kivity [this message]
2011-09-12 20:07     ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E6DE4AF.1050604@redhat.com \
    --to=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.