All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] memory: simple memory tree printer
Date: Wed, 14 Sep 2011 08:27:32 -0700	[thread overview]
Message-ID: <4E70C7E4.8070009@twiddle.net> (raw)
In-Reply-To: <4E70C703.5000602@redhat.com>

On 09/14/2011 08:23 AM, Avi Kivity wrote:
> On 09/14/2011 06:10 PM, Richard Henderson wrote:
>> >
>> >  So the default address passed to the handler is now already relative? I
>> >  think we should keep it like this for all converted devices, ie. take
>> >  the chance, fix the remaining models, and drop the offset.
>>
>> It's non-zero for the isa portio conversion that I did, which
>> I thought was in Avi's tree.
> 
> That's MemoryRegionPortio::offset, not MemoryRegion::offset.

No, look in isa_register_portio_list:

        memory_region_init_io(region, ops, opaque, name, off_high - off_low);
        memory_region_set_offset(region, start + off_low);

That last line sets MemoryRegion::offset.


r~

  reply	other threads:[~2011-09-14 15:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-11 20:31 [Qemu-devel] [PATCH] memory: simple memory tree printer Blue Swirl
2011-09-12  6:43 ` Richard Henderson
2011-09-12  9:01   ` Jan Kiszka
2011-09-12  9:11     ` Avi Kivity
2011-09-12  9:19       ` Jan Kiszka
2011-09-14 15:10         ` Richard Henderson
2011-09-14 15:23           ` Avi Kivity
2011-09-14 15:27             ` Richard Henderson [this message]
2011-09-14 15:29               ` Avi Kivity
2011-09-14 15:36                 ` Richard Henderson
2011-09-14 15:46                   ` Avi Kivity
2011-09-14 17:58           ` Jan Kiszka
2011-09-14 18:10             ` Jan Kiszka
2011-09-14 19:24               ` Avi Kivity
2011-09-15  9:30                 ` Jan Kiszka
2011-09-15  9:53                   ` Avi Kivity
2011-09-15 10:18                     ` Jan Kiszka
2011-09-15 11:21                       ` Avi Kivity
2011-09-14 18:26             ` Richard Henderson
2011-09-12  7:00 ` Peter Maydell
2011-09-12  8:46 ` Avi Kivity
2011-09-12  8:53   ` Jan Kiszka
2011-09-12  9:12     ` Avi Kivity
2011-09-12 10:37 ` Gerd Hoffmann
2011-09-12 10:53   ` Avi Kivity
2011-09-12 20:07     ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E70C7E4.8070009@twiddle.net \
    --to=rth@twiddle.net \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.