[PATCH] ALSA ymfpci - Add "Playback" to FM Legacy Volume control

[PATCH] ALSA ymfpci - Add "Playback" to FM Legacy Volume control

[Raymond Yau]

[-- Attachment #1: Type: text/plain, Size: 121 bytes --]

Add "Playback" to "FM Legacy Volume" control since

- YDSXGR_LEGACYOUTVOL is a Playback Volume control for OPL3 FM Synth

[-- Attachment #2: 0001-ALSA-ymfpci-Add-Playback-to-FM-Legacy-Volume-cont.patch --]
[-- Type: application/octet-stream, Size: 1205 bytes --]

From a523ebef71b0a0a6e4bc2e07ffd616e8c6510717 Mon Sep 17 00:00:00 2001
From: Raymond Yau <superquad.vortex2@gmail.com>
Date: Fri, 9 Sep 2011 19:15:01 +0800
Subject: [PATCH] ALSA ymfpci - Add "Playback" to FM Legacy Volume control

YDSXGR_LEGACYOUTVOL is a Playback Volume control for OPL3 FM Synth

Signed-off-by: Raymond Yau <superquad.vortex2@gmail.com>

diff --git a/sound/pci/ymfpci/ymfpci_main.c b/sound/pci/ymfpci/ymfpci_main.c
index f3260e6..ebfbb28 100644
--- a/sound/pci/ymfpci/ymfpci_main.c
+++ b/sound/pci/ymfpci/ymfpci_main.c
@@ -1615,7 +1615,7 @@ YMFPCI_DOUBLE("ADC Playback Volume", 0, YDSXGR_PRIADCOUTVOL),
 YMFPCI_DOUBLE("ADC Capture Volume", 0, YDSXGR_PRIADCLOOPVOL),
 YMFPCI_DOUBLE("ADC Playback Volume", 1, YDSXGR_SECADCOUTVOL),
 YMFPCI_DOUBLE("ADC Capture Volume", 1, YDSXGR_SECADCLOOPVOL),
-YMFPCI_DOUBLE("FM Legacy Volume", 0, YDSXGR_LEGACYOUTVOL),
+YMFPCI_DOUBLE("FM Legacy Playback Volume", 0, YDSXGR_LEGACYOUTVOL),
 YMFPCI_DOUBLE(SNDRV_CTL_NAME_IEC958("AC97 ", PLAYBACK,VOLUME), 0, YDSXGR_ZVOUTVOL),
 YMFPCI_DOUBLE(SNDRV_CTL_NAME_IEC958("", CAPTURE,VOLUME), 0, YDSXGR_ZVLOOPVOL),
 YMFPCI_DOUBLE(SNDRV_CTL_NAME_IEC958("AC97 ",PLAYBACK,VOLUME), 1, YDSXGR_SPDIFOUTVOL),
-- 
1.6.0.6


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ALSA ymfpci - Add "Playback" to FM Legacy Volume control

[Clemens Ladisch]

Raymond Yau wrote:
> Add "Playback" to "FM Legacy Volume" control since
>
> - YDSXGR_LEGACYOUTVOL is a Playback Volume control for OPL3 FM Synth

Applied; thanks!


Clemens

Re: [PATCH] ALSA ymfpci - Add "Playback" to FM Legacy Volume control

[Raymond Yau]

2011/9/11 Clemens Ladisch <clemens@ladisch.de>:
> Raymond Yau wrote:
>> Add "Playback" to "FM Legacy Volume" control since
>>
>> - YDSXGR_LEGACYOUTVOL is a Playback Volume control for OPL3 FM Synth
>
> Applied; thanks!
>
>
> Clemens
>

How accurate is the ymfpci timer ?

my ymf724f seem play quite well with alsa "hw" device but with bad
noise with alsa-pulse plugin (e.g. aplay when not using default period
times )  and it also occurrs on   benshee on ubuntu 11.4 live cd

Does the driver really need periods_min =3 ?

it there any test case which it does not work with 2 periods

changing  default sample rate of PA server from 44100 to 48000 in
daemon.conf does not help to remove the noise

Re: [PATCH] ALSA ymfpci - Add "Playback" to FM Legacy Volume control

[Clemens Ladisch]

Raymond Yau wrote:
> How accurate is the ymfpci timer ?

The period interrupts are not accurate at all.  The ymfpci hardware
internally uses fixed periods of 256 frames at 48 kHz; the driver
reports a period interrupt when the next hardware interrupt at or after
a period boundary occurs.  The current position reported by the hardware
is the position at the time of the last hardware interrupt.

> my ymf724f seem play quite well with alsa "hw" device but with bad
> noise with alsa-pulse plugin (e.g. aplay when not using default period
> times )  and it also occurrs on   benshee on ubuntu 11.4 live cd

It should be possible to increase accuracy by using the hardware period
parameters (48 kHz _and_ 256 frames/period).

TODO: implement support for the NORESAMPLE flag.


Regards,
Clemens