Re: Re: [PATCH] xen: change XEN_PLATFORM_PCI to bool default y

[Jeremy Fitzhardinge <jeremy@goop.org>]

On 09/21/2011 12:08 PM, Ian Campbell wrote:
> On Wed, 2011-09-21 at 19:51 +0100, Konrad Rzeszutek Wilk wrote:
>> On Wed, Sep 21, 2011 at 01:37:50PM +0100, stefano.stabellini@eu.citrix.com wrote:
>>> From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>>
>>> The xen-platform-pci module is small and for PV on HVM guests is a
>> How small?
> IIRC it is single digit numbers of kb.

lsmod shows it's about 2.5k.

>>  Does it get removed from memory if it never gets loaded?

Nope.

>>> requirement for xenbus.
>> Ok, should it then have a depency on XenBus as well?
> xenbus can't be a module (which is why allowing platform-pci to be is
> causing problems).
>
>> Linus does not like the 'default y' very much. He actually dislikes
>> it quite much as I found when he tore Dan's behind about cleancache.
> In particular case the option is gated on a dependency on another Xen
> option (PVHVM) which doesn't default on. But if you do select PVHVM you
> certainly want this option, so I think that's ok (why else would
> 'default y' even exist?)

It was default 'm' before, so making it 'y' is just the logical mapping
of tristate->bool.

>> .. so I think making it 'default n' is a better option or perhaps
>> making it depend on some other functionality? Or perhaps just remove
>> the tristate/bool altogether so it gets activated if XEN_PVHVM
>> is set?
>>
>> Or remove the XEN_PLATFORM_PCI config option completly and make the
>> config files that build this driver be CONFIG_XENPVHM dependent?
> That would work too. Even better would be to make it an invisible
> Kconfig symbol which PVHVM just selects.

Eh, select is pretty nasty.

    J