From: "Jan Beulich" <JBeulich@suse.com>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>,
Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: Re: [PATCH] xen: change XEN_PLATFORM_PCI to bool default y
Date: Fri, 23 Sep 2011 07:56:04 +0100 [thread overview]
Message-ID: <4E7C49A402000078000577A6@nat28.tlf.novell.com> (raw)
In-Reply-To: <4E7B8DE8.1070809@goop.org>
>>> On 22.09.11 at 21:35, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> On 09/21/2011 11:21 PM, Ian Campbell wrote:
>> On Wed, 2011-09-21 at 23:49 +0100, Jeremy Fitzhardinge wrote:
>>>> That would work too. Even better would be to make it an invisible
>>>> Kconfig symbol which PVHVM just selects.
>>> Eh, select is pretty nasty.
>> Select of a non user visible symbol is perfectly fine. It's only when
>> you select something a user can also set that things get nasty.
>
> It doesn't matter if its user-visible. If the selected symbol acquires
> other dependencies, the selection won't set them.
Despite there being numerous contrary examples in the tree: Either one
wants a select-only symbol (then putting dependencies on it is wrong) or
one wants an automatic symbol (then selecting it is very likely wrong).
Which all boils down to the bogus mixing of normal (forward) and reverse
dependencies (using the kconfig source/doc wording).
Jan
next prev parent reply other threads:[~2011-09-23 6:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 12:37 [PATCH] xen: change XEN_PLATFORM_PCI to bool default y stefano.stabellini
2011-09-21 18:51 ` Konrad Rzeszutek Wilk
2011-09-21 19:08 ` Ian Campbell
2011-09-21 21:10 ` Konrad Rzeszutek Wilk
2011-09-22 11:23 ` Stefano Stabellini
2011-09-21 22:49 ` Jeremy Fitzhardinge
2011-09-22 6:21 ` Ian Campbell
2011-09-22 19:35 ` Jeremy Fitzhardinge
2011-09-23 6:56 ` Jan Beulich [this message]
2011-09-22 6:18 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7C49A402000078000577A6@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.