* [PATCH] insane: Promote most warnings into QA errors by default
@ 2011-09-26 20:24 Richard Purdie
2011-09-26 21:51 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2011-09-26 20:24 UTC (permalink / raw)
To: openembedded-core
We agreed a while back that we'd start ERRORing on QA issues, not just
WARNING about them. This patch changes the default QA levels to error
on everything except ldflag and useless rpath issues.
It also stops giving out QA warnings about desktop files since it
adds noise to the build and until someone plans to seriously tackle
that problem, its pointless.
We can promote the ldflag and rpath warnings too, when the issues
in OE-Core are resolved (they're mostly there now, jsut a few more
to go).
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index addb9ac..62935c3 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -99,9 +99,9 @@ def package_qa_get_machine_dict():
}
-WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths"
-ERROR_QA ?= ""
-#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms"
+# Currently not being used by default "desktop"
+WARN_QA ?= "ldflags useless-rpaths"
+ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
def package_qa_clean_path(path,d):
""" Remove the common prefix from the path. In this case it is the TMPDIR"""
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] insane: Promote most warnings into QA errors by default
2011-09-26 20:24 [PATCH] insane: Promote most warnings into QA errors by default Richard Purdie
@ 2011-09-26 21:51 ` Richard Purdie
2011-09-26 23:08 ` Saul Wold
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2011-09-26 21:51 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Mon, 2011-09-26 at 21:24 +0100, Richard Purdie wrote:
> We agreed a while back that we'd start ERRORing on QA issues, not just
> WARNING about them. This patch changes the default QA levels to error
> on everything except ldflag and useless rpath issues.
>
> It also stops giving out QA warnings about desktop files since it
> adds noise to the build and until someone plans to seriously tackle
> that problem, its pointless.
>
> We can promote the ldflag and rpath warnings too, when the issues
> in OE-Core are resolved (they're mostly there now, jsut a few more
> to go).
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index addb9ac..62935c3 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -99,9 +99,9 @@ def package_qa_get_machine_dict():
> }
>
>
> -WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths"
> -ERROR_QA ?= ""
> -#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms"
> +# Currently not being used by default "desktop"
> +WARN_QA ?= "ldflags useless-rpaths"
> +ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
>
Further testing shows we may not be ready to move rpath to ERROR_QA
quite yet but the rest of the proposal still stands...
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] insane: Promote most warnings into QA errors by default
2011-09-26 21:51 ` Richard Purdie
@ 2011-09-26 23:08 ` Saul Wold
2011-09-27 10:02 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Saul Wold @ 2011-09-26 23:08 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 09/26/2011 02:51 PM, Richard Purdie wrote:
> On Mon, 2011-09-26 at 21:24 +0100, Richard Purdie wrote:
>> We agreed a while back that we'd start ERRORing on QA issues, not just
>> WARNING about them. This patch changes the default QA levels to error
>> on everything except ldflag and useless rpath issues.
>>
>> It also stops giving out QA warnings about desktop files since it
>> adds noise to the build and until someone plans to seriously tackle
>> that problem, its pointless.
>>
>> We can promote the ldflag and rpath warnings too, when the issues
>> in OE-Core are resolved (they're mostly there now, jsut a few more
>> to go).
>>
>> Signed-off-by: Richard Purdie<richard.purdie@linuxfoundation.org>
>> ---
>> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
>> index addb9ac..62935c3 100644
>> --- a/meta/classes/insane.bbclass
>> +++ b/meta/classes/insane.bbclass
>> @@ -99,9 +99,9 @@ def package_qa_get_machine_dict():
>> }
>>
>>
>> -WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths"
>> -ERROR_QA ?= ""
>> -#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms"
>> +# Currently not being used by default "desktop"
>> +WARN_QA ?= "ldflags useless-rpaths"
>> +ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
>>
>
> Further testing shows we may not be ready to move rpath to ERROR_QA
> quite yet but the rest of the proposal still stands...
>
How bad is the breakage in a world build?
I will probably attempt this later or tomorrow.
Sau!
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] insane: Promote most warnings into QA errors by default
2011-09-26 23:08 ` Saul Wold
@ 2011-09-27 10:02 ` Richard Purdie
0 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2011-09-27 10:02 UTC (permalink / raw)
To: Saul Wold; +Cc: Patches and discussions about the oe-core layer
On Mon, 2011-09-26 at 16:08 -0700, Saul Wold wrote:
> On 09/26/2011 02:51 PM, Richard Purdie wrote:
> > On Mon, 2011-09-26 at 21:24 +0100, Richard Purdie wrote:
> >> We agreed a while back that we'd start ERRORing on QA issues, not just
> >> WARNING about them. This patch changes the default QA levels to error
> >> on everything except ldflag and useless rpath issues.
> >>
> >> It also stops giving out QA warnings about desktop files since it
> >> adds noise to the build and until someone plans to seriously tackle
> >> that problem, its pointless.
> >>
> >> We can promote the ldflag and rpath warnings too, when the issues
> >> in OE-Core are resolved (they're mostly there now, jsut a few more
> >> to go).
> >>
> >> Signed-off-by: Richard Purdie<richard.purdie@linuxfoundation.org>
> >> ---
> >> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> >> index addb9ac..62935c3 100644
> >> --- a/meta/classes/insane.bbclass
> >> +++ b/meta/classes/insane.bbclass
> >> @@ -99,9 +99,9 @@ def package_qa_get_machine_dict():
> >> }
> >>
> >>
> >> -WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths"
> >> -ERROR_QA ?= ""
> >> -#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms"
> >> +# Currently not being used by default "desktop"
> >> +WARN_QA ?= "ldflags useless-rpaths"
> >> +ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
> >>
> >
> > Further testing shows we may not be ready to move rpath to ERROR_QA
> > quite yet but the rest of the proposal still stands...
> >
> How bad is the breakage in a world build?
>
> I will probably attempt this later or tomorrow.
I tested world on qemux86 and qemuarm and fixed all the issues the above
change would error on ignoring rpath/ldflags/desktop. The list of issues
I posted earlier was against world for the other pieces, again ignoring
desktop.
So we shouldn't be too bad, otherwise I wouldn't be proposing this :)
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-27 10:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-26 20:24 [PATCH] insane: Promote most warnings into QA errors by default Richard Purdie
2011-09-26 21:51 ` Richard Purdie
2011-09-26 23:08 ` Saul Wold
2011-09-27 10:02 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.