* [Qemu-devel] [PATCH] target-i386: Remove redundant word mask in port out instructions
@ 2011-09-26 17:20 Jan Kiszka
2011-09-27 15:20 ` Richard Henderson
2011-10-01 12:05 ` Blue Swirl
0 siblings, 2 replies; 3+ messages in thread
From: Jan Kiszka @ 2011-09-26 17:20 UTC (permalink / raw)
To: qemu-devel; +Cc: Blue Swirl, Aurelien Jarno, Richard Henderson
T0 was already masked to 16 bits when loading it.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
target-i386/translate.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index b894e97..1ef8d16 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -6116,7 +6116,6 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start)
if (use_icount)
gen_io_start();
tcg_gen_trunc_tl_i32(cpu_tmp2_i32, cpu_T[0]);
- tcg_gen_andi_i32(cpu_tmp2_i32, cpu_tmp2_i32, 0xffff);
tcg_gen_trunc_tl_i32(cpu_tmp3_i32, cpu_T[1]);
gen_helper_out_func(ot, cpu_tmp2_i32, cpu_tmp3_i32);
if (use_icount) {
@@ -6159,7 +6158,6 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start)
if (use_icount)
gen_io_start();
tcg_gen_trunc_tl_i32(cpu_tmp2_i32, cpu_T[0]);
- tcg_gen_andi_i32(cpu_tmp2_i32, cpu_tmp2_i32, 0xffff);
tcg_gen_trunc_tl_i32(cpu_tmp3_i32, cpu_T[1]);
gen_helper_out_func(ot, cpu_tmp2_i32, cpu_tmp3_i32);
if (use_icount) {
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target-i386: Remove redundant word mask in port out instructions
2011-09-26 17:20 [Qemu-devel] [PATCH] target-i386: Remove redundant word mask in port out instructions Jan Kiszka
@ 2011-09-27 15:20 ` Richard Henderson
2011-10-01 12:05 ` Blue Swirl
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2011-09-27 15:20 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Blue Swirl, qemu-devel, Aurelien Jarno
On 09/26/2011 10:20 AM, Jan Kiszka wrote:
> T0 was already masked to 16 bits when loading it.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target-i386: Remove redundant word mask in port out instructions
2011-09-26 17:20 [Qemu-devel] [PATCH] target-i386: Remove redundant word mask in port out instructions Jan Kiszka
2011-09-27 15:20 ` Richard Henderson
@ 2011-10-01 12:05 ` Blue Swirl
1 sibling, 0 replies; 3+ messages in thread
From: Blue Swirl @ 2011-10-01 12:05 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel, Aurelien Jarno, Richard Henderson
Thanks, applied.
On Mon, Sep 26, 2011 at 5:20 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> T0 was already masked to 16 bits when loading it.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> target-i386/translate.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index b894e97..1ef8d16 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -6116,7 +6116,6 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start)
> if (use_icount)
> gen_io_start();
> tcg_gen_trunc_tl_i32(cpu_tmp2_i32, cpu_T[0]);
> - tcg_gen_andi_i32(cpu_tmp2_i32, cpu_tmp2_i32, 0xffff);
> tcg_gen_trunc_tl_i32(cpu_tmp3_i32, cpu_T[1]);
> gen_helper_out_func(ot, cpu_tmp2_i32, cpu_tmp3_i32);
> if (use_icount) {
> @@ -6159,7 +6158,6 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start)
> if (use_icount)
> gen_io_start();
> tcg_gen_trunc_tl_i32(cpu_tmp2_i32, cpu_T[0]);
> - tcg_gen_andi_i32(cpu_tmp2_i32, cpu_tmp2_i32, 0xffff);
> tcg_gen_trunc_tl_i32(cpu_tmp3_i32, cpu_T[1]);
> gen_helper_out_func(ot, cpu_tmp2_i32, cpu_tmp3_i32);
> if (use_icount) {
> --
> 1.7.3.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-01 12:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-26 17:20 [Qemu-devel] [PATCH] target-i386: Remove redundant word mask in port out instructions Jan Kiszka
2011-09-27 15:20 ` Richard Henderson
2011-10-01 12:05 ` Blue Swirl
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.