All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] opensm/osm_dump.c: Fix FDR10 speed dumping
@ 2011-09-28 12:50 Hal Rosenstock
       [not found] ` <4E831829.4000106-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Hal Rosenstock @ 2011-09-28 12:50 UTC (permalink / raw)
  To: Alex Netes
  Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
	Daniel Klein


In dump_topology_node, FDR10 can be active regardless of whether
PortInfo:CapabilityMask.IsExtendedSpeeds is set or not

Prior to this, FDR10 was only indicated if IsExtendedSpeeds was not set

Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/opensm/osm_dump.c b/opensm/osm_dump.c
index 7e58301..8aa8095 100644
--- a/opensm/osm_dump.c
+++ b/opensm/osm_dump.c
@@ -454,6 +454,9 @@ static void dump_topology_node(cl_map_item_t * item, FILE * file, void *cxt)
 		else
 			link_speed_act_str = "??";
 
+		if (p_physp->ext_port_info.link_speed_active & FDR10)
+			link_speed_act_str = "FDR10";
+
 		if (p_default_physp->port_info.capability_mask & IB_PORT_CAP_HAS_EXT_SPEEDS) {
 			link_speed_act =
 			    ib_port_info_get_link_speed_ext_active(&p_physp->port_info);
@@ -463,8 +466,7 @@ static void dump_topology_node(cl_map_item_t * item, FILE * file, void *cxt)
 				link_speed_act_str = "25";
 			else if (link_speed_act != IB_LINK_SPEED_EXT_ACTIVE_NONE)
 				link_speed_act_str = "??";
-		} else if (p_physp->ext_port_info.link_speed_active & FDR10)
-			link_speed_act_str = "FDR10";
+		}
 
 		fprintf(file, "PHY=%s LOG=%s SPD=%s\n",
 			p_physp->port_info.link_width_active == 1 ? "1x" :
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] opensm/osm_dump.c: Fix FDR10 speed dumping
       [not found] ` <4E831829.4000106-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2011-11-01 16:29   ` Alex Netes
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Netes @ 2011-11-01 16:29 UTC (permalink / raw)
  To: Hal Rosenstock
  Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
	Daniel Klein

Hi Hal,

On 08:50 Wed 28 Sep     , Hal Rosenstock wrote:
> 
> In dump_topology_node, FDR10 can be active regardless of whether
> PortInfo:CapabilityMask.IsExtendedSpeeds is set or not
> 
> Prior to this, FDR10 was only indicated if IsExtendedSpeeds was not set
> 
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-01 16:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-28 12:50 [PATCH] opensm/osm_dump.c: Fix FDR10 speed dumping Hal Rosenstock
     [not found] ` <4E831829.4000106-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2011-11-01 16:29   ` Alex Netes

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.