* [PATCH] e2fsprogs: Fix thinko in ext2fs_initialize bigalloc case
@ 2011-10-03 22:01 Eric Sandeen
2011-10-04 3:24 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2011-10-03 22:01 UTC (permalink / raw)
To: ext4 development
Surely we should be setting s_clusters_per_group, not
s_blocks_per_group, to EXT2_MAX_CLUSTERS_PER_GROUP here.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/lib/ext2fs/initialize.c b/lib/ext2fs/initialize.c
index 47f0b1c..2875f97 100644
--- a/lib/ext2fs/initialize.c
+++ b/lib/ext2fs/initialize.c
@@ -218,7 +218,7 @@ errcode_t ext2fs_initialize(const char *name, int flags,
else
super->s_clusters_per_group = fs->blocksize * 8;
if (super->s_clusters_per_group > EXT2_MAX_CLUSTERS_PER_GROUP(super))
- super->s_blocks_per_group = EXT2_MAX_CLUSTERS_PER_GROUP(super);
+ super->s_clusters_per_group = EXT2_MAX_CLUSTERS_PER_GROUP(super);
super->s_blocks_per_group = EXT2FS_C2B(fs,
super->s_clusters_per_group);
} else {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] e2fsprogs: Fix thinko in ext2fs_initialize bigalloc case
2011-10-03 22:01 [PATCH] e2fsprogs: Fix thinko in ext2fs_initialize bigalloc case Eric Sandeen
@ 2011-10-04 3:24 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2011-10-04 3:24 UTC (permalink / raw)
To: Eric Sandeen; +Cc: ext4 development
On Mon, Oct 03, 2011 at 05:01:18PM -0500, Eric Sandeen wrote:
> Surely we should be setting s_clusters_per_group, not
> s_blocks_per_group, to EXT2_MAX_CLUSTERS_PER_GROUP here.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Yes, oops. Good catch, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-04 3:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-03 22:01 [PATCH] e2fsprogs: Fix thinko in ext2fs_initialize bigalloc case Eric Sandeen
2011-10-04 3:24 ` Ted Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.