From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation
Date: Mon, 10 Oct 2011 15:55:56 -0500 [thread overview]
Message-ID: <4E935BDC.7000109@freescale.com> (raw)
In-Reply-To: <20111010203846.175291408753@gemini.denx.de>
On 10/10/2011 03:38 PM, Wolfgang Denk wrote:
> Dear Scott Wood,
>
> In message <4E934EF5.9030302@freescale.com> you wrote:
>>
>>>> This code is a debug code. As fair as I remember debug print code shall
>>>> not be break in Linux kernel for easier debugging.
>>>
>>> Can you please point me to the respective entry in the CodingStyle
>>> file?
>>
>> Note the last sentence:
> ...
>>> with a long argument list. However, never break user-visible strings such as
>>> printk messages, because that breaks the ability to grep for them.
>
> Well, "user-visible strings" is definitely not the same thing as
> "debug print code", at least not for me.
They're visible to a user that has #defined DEBUG. They're something
one might want to grep on. checkpatch.pl explicitly considers
pr_debug/dev_dbg to be part of the set of functions that can go over the
limit (it just doesn't know about U-Boot's plain old "debug()"). But
whatever...
At some point you might want to consider actually writing down your
interpretations of these things into a U-Boot coding style document, so
at least we don't have to guess.
-Scott
next prev parent reply other threads:[~2011-10-10 20:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 14:29 [U-Boot] [PATCH v2 0/5] usb:gadget USB Gadget support Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation Lukasz Majewski
2011-07-13 14:43 ` Vitaly Kuzmichev
2011-07-14 8:14 ` [U-Boot] [RESEND PATCH " Lukasz Majewski
2011-10-06 22:10 ` [U-Boot] [PATCH " Wolfgang Denk
2011-10-07 7:39 ` Lukasz Majewski
2011-10-09 19:43 ` Wolfgang Denk
2011-10-10 20:00 ` Scott Wood
2011-10-10 20:38 ` Wolfgang Denk
2011-10-10 20:55 ` Scott Wood [this message]
2011-10-10 21:54 ` Wolfgang Denk
2011-10-10 22:00 ` Scott Wood
2011-07-13 14:29 ` [U-Boot] [PATCH v2 2/5] usb:gadget:s5p Enabling the USB Gadget framework at GONI Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 3/5] usb:gadget: USB Mass Storage - files from Linux kernel Lukasz Majewski
2011-10-06 22:10 ` Wolfgang Denk
2011-10-07 7:28 ` Lukasz Majewski
2011-10-07 8:25 ` Wolfgang Denk
2011-07-13 14:29 ` [U-Boot] [PATCH v2 4/5] usb:gadget: USB Mass Storage Gadget support Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 5/5] usb:gadget:s5p Support for USB Mass Storage Gadget on GONI Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E935BDC.7000109@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.