All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation
Date: Sun, 09 Oct 2011 21:43:36 +0200	[thread overview]
Message-ID: <20111009194336.C84971408775@gemini.denx.de> (raw)
In-Reply-To: <20111007093950.17d94287@lmajewski.digital.local>

Dear Lukasz Majewski,

In message <20111007093950.17d94287@lmajewski.digital.local> you wrote:
>
> Most warnings are related to lines over 80 characters. 
> This code is a debug code. As fair as I remember debug print code shall
> not be break in Linux kernel for easier debugging.

Can you please point me to the respective entry in the CodingStyle
file?

> I don't know what is the policy in u-boot. I haven't seen any guideline
> about breaking debug code when it is larger than 80 characters (so I
> stick to kernel policy).

We make no distinction between different "types" of code.

> Other warnings are related to kernel API (like the min() macro usage)
> which is different in u-boot.

So it needs to be fixed?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A supercomputer is a machine that runs an endless loop in 2 seconds.

  reply	other threads:[~2011-10-09 19:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 14:29 [U-Boot] [PATCH v2 0/5] usb:gadget USB Gadget support Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation Lukasz Majewski
2011-07-13 14:43   ` Vitaly Kuzmichev
2011-07-14  8:14   ` [U-Boot] [RESEND PATCH " Lukasz Majewski
2011-10-06 22:10   ` [U-Boot] [PATCH " Wolfgang Denk
2011-10-07  7:39     ` Lukasz Majewski
2011-10-09 19:43       ` Wolfgang Denk [this message]
2011-10-10 20:00         ` Scott Wood
2011-10-10 20:38           ` Wolfgang Denk
2011-10-10 20:55             ` Scott Wood
2011-10-10 21:54               ` Wolfgang Denk
2011-10-10 22:00                 ` Scott Wood
2011-07-13 14:29 ` [U-Boot] [PATCH v2 2/5] usb:gadget:s5p Enabling the USB Gadget framework at GONI Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 3/5] usb:gadget: USB Mass Storage - files from Linux kernel Lukasz Majewski
2011-10-06 22:10   ` Wolfgang Denk
2011-10-07  7:28     ` Lukasz Majewski
2011-10-07  8:25       ` Wolfgang Denk
2011-07-13 14:29 ` [U-Boot] [PATCH v2 4/5] usb:gadget: USB Mass Storage Gadget support Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 5/5] usb:gadget:s5p Support for USB Mass Storage Gadget on GONI Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111009194336.C84971408775@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.