All of lore.kernel.org
 help / color / mirror / Atom feed
* domain pause vs. watchdog timer
@ 2011-10-13 13:41 Laszlo Ersek
  2011-10-13 14:21 ` Jan Beulich
  2011-10-13 14:39 ` Keir Fraser
  0 siblings, 2 replies; 6+ messages in thread
From: Laszlo Ersek @ 2011-10-13 13:41 UTC (permalink / raw)
  To: xen-devel

Hi,

if a domain is paused (= not scheduled), its process that keeps 
otherwise kicking /dev/watchdog and (thusly the hypervisor) "freezes" 
too. Should pausing a domain suspend (or "inactivate") its watchdog_timers?

(I believe this must have been considered and the answer is "you 
shouldn't do that", but a confirmation/refutation would be nice.)

Thanks
L.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: domain pause vs. watchdog timer
  2011-10-13 13:41 domain pause vs. watchdog timer Laszlo Ersek
@ 2011-10-13 14:21 ` Jan Beulich
  2011-10-13 14:38   ` Laszlo Ersek
  2011-10-13 14:39 ` Keir Fraser
  1 sibling, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2011-10-13 14:21 UTC (permalink / raw)
  To: Laszlo Ersek; +Cc: xen-devel

>>> On 13.10.11 at 15:41, Laszlo Ersek <lersek@redhat.com> wrote:
> if a domain is paused (= not scheduled), its process that keeps 
> otherwise kicking /dev/watchdog and (thusly the hypervisor) "freezes" 
> too. Should pausing a domain suspend (or "inactivate") its watchdog_timers?

I would say yes it should. And you say it doesn't?

> (I believe this must have been considered and the answer is "you 
> shouldn't do that", but a confirmation/refutation would be nice.)

If a domain gets paused from the tools stack, it's not very reasonable
to expect the operator there to know whether a particular domain
has a watchdog timer activated.

Jan

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: domain pause vs. watchdog timer
  2011-10-13 14:21 ` Jan Beulich
@ 2011-10-13 14:38   ` Laszlo Ersek
  2011-10-13 14:56     ` Keir Fraser
  0 siblings, 1 reply; 6+ messages in thread
From: Laszlo Ersek @ 2011-10-13 14:38 UTC (permalink / raw)
  To: Jan Beulich; +Cc: Igor Mammedov, xen-devel

On 10/13/11 16:21, Jan Beulich wrote:
>>>> On 13.10.11 at 15:41, Laszlo Ersek<lersek@redhat.com>  wrote:
>> if a domain is paused (= not scheduled), its process that keeps
>> otherwise kicking /dev/watchdog and (thusly the hypervisor) "freezes"
>> too. Should pausing a domain suspend (or "inactivate") its watchdog_timers?
>
> I would say yes it should. And you say it doesn't?

I must have missed a changeset (or a hunk?) related to pausing:

https://bugzilla.redhat.com/show_bug.cgi?id=742880#c1

I backported 21529 from xen-unstable to the RHEL-5 hypervisor version, 
and Igor tested pausing a Fedora 16 HVM guest. The domU was destroyed 
while it was paused.

Thanks!
L.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: domain pause vs. watchdog timer
  2011-10-13 13:41 domain pause vs. watchdog timer Laszlo Ersek
  2011-10-13 14:21 ` Jan Beulich
@ 2011-10-13 14:39 ` Keir Fraser
  1 sibling, 0 replies; 6+ messages in thread
From: Keir Fraser @ 2011-10-13 14:39 UTC (permalink / raw)
  To: Laszlo Ersek, xen-devel

On 13/10/2011 14:41, "Laszlo Ersek" <lersek@redhat.com> wrote:

> Hi,
> 
> if a domain is paused (= not scheduled), its process that keeps
> otherwise kicking /dev/watchdog and (thusly the hypervisor) "freezes"
> too. Should pausing a domain suspend (or "inactivate") its watchdog_timers?
> 
> (I believe this must have been considered and the answer is "you
> shouldn't do that", but a confirmation/refutation would be nice.)

Yes, the ability to pause a domain from the toolstack command line was added
way back in the beginning largely because... Well, because it could be done,
and it was easy! It's not actually a very good idea. You won't actually find
the toolstack itself automatically pausing a domain in very many places at
all -- most places where it does are debug/diagnostic code, or where a
domain is about to be destroyed anyway.

So, yes, in short: don't do that! :-)

 -- Keir

> Thanks
> L.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: domain pause vs. watchdog timer
  2011-10-13 14:38   ` Laszlo Ersek
@ 2011-10-13 14:56     ` Keir Fraser
  2011-10-13 17:11       ` Laszlo Ersek
  0 siblings, 1 reply; 6+ messages in thread
From: Keir Fraser @ 2011-10-13 14:56 UTC (permalink / raw)
  To: Laszlo Ersek, Jan Beulich; +Cc: Igor Mammedov, xen-devel

On 13/10/2011 15:38, "Laszlo Ersek" <lersek@redhat.com> wrote:

> On 10/13/11 16:21, Jan Beulich wrote:
>>>>> On 13.10.11 at 15:41, Laszlo Ersek<lersek@redhat.com>  wrote:
>>> if a domain is paused (= not scheduled), its process that keeps
>>> otherwise kicking /dev/watchdog and (thusly the hypervisor) "freezes"
>>> too. Should pausing a domain suspend (or "inactivate") its watchdog_timers?
>> 
>> I would say yes it should. And you say it doesn't?
> 
> I must have missed a changeset (or a hunk?) related to pausing:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=742880#c1
> 
> I backported 21529 from xen-unstable to the RHEL-5 hypervisor version,
> and Igor tested pausing a Fedora 16 HVM guest. The domU was destroyed
> while it was paused.

You are just as likely to upset a watchdog implemented entirely internally
to the guest, and which we have no chance to disable/suspend when a domain
is paused. Domain pausing from the dom0 command line really doesn't have a
production use case afaik -- just don't do it is my helpful suggestion.

 -- Keir

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: domain pause vs. watchdog timer
  2011-10-13 14:56     ` Keir Fraser
@ 2011-10-13 17:11       ` Laszlo Ersek
  0 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2011-10-13 17:11 UTC (permalink / raw)
  To: Keir Fraser; +Cc: Igor Mammedov, xen-devel, Jan Beulich

On 10/13/11 16:56, Keir Fraser wrote:
> On 13/10/2011 15:38, "Laszlo Ersek"<lersek@redhat.com>  wrote:
>
>> On 10/13/11 16:21, Jan Beulich wrote:
>>>>>> On 13.10.11 at 15:41, Laszlo Ersek<lersek@redhat.com>   wrote:
>>>> if a domain is paused (= not scheduled), its process that keeps
>>>> otherwise kicking /dev/watchdog and (thusly the hypervisor) "freezes"
>>>> too. Should pausing a domain suspend (or "inactivate") its watchdog_timers?
>>>
>>> I would say yes it should. And you say it doesn't?
>>
>> I must have missed a changeset (or a hunk?) related to pausing:
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=742880#c1
>>
>> I backported 21529 from xen-unstable to the RHEL-5 hypervisor version,
>> and Igor tested pausing a Fedora 16 HVM guest. The domU was destroyed
>> while it was paused.
>
> You are just as likely to upset a watchdog implemented entirely internally
> to the guest, and which we have no chance to disable/suspend when a domain
> is paused. Domain pausing from the dom0 command line really doesn't have a
> production use case afaik -- just don't do it is my helpful suggestion.

Thank you both for the answers.
L.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-10-13 17:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-13 13:41 domain pause vs. watchdog timer Laszlo Ersek
2011-10-13 14:21 ` Jan Beulich
2011-10-13 14:38   ` Laszlo Ersek
2011-10-13 14:56     ` Keir Fraser
2011-10-13 17:11       ` Laszlo Ersek
2011-10-13 14:39 ` Keir Fraser

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.