All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: pxa/cm-x300: properly set bt_reset pin
@ 2011-09-17 14:15 ` Axel Lin
  0 siblings, 0 replies; 12+ messages in thread
From: Axel Lin @ 2011-09-17 14:15 UTC (permalink / raw)
  To: linux-kernel; +Cc: Igor Grinberg, Eric Miao, Russell King, linux-arm-kernel

Fix below build warning and properly set bt_reset pin.

  CC      arch/arm/mach-pxa/cm-x300.o
arch/arm/mach-pxa/cm-x300.c: In function 'cm_x300_init_wi2wi':
arch/arm/mach-pxa/cm-x300.c:779: warning: unused variable 'wlan_en'
arch/arm/mach-pxa/cm-x300.c:795: warning: 'bt_reset' may be used uninitialized in this function

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 arch/arm/mach-pxa/cm-x300.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-pxa/cm-x300.c b/arch/arm/mach-pxa/cm-x300.c
index 0f00e01..0e18eb9 100644
--- a/arch/arm/mach-pxa/cm-x300.c
+++ b/arch/arm/mach-pxa/cm-x300.c
@@ -776,7 +776,6 @@ static struct gpio cm_x300_wi2wi_gpios[] __initdata = {
 
 static void __init cm_x300_init_wi2wi(void)
 {
-	int bt_reset, wlan_en;
 	int err;
 
 	if (system_rev < 130) {
@@ -792,12 +791,11 @@ static void __init cm_x300_init_wi2wi(void)
 	}
 
 	udelay(10);
-	gpio_set_value(bt_reset, 0);
+	gpio_set_value(cm_x300_wi2wi_gpios[1].gpio, 0);
 	udelay(10);
-	gpio_set_value(bt_reset, 1);
+	gpio_set_value(cm_x300_wi2wi_gpios[1].gpio, 1);
 
-	gpio_free(wlan_en);
-	gpio_free(bt_reset);
+	gpio_free_array(ARRAY_AND_SIZE(cm_x300_wi2wi_gpios));
 }
 
 /* MFP */
-- 
1.7.4.1




^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2011-10-25 14:37 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-17 14:15 [PATCH] ARM: pxa/cm-x300: properly set bt_reset pin Axel Lin
2011-09-17 14:15 ` Axel Lin
2011-09-22 10:30 ` Igor Grinberg
2011-09-22 10:30   ` Igor Grinberg
2011-09-29  7:57   ` Axel Lin
2011-09-29  7:57     ` Axel Lin
2011-10-17 15:45     ` Igor Grinberg
2011-10-17 15:45       ` Igor Grinberg
2011-10-25 14:30       ` Igor Grinberg
2011-10-25 14:30         ` Igor Grinberg
2011-10-25 14:37         ` Eric Miao
2011-10-25 14:37           ` Eric Miao

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.