Re: [Qemu-devel] [PATCH 0/4] add "make check"

From: Anthony Liguori <anthony@codemonkey.ws>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] add "make check"
Date: Tue, 25 Oct 2011 10:03:07 -0500	[thread overview]
Message-ID: <4EA6CFAB.9060702@codemonkey.ws> (raw)
In-Reply-To: <4EA6A9CD.5080103@redhat.com>

On 10/25/2011 07:21 AM, Kevin Wolf wrote:
> Am 24.10.2011 20:57, schrieb Anthony Liguori:
>> On 10/24/2011 01:43 PM, Eduardo Habkost wrote:
>>> On Mon, Sep 05, 2011 at 09:55:20AM +0200, Markus Armbruster wrote:
>>>> Gerd Hoffmann<kraxel@redhat.com>   writes:
>>>>
>>>>>     Hi,
>>>>>
>>>>> This patch series intends to make unit testing easier.  It adds a new
>>>>> "make check" target which can be used to run all unit tests which are
>>>>> currently in the tree.  It also enables the unit tests by default, so
>>>>> you don't have to re-run configure with a special switch.
>>>>
>>>> Reviewed-by: Markus Armbruster<armbru@redhat.com>
>>>>
>>>> One test fails, but Luiz has a fix in his tree.
>>>
>>> Reviewed-by: Eduardo Habkost<ehabkost@redhat.com>
>>>
>>> Now all tests are passing. Why this was not applied yet?
>>
>> I was hoping for more, but maybe we just need to start here and grow
>> organically, I'll queue it again.
>
> A while ago I played with some simple IDE tests. It basically was a
> small x86 kernel with an empty image that sends IDE commands and prints
> some results, and a script that invokes the guest and checks whether the
> test has passed or failed.
>
> So at first I started with my own multiboot kernel and copied over some
> parts of kvm-unittest's libc. Clearly not the best idea once it's more
> than a couple of lines, so at some point I took the code and integrated
> with my real kvm-unittests repository.

I did something very similar.  I just added PCI support to kvm-unittests such 
that I could write a small virtio driver.

I actually do think tests like this could live in a make check framework in QEMU.

Regards,

Anthony Liguori

>
> Now I don't have to duplicate code any more, but at the same time
> there's no chance that a 'make check' in an upstream qemu tree could run
> this. Tests for other devices will have exactly the same problem.
>
> Any suggestions on how to go forward with this kind of tests? Should
> this go into qemu or into kvm-unittests? Or should kvm-unittests be
> merged into the qemu tree? Or is the approach completely wrong?
>
> Kevin
>