From: Rajendra Nayak <rnayak@ti.com> To: Tony Lindgren <tony@atomide.com> Cc: linux-serial@vger.kernel.org, linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, khilman@ti.com, govindraj.raja@ti.com, b-cousson@ti.com, linux-arm-kernel@lists.infradead.org, linaro-dev@lists.linaro.org, patches@linaro.org, robherring2@gmail.com Subject: Re: [PATCH v3 4/4] ARM: omap: pass minimal SoC/board data for UART from dt Date: Thu, 15 Dec 2011 12:22:19 +0530 [thread overview] Message-ID: <4EE99923.4030902@ti.com> (raw) In-Reply-To: <20111214192509.GH32251@atomide.com> On Thursday 15 December 2011 12:55 AM, Tony Lindgren wrote: > * Rajendra Nayak<rnayak@ti.com> [111214 03:24]: >> Pass minimal data needed for console boot, from dt, for >> OMAP4 panda/sdp and OMAP3 beagle boards, and get rid of the >> static initialization from generic board file. >> >> Acked-by: Rob Herring<rob.herring@calxeda.com> >> Signed-off-by: Rajendra Nayak<rnayak@ti.com> > > This we can't merge because this breaks serial console for > omap2 because you're not adding the omap2 specific dtsi > entries for omap2.. But we never had omap2 working with DT, because we never added a .dtsi file for omap2 or a .dts file for any omap2 board variants. Until now the DT support on OMAP has been limited to OMAP3 and OMAP4 with boards limited to omap3beagle/omap4Panda and omap4sdp. So when we do add base support for omap2, we could update those with the serial entries. > >> --- a/arch/arm/mach-omap2/board-generic.c >> +++ b/arch/arm/mach-omap2/board-generic.c >> @@ -69,7 +69,6 @@ static void __init omap_generic_init(void) >> if (node) >> irq_domain_add_simple(node, 0); >> >> - omap_serial_init(); >> omap_sdrc_init(NULL, NULL); >> >> of_platform_populate(NULL, omap_dt_match_table, NULL, NULL); > > ..and you're removing the call for omap_serial_init. > > Please just update this patch with the omap2 entries > as well. Other than that looks good to me. > > Tony
WARNING: multiple messages have this Message-ID (diff)
From: rnayak@ti.com (Rajendra Nayak) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 4/4] ARM: omap: pass minimal SoC/board data for UART from dt Date: Thu, 15 Dec 2011 12:22:19 +0530 [thread overview] Message-ID: <4EE99923.4030902@ti.com> (raw) In-Reply-To: <20111214192509.GH32251@atomide.com> On Thursday 15 December 2011 12:55 AM, Tony Lindgren wrote: > * Rajendra Nayak<rnayak@ti.com> [111214 03:24]: >> Pass minimal data needed for console boot, from dt, for >> OMAP4 panda/sdp and OMAP3 beagle boards, and get rid of the >> static initialization from generic board file. >> >> Acked-by: Rob Herring<rob.herring@calxeda.com> >> Signed-off-by: Rajendra Nayak<rnayak@ti.com> > > This we can't merge because this breaks serial console for > omap2 because you're not adding the omap2 specific dtsi > entries for omap2.. But we never had omap2 working with DT, because we never added a .dtsi file for omap2 or a .dts file for any omap2 board variants. Until now the DT support on OMAP has been limited to OMAP3 and OMAP4 with boards limited to omap3beagle/omap4Panda and omap4sdp. So when we do add base support for omap2, we could update those with the serial entries. > >> --- a/arch/arm/mach-omap2/board-generic.c >> +++ b/arch/arm/mach-omap2/board-generic.c >> @@ -69,7 +69,6 @@ static void __init omap_generic_init(void) >> if (node) >> irq_domain_add_simple(node, 0); >> >> - omap_serial_init(); >> omap_sdrc_init(NULL, NULL); >> >> of_platform_populate(NULL, omap_dt_match_table, NULL, NULL); > > ..and you're removing the call for omap_serial_init. > > Please just update this patch with the omap2 entries > as well. Other than that looks good to me. > > Tony
next prev parent reply other threads:[~2011-12-15 6:52 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-12-14 11:55 [PATCH v3 0/4] OMAP serial device tree support Rajendra Nayak 2011-12-14 11:55 ` Rajendra Nayak 2011-12-14 11:55 ` [PATCH v3 1/4] omap-serial: Get rid of all pdev->id usage Rajendra Nayak 2011-12-14 11:55 ` Rajendra Nayak 2011-12-14 11:55 ` [PATCH v3 2/4] omap-serial: Use default clock speed (48Mhz) if not specified Rajendra Nayak 2011-12-14 11:55 ` Rajendra Nayak 2011-12-14 11:55 ` [PATCH v3 3/4] omap-serial: Add minimal device tree support Rajendra Nayak 2011-12-14 11:55 ` Rajendra Nayak 2011-12-14 11:55 ` [PATCH v3 4/4] ARM: omap: pass minimal SoC/board data for UART from dt Rajendra Nayak 2011-12-14 11:55 ` Rajendra Nayak 2011-12-14 19:25 ` Tony Lindgren 2011-12-14 19:25 ` Tony Lindgren 2011-12-15 6:52 ` Rajendra Nayak [this message] 2011-12-15 6:52 ` Rajendra Nayak 2011-12-15 10:06 ` Cousson, Benoit 2011-12-15 10:06 ` Cousson, Benoit 2011-12-15 21:13 ` Tony Lindgren 2011-12-15 21:13 ` Tony Lindgren 2011-12-15 21:28 ` Cousson, Benoit 2011-12-15 21:28 ` Cousson, Benoit 2011-12-15 21:37 ` Tony Lindgren 2011-12-15 21:37 ` Tony Lindgren 2011-12-15 21:39 ` [PATCH] arm/dts: Add minimal device tree support for omap2420 and omap2430 Tony Lindgren 2011-12-15 21:39 ` Tony Lindgren 2011-12-16 4:01 ` Rajendra Nayak 2011-12-16 4:01 ` Rajendra Nayak 2011-12-16 15:21 ` [PATCH v3 4/4] ARM: omap: pass minimal SoC/board data for UART from dt Cousson, Benoit 2011-12-16 15:21 ` Cousson, Benoit [not found] ` <1323863746-18145-5-git-send-email-rnayak-l0cyMroinI0@public.gmane.org> 2012-04-11 0:16 ` Ramirez Luna, Omar 2012-04-11 0:16 ` Ramirez Luna, Omar 2012-04-11 8:39 ` Cousson, Benoit 2012-04-11 8:39 ` Cousson, Benoit 2012-04-11 15:57 ` Ramirez Luna, Omar 2012-04-11 15:57 ` Ramirez Luna, Omar 2011-12-14 13:47 ` [PATCH v3 0/4] OMAP serial device tree support Rob Herring 2011-12-14 13:47 ` Rob Herring 2011-12-16 21:57 ` Tony Lindgren 2011-12-16 21:57 ` Tony Lindgren 2011-12-16 22:02 ` Rob Herring 2011-12-16 22:02 ` Rob Herring 2011-12-16 22:09 ` Tony Lindgren 2011-12-16 22:09 ` Tony Lindgren 2011-12-14 14:41 ` Govindraj 2011-12-14 14:41 ` Govindraj 2011-12-14 15:20 ` Kevin Hilman 2011-12-14 15:20 ` Kevin Hilman 2011-12-14 17:18 ` Alan Cox 2011-12-14 17:18 ` Alan Cox 2011-12-14 18:27 ` Greg KH 2011-12-14 18:27 ` Greg KH 2011-12-16 22:17 ` Tony Lindgren 2011-12-16 22:17 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4EE99923.4030902@ti.com \ --to=rnayak@ti.com \ --cc=b-cousson@ti.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=govindraj.raja@ti.com \ --cc=khilman@ti.com \ --cc=linaro-dev@lists.linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=patches@linaro.org \ --cc=robherring2@gmail.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.