[PATCH][meta-kernel-dev] kern-tools: Include do_install() in bbappend

[PATCH][meta-kernel-dev] kern-tools: Include do_install() in bbappend

[Darren Hart]

do_install() has changed over versions of kern-tools, ensure this matches
the latest sources as referenced by ${AUTOREV}. Without this, using
this bbappend against older kern-tools recipes will fail in very strange
and unexplainable ways. The edison recipe for example has:

do_install() {
        install -d ${D}${bindir}
        for s in ${kern_tools_LIST}; do
            install -m 0755 ${S}/git/tools/$s ${D}${bindir}
        done
}

This resulted in do_kernel_configme failures:

| mv: cannot stat `/usr/local/src/yocto_1_1/poky/build/tmp/work/crystalforest-poky-linux/linux-yocto-rt-3.0.4+git1+d05450e4aef02c1b7137398ab3a9f8f96da74f52_1+0936e13cc65d816f1759e2322c5e3fc82a5037f3-r1/linux-crystalforest-preempt-rt-build/.tmp.config*': No such file or directory

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
CC: Kishore Bodke <kishore.k.bodke@intel.com>
---
 .../kern-tools-native_git.bbappend                 |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/meta-kernel-dev/recipes-kernel/kern-tools-native/kern-tools-native_git.bbappend b/meta-kernel-dev/recipes-kernel/kern-tools-native/kern-tools-native_git.bbappend
index 201ec7f..445b385 100644
--- a/meta-kernel-dev/recipes-kernel/kern-tools-native/kern-tools-native_git.bbappend
+++ b/meta-kernel-dev/recipes-kernel/kern-tools-native/kern-tools-native_git.bbappend
@@ -5,3 +5,10 @@ LOCALCOUNT = "0"
 # For local kern-tools work, fill in KERN_TOOLS_SRC and uncomment the SRC_URI
 # KERN_TOOLS_SRC ?= /path/to/local/kern-tools-clone
 # SRC_URI = "git://${KERN_TOOLS_SRC}"
+
+# This step has changed over versions of kern-tools, ensure this matches
+# the latest sources as referenced by ${AUTOREV}
+do_install() {
+	cd ${S}/git
+	make DESTDIR=${D}${bindir} install
+}
-- 
1.7.6.4

Re: [PATCH][meta-kernel-dev] kern-tools: Include do_install() in bbappend

[Bruce Ashfield]

On 11-12-16 8:31 PM, Darren Hart wrote:
> do_install() has changed over versions of kern-tools, ensure this matches
> the latest sources as referenced by ${AUTOREV}. Without this, using
> this bbappend against older kern-tools recipes will fail in very strange
> and unexplainable ways. The edison recipe for example has:
>
> do_install() {
>          install -d ${D}${bindir}
>          for s in ${kern_tools_LIST}; do
>              install -m 0755 ${S}/git/tools/$s ${D}${bindir}
>          done
> }

We don't need this. As I mentioned in other email, meta-kernel-dev
works with master, not any particular branch.

Removing this bbappend is the right solution if you aren't on master.

Having this in the bbappend, simply means that when I change the install
next time .. this breaks again.

Bruce

>
> This resulted in do_kernel_configme failures:
>
> | mv: cannot stat `/usr/local/src/yocto_1_1/poky/build/tmp/work/crystalforest-poky-linux/linux-yocto-rt-3.0.4+git1+d05450e4aef02c1b7137398ab3a9f8f96da74f52_1+0936e13cc65d816f1759e2322c5e3fc82a5037f3-r1/linux-crystalforest-preempt-rt-build/.tmp.config*': No such file or directory
>
> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
> CC: Kishore Bodke<kishore.k.bodke@intel.com>
> ---
>   .../kern-tools-native_git.bbappend                 |    7 +++++++
>   1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/meta-kernel-dev/recipes-kernel/kern-tools-native/kern-tools-native_git.bbappend b/meta-kernel-dev/recipes-kernel/kern-tools-native/kern-tools-native_git.bbappend
> index 201ec7f..445b385 100644
> --- a/meta-kernel-dev/recipes-kernel/kern-tools-native/kern-tools-native_git.bbappend
> +++ b/meta-kernel-dev/recipes-kernel/kern-tools-native/kern-tools-native_git.bbappend
> @@ -5,3 +5,10 @@ LOCALCOUNT = "0"
>   # For local kern-tools work, fill in KERN_TOOLS_SRC and uncomment the SRC_URI
>   # KERN_TOOLS_SRC ?= /path/to/local/kern-tools-clone
>   # SRC_URI = "git://${KERN_TOOLS_SRC}"
> +
> +# This step has changed over versions of kern-tools, ensure this matches
> +# the latest sources as referenced by ${AUTOREV}
> +do_install() {
> +	cd ${S}/git
> +	make DESTDIR=${D}${bindir} install
> +}