All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Richard Weinberger <richard@nod.at>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi_dh: Fix return value of scsi_dh_attach()
Date: Mon, 19 Dec 2011 12:59:16 +0100	[thread overview]
Message-ID: <4EEF2714.1080402@suse.de> (raw)
In-Reply-To: <4EEDFE4E.6090104@nod.at>

On 12/18/2011 03:53 PM, Richard Weinberger wrote:
> Am 18.12.2011 15:45, schrieb James Bottomley:
>> On Sun, 2011-12-18 at 15:43 +0100, Richard Weinberger wrote:
>>> Am 18.11.2011 00:34, schrieb Richard Weinberger:
>>>> scsi_dh_attach() should return a negative value on error.
>>>>
>>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>>> ---
>>>>  include/scsi/scsi_dh.h |    2 +-
>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/include/scsi/scsi_dh.h b/include/scsi/scsi_dh.h
>>>> index e3f2db2..e07ab10 100644
>>>> --- a/include/scsi/scsi_dh.h
>>>> +++ b/include/scsi/scsi_dh.h
>>>> @@ -74,7 +74,7 @@ static inline int scsi_dh_handler_exist(const char *name)
>>>>  }
>>>>  static inline int scsi_dh_attach(struct request_queue *req, const char *name)
>>>>  {
>>>> -	return SCSI_DH_NOSYS;
>>>> +	return -SCSI_DH_NOSYS;
>>>>  }
>>>>  static inline void scsi_dh_detach(struct request_queue *q)
>>>>  {
>>>
>>> James,
>>>
>>> can you please pickup this patch?
>>
>> It still needs an ack from rdac people (other one just got overlooked).
>>
> 
> Who are the rdac people?
> I sent the patch to all addresses reported by get_maintainers.pl.
> 
Nack.

This patch is wrong.

scsi_dh_attach() (and, incidentally, scsi_dh_set_params()) should
return a standard error value. SCSI_DH_XXX are internal to
device_handler and should never see the light of day.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Richard Weinberger <richard@nod.at>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi_dh: Fix return value of scsi_dh_attach()
Date: Mon, 19 Dec 2011 12:59:16 +0100	[thread overview]
Message-ID: <4EEF2714.1080402@suse.de> (raw)
In-Reply-To: <4EEDFE4E.6090104@nod.at>

On 12/18/2011 03:53 PM, Richard Weinberger wrote:
> Am 18.12.2011 15:45, schrieb James Bottomley:
>> On Sun, 2011-12-18 at 15:43 +0100, Richard Weinberger wrote:
>>> Am 18.11.2011 00:34, schrieb Richard Weinberger:
>>>> scsi_dh_attach() should return a negative value on error.
>>>>
>>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>>> ---
>>>>  include/scsi/scsi_dh.h |    2 +-
>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/include/scsi/scsi_dh.h b/include/scsi/scsi_dh.h
>>>> index e3f2db2..e07ab10 100644
>>>> --- a/include/scsi/scsi_dh.h
>>>> +++ b/include/scsi/scsi_dh.h
>>>> @@ -74,7 +74,7 @@ static inline int scsi_dh_handler_exist(const char *name)
>>>>  }
>>>>  static inline int scsi_dh_attach(struct request_queue *req, const char *name)
>>>>  {
>>>> -	return SCSI_DH_NOSYS;
>>>> +	return -SCSI_DH_NOSYS;
>>>>  }
>>>>  static inline void scsi_dh_detach(struct request_queue *q)
>>>>  {
>>>
>>> James,
>>>
>>> can you please pickup this patch?
>>
>> It still needs an ack from rdac people (other one just got overlooked).
>>
> 
> Who are the rdac people?
> I sent the patch to all addresses reported by get_maintainers.pl.
> 
Nack.

This patch is wrong.

scsi_dh_attach() (and, incidentally, scsi_dh_set_params()) should
return a standard error value. SCSI_DH_XXX are internal to
device_handler and should never see the light of day.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-12-19 11:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-17 23:34 [PATCH] scsi_dh: Fix return value of scsi_dh_attach() Richard Weinberger
2011-12-18 14:43 ` Richard Weinberger
2011-12-18 14:45   ` James Bottomley
2011-12-18 14:53     ` Richard Weinberger
2011-12-19 11:59       ` Hannes Reinecke [this message]
2011-12-19 11:59         ` Hannes Reinecke
2011-12-19 12:40         ` Richard Weinberger
2011-12-19 12:05 Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EEF2714.1080402@suse.de \
    --to=hare@suse.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.