All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	'Ben Dooks' <ben-linux@fluff.org>
Subject: Re: [PATCH] ARM: restart: S3C64XX: use new restart hook
Date: Mon, 19 Dec 2011 23:37:59 +0900	[thread overview]
Message-ID: <4EEF4C47.6040408@samsung.com> (raw)
In-Reply-To: <20111219135530.GG14542@n2100.arm.linux.org.uk>

On 12/19/11 22:55, Russell King - ARM Linux wrote:
> On Mon, Dec 19, 2011 at 08:58:20PM +0900, Kukjin Kim wrote:
>> Hook these platforms restart code into the new restart hook rather
>> than using arch_reset().
>>
>> Cc: Ben Dooks<ben-linux@fluff.org>
>> Cc: Russell King<rmk+kernel@arm.linux.org.uk>
>> Signed-off-by: Kukjin Kim<kgene.kim@samsung.com>
>
> It would be _much_ better if you could prepare a set of patches against
> my devel-stable which adds this support (as has been done for others.)
>
OK, I will and other Samsung stuff such as s3c24xx, s5p and exynos will 
be implemented together against your devel-stable.

> I can merge it into my restart branch, and update the commit which removes
> arch_reset() itself, and the commit which adds the #error.  We can then
> avoid bisect breakage.
>
OK.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

>> ---
>>   arch/arm/mach-s3c64xx/common.c                     |   10 ++++++++++
>>   arch/arm/mach-s3c64xx/common.h                     |    2 ++
>>   arch/arm/mach-s3c64xx/include/mach/system.h        |   12 ------------
>>   arch/arm/mach-s3c64xx/mach-anw6410.c               |    1 +
>>   arch/arm/mach-s3c64xx/mach-crag6410.c              |    1 +
>>   arch/arm/mach-s3c64xx/mach-hmt.c                   |    1 +
>>   arch/arm/mach-s3c64xx/mach-mini6410.c              |    1 +
>>   arch/arm/mach-s3c64xx/mach-ncp.c                   |    1 +
>>   arch/arm/mach-s3c64xx/mach-real6410.c              |    1 +
>>   arch/arm/mach-s3c64xx/mach-smartq5.c               |    1 +
>>   arch/arm/mach-s3c64xx/mach-smartq7.c               |    1 +
>>   arch/arm/mach-s3c64xx/mach-smdk6400.c              |    1 +
>>   arch/arm/mach-s3c64xx/mach-smdk6410.c              |    1 +
>>   .../arm/plat-samsung/include/plat/watchdog-reset.h |    1 +
>>   14 files changed, 23 insertions(+), 12 deletions(-)

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: restart: S3C64XX: use new restart hook
Date: Mon, 19 Dec 2011 23:37:59 +0900	[thread overview]
Message-ID: <4EEF4C47.6040408@samsung.com> (raw)
In-Reply-To: <20111219135530.GG14542@n2100.arm.linux.org.uk>

On 12/19/11 22:55, Russell King - ARM Linux wrote:
> On Mon, Dec 19, 2011 at 08:58:20PM +0900, Kukjin Kim wrote:
>> Hook these platforms restart code into the new restart hook rather
>> than using arch_reset().
>>
>> Cc: Ben Dooks<ben-linux@fluff.org>
>> Cc: Russell King<rmk+kernel@arm.linux.org.uk>
>> Signed-off-by: Kukjin Kim<kgene.kim@samsung.com>
>
> It would be _much_ better if you could prepare a set of patches against
> my devel-stable which adds this support (as has been done for others.)
>
OK, I will and other Samsung stuff such as s3c24xx, s5p and exynos will 
be implemented together against your devel-stable.

> I can merge it into my restart branch, and update the commit which removes
> arch_reset() itself, and the commit which adds the #error.  We can then
> avoid bisect breakage.
>
OK.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

>> ---
>>   arch/arm/mach-s3c64xx/common.c                     |   10 ++++++++++
>>   arch/arm/mach-s3c64xx/common.h                     |    2 ++
>>   arch/arm/mach-s3c64xx/include/mach/system.h        |   12 ------------
>>   arch/arm/mach-s3c64xx/mach-anw6410.c               |    1 +
>>   arch/arm/mach-s3c64xx/mach-crag6410.c              |    1 +
>>   arch/arm/mach-s3c64xx/mach-hmt.c                   |    1 +
>>   arch/arm/mach-s3c64xx/mach-mini6410.c              |    1 +
>>   arch/arm/mach-s3c64xx/mach-ncp.c                   |    1 +
>>   arch/arm/mach-s3c64xx/mach-real6410.c              |    1 +
>>   arch/arm/mach-s3c64xx/mach-smartq5.c               |    1 +
>>   arch/arm/mach-s3c64xx/mach-smartq7.c               |    1 +
>>   arch/arm/mach-s3c64xx/mach-smdk6400.c              |    1 +
>>   arch/arm/mach-s3c64xx/mach-smdk6410.c              |    1 +
>>   .../arm/plat-samsung/include/plat/watchdog-reset.h |    1 +
>>   14 files changed, 23 insertions(+), 12 deletions(-)

  reply	other threads:[~2011-12-19 14:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-19 11:58 [PATCH] ARM: restart: S3C64XX: use new restart hook Kukjin Kim
2011-12-19 11:58 ` Kukjin Kim
2011-12-19 12:12 ` Heiko Stübner
2011-12-19 12:12   ` Heiko Stübner
2011-12-19 12:20   ` Kukjin Kim
2011-12-19 12:20     ` Kukjin Kim
2011-12-19 12:25     ` [PATCH] ARM: restart: move SWRST based S3C platforms to machine_desc hook Heiko Stübner
2011-12-19 12:25       ` Heiko Stübner
2011-12-19 12:42       ` Kukjin Kim
2011-12-19 12:42         ` Kukjin Kim
2011-12-19 12:58         ` Heiko Stübner
2011-12-19 12:58           ` Heiko Stübner
2011-12-19 13:55 ` [PATCH] ARM: restart: S3C64XX: use new restart hook Russell King - ARM Linux
2011-12-19 13:55   ` Russell King - ARM Linux
2011-12-19 14:37   ` Kukjin Kim [this message]
2011-12-19 14:37     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EEF4C47.6040408@samsung.com \
    --to=kgene.kim@samsung.com \
    --cc=ben-linux@fluff.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.