* [PATCH net-next] mlx4_en: FIX: Setting default_qpn before using it
@ 2011-12-20 7:53 Yevgeny Petrilin
2011-12-20 18:44 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yevgeny Petrilin @ 2011-12-20 7:53 UTC (permalink / raw)
To: davem; +Cc: netdev, yevgenyp
From: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
When UDP RSS is enabled, we use same QPN for TCP and UDP ranges
The bug is that the default_qpn was used base UDP qpn before it
was set.
Fixes bug introduced in commit: 1202d460b1df3a77fda66f4ba5f90ae3527dd42f
Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
---
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
index 630a7c1..e8d6ad2 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
@@ -898,11 +898,11 @@ int mlx4_en_config_rss_steer(struct mlx4_en_priv *priv)
rss_context = ptr;
rss_context->base_qpn = cpu_to_be32(ilog2(priv->rx_ring_num) << 24 |
(rss_map->base_qpn));
+ rss_context->default_qpn = cpu_to_be32(rss_map->base_qpn);
if (priv->mdev->profile.udp_rss) {
rss_mask |= MLX4_RSS_UDP_IPV4 | MLX4_RSS_UDP_IPV6;
rss_context->base_qpn_udp = rss_context->default_qpn;
}
- rss_context->default_qpn = cpu_to_be32(rss_map->base_qpn);
rss_context->flags = rss_mask;
rss_context->hash_fn = MLX4_RSS_HASH_TOP;
for (i = 0; i < 10; i++)
--
1.7.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] mlx4_en: FIX: Setting default_qpn before using it
2011-12-20 7:53 [PATCH net-next] mlx4_en: FIX: Setting default_qpn before using it Yevgeny Petrilin
@ 2011-12-20 18:44 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-12-20 18:44 UTC (permalink / raw)
To: yevgenyp; +Cc: netdev
From: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Date: Tue, 20 Dec 2011 09:53:38 +0200
> From: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
>
> When UDP RSS is enabled, we use same QPN for TCP and UDP ranges
> The bug is that the default_qpn was used base UDP qpn before it
> was set.
> Fixes bug introduced in commit: 1202d460b1df3a77fda66f4ba5f90ae3527dd42f
>
> Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-20 18:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-20 7:53 [PATCH net-next] mlx4_en: FIX: Setting default_qpn before using it Yevgeny Petrilin
2011-12-20 18:44 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.