Re: insmod RTL8192CE OOPS on 2.6.32.16

Re: insmod RTL8192CE OOPS on 2.6.32.16

[Larry Finger]

On 12/21/2011 06:06 AM, Darshan Kumar NANDANWAR wrote:
> Larry ,
>
> I am using RTL8192CE driver for 2.6.32.16 for one of the DTV soc(sh4 cpu) ..
> Once I insert it , I get following oops... The same oops is reported by *John
> Linville in https://bugzilla.kernel.org/show_bug.cgi?id=40212 . But
> unfortunately , given link is down ; so I am unable to get into the the
> discussion. Could you please give me the pointers why it’s happening so?*
>
> Lspci is showing me correct vendor and product id which is : *0x10ec 0x8178*

I added the linux-wireless ML to the Cc list so that others will see this thread.

I do not remember the kernel bugzilla. Perhaps John does.

Are you using a recent version of compat-wireless? If not, please do.

I do not know anything about the sh4, but I will try to help.

The only rtl8192ce routine mentioned in the traceback is rtl92ce_module_init. I 
see no indication that it got as far as the .probe routine, which is 
rtl_pci_probe() in drivers/net/wireless/rtlwifi/pci.c. It might be useful to put 
a printk() at the beginning of that routine to see if it is being reached. I 
would also suggest that you modprobe the various components separately. First 
rtlwifi, then rtl8192c_common, and finally rtl8192ce.

Is the sh4 little- or big-endian? Not all the code has been tested on a BE machine.

Larry

Re: insmod RTL8192CE OOPS on 2.6.32.16

[John W. Linville]

On Wed, Dec 21, 2011 at 08:54:39AM -0600, Larry Finger wrote:
> On 12/21/2011 06:06 AM, Darshan Kumar NANDANWAR wrote:
> >Larry ,
> >
> >I am using RTL8192CE driver for 2.6.32.16 for one of the DTV soc(sh4 cpu) ..
> >Once I insert it , I get following oops... The same oops is reported by *John
> >Linville in https://bugzilla.kernel.org/show_bug.cgi?id=40212 . But
> >unfortunately , given link is down ; so I am unable to get into the the
> >discussion. Could you please give me the pointers why it’s happening so?*
> >
> >Lspci is showing me correct vendor and product id which is : *0x10ec 0x8178*
> 
> I added the linux-wireless ML to the Cc list so that others will see this thread.
> 
> I do not remember the kernel bugzilla. Perhaps John does.

No, sorry -- I have no idea what that bug was.  I don't even think
I have the device in question, so I don't know how I could even have
produced a bug report!

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: insmod RTL8192CE OOPS on 2.6.32.16

[Larry Finger]

On 12/21/2011 09:16 AM, John W. Linville wrote:

> No, sorry -- I have no idea what that bug was.  I don't even think
> I have the device in question, so I don't know how I could even have
> produced a bug report!

I found a reference at https://lkml.org/lkml/2011/7/28/42. The bug at b.k.o was 
just for tracking.

The fix came with commit b6b67df3f24c45af0012ee, which is dated Jul 29.

This bug is likely not the one causing your problem as the fix should be in 
whatever version you are running. In addition, the oops traceback in that 
instance came back to _rtl_pci_find_adapter(). Yours fails in rtl_pci_probe(). 
Any chance of telling me what statement is at rtl_pci_probe+0x652/0x1660? The 
source file is drivers/net/wireless/rtlwifi/pci.c.

Larry

Re: insmod RTL8192CE OOPS on 2.6.32.16

[Larry Finger]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

On 12/22/2011 04:09 AM, Darshan Kumar NANDANWAR wrote:
> OOPs is in  following instruction :
> pcipriv->ndis_adapter.pcibridge_vendorid = bridge_pdev->vendor;
> 656:       15 0a           mov.w   r1,@(r0,r10)
> I have attached the objdump aswell ..
>
>>> The fix came with commit b6b67df3f24c45af0012ee, which is dated Jul 29.
> What is this all about? Could you point to  this commit?

Kernel source is now maintained using git, which keeps track of changes using 
the sha1sum of the changes. The ID above is the leading digits of that sum.

The patch in question is attached. It handles the cases where the self member of 
the pci_bus struct is not present. It appears not to have been applied to your 
source. Does this patch fix your problem?

Larry



[-- Attachment #2: patch_b6b67df --]
[-- Type: text/plain, Size: 2211 bytes --]

commit b6b67df3f24c45af0012ee3c8af2f62ca083ae18
Author: Larry Finger <Larry.Finger@lwfinger.net>
Date:   Fri Jul 29 10:53:12 2011 -0500

    rtlwifi: Fix kernel oops on ARM SOC
    
    This driver uses information from the self member of the pci_bus struct to
    get information regarding the bridge to which the PCIe device is attached.
    Unfortunately, this member is not established on all architectures, which
    leads to a kernel oops.
    
    Skipping the entire block that uses the self member to determine the bridge
    vendor will only affect RTL8192DE devices as that driver sets the ASPM support
    flag differently when the bridge vendor is Intel. If the self member is
    available, there is no functional change.
    
    This patch fixes Bugzilla No. 40212.
    
    Reported-by: Hubert Liao <liao.hubertt@gmail.com>
    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Cc: Stable <stable@kernel.org> [back to 2.6.38]
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index 5efd578..56f1235 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -1696,15 +1696,17 @@ static bool _rtl_pci_find_adapter(struct pci_dev *pdev,
 	pcipriv->ndis_adapter.devnumber = PCI_SLOT(pdev->devfn);
 	pcipriv->ndis_adapter.funcnumber = PCI_FUNC(pdev->devfn);
 
-	/*find bridge info */
-	pcipriv->ndis_adapter.pcibridge_vendorid = bridge_pdev->vendor;
-	for (tmp = 0; tmp < PCI_BRIDGE_VENDOR_MAX; tmp++) {
-		if (bridge_pdev->vendor == pcibridge_vendors[tmp]) {
-			pcipriv->ndis_adapter.pcibridge_vendor = tmp;
-			RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
-				 ("Pci Bridge Vendor is found index: %d\n",
-				  tmp));
-			break;
+	if (bridge_pdev) {
+		/*find bridge info if available */
+		pcipriv->ndis_adapter.pcibridge_vendorid = bridge_pdev->vendor;
+		for (tmp = 0; tmp < PCI_BRIDGE_VENDOR_MAX; tmp++) {
+			if (bridge_pdev->vendor == pcibridge_vendors[tmp]) {
+				pcipriv->ndis_adapter.pcibridge_vendor = tmp;
+				RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
+					 ("Pci Bridge Vendor is found index:"
+					 " %d\n", tmp));
+				break;
+			}
 		}
 	}
 

RE: insmod RTL8192CE OOPS on 2.6.32.16

[Darshan Kumar NANDANWAR]

TGFycnkgLA0KTWFueSB0aGFua3MgLllvdXIgcGF0Y2ggaGVscGVkIG1lIGdldCBvdmVyIHRoYXQg
aXNzdWUuLiBCdXQgbm93ICBJIGFtIGdldHRpbmcgZm9sbG93aW5nIGVycm9yIHdoaWNoIGlzIG1h
eSBiZSBiZWNhdXNlIG9mIGZpcm13YXJlIGlzIG5vdCByZXNwb25kaW5nOg0KDQpQQ0k6IEVuYWJs
aW5nIGRldmljZSAwMDAwOjAwOjAxLjAgKDAwMDAgLT4gMDAwMykNCnJ0bDgxOTJjZSAwMDAwOjAw
OjAxLjA6IGVuYWJsaW5nIGJ1cyBtYXN0ZXJpbmcNClBDSTogU2V0dGluZyBsYXRlbmN5IHRpbWVy
IG9mIGRldmljZSAwMDAwOjAwOjAxLjAgdG8gNjQNCnJ0bDgxOTJjZTpydGw5MmNlX3JlYWRfZWVw
cm9tX2luZm8oKTo8MC0wPiBBdXRvbG9hZCBFUlIhIQ0KcnRsODE5MmNlOnJ0bDkyY19pbml0X3N3
X3ZhcnMoKTo8MC0wPiBGYWlsZWQgdG8gcmVxdWVzdCBmaXJtd2FyZSENCnJ0bHdpZmk6cnRsX3Bj
aV9wcm9iZSgpOjwwLTA+IENhbid0IGluaXRfc3dfdmFycy4NCg0KSSBoYXZlIHB1bGxlZCB1cCBs
YXRlc3QgYnJhbmNoICBvZiBsaW51eC1maXJtd2FyZS5naXQgYW5kIHVzaW5nIGZpcm13YXJlIHJ0
bHdpZmkvcnRsODE5MmNmdy5iaW4gbG9jYXRlZCBpbiAvbGliL2Zpcm13YXJlIC4uIFBsZWFzZSBn
aXZlIG1lIHNvbWUgcG9pbnRlcnMgc28gdGhhdCBJIGNhbiBnZXQgb3ZlciB0aGlzIG5vdy4uLg0K
DQoNCg0KVGhhbmtzDQpEYXJzaGFuIGt1bWFyDQoNCg0KDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2Fn
ZS0tLS0tDQpGcm9tOiBMYXJyeSBGaW5nZXIgW21haWx0bzpsYXJyeS5maW5nZXJAZ21haWwuY29t
XSBPbiBCZWhhbGYgT2YgTGFycnkgRmluZ2VyDQpTZW50OiBUaHVyc2RheSwgRGVjZW1iZXIgMjIs
IDIwMTEgOTozNyBQTQ0KVG86IERhcnNoYW4gS3VtYXIgTkFOREFOV0FSDQpDYzogSm9obiBXLiBM
aW52aWxsZTsgd2lyZWxlc3M7IFNyaWtyaXNobmEgUHJhbW9kYSBBVElLVUtLRQ0KU3ViamVjdDog
UmU6IGluc21vZCBSVEw4MTkyQ0UgT09QUyBvbiAyLjYuMzIuMTYNCg0KT24gMTIvMjIvMjAxMSAw
NDowOSBBTSwgRGFyc2hhbiBLdW1hciBOQU5EQU5XQVIgd3JvdGU6DQo+IE9PUHMgaXMgaW4gIGZv
bGxvd2luZyBpbnN0cnVjdGlvbiA6DQo+IHBjaXByaXYtPm5kaXNfYWRhcHRlci5wY2licmlkZ2Vf
dmVuZG9yaWQgPSBicmlkZ2VfcGRldi0+dmVuZG9yOw0KPiA2NTY6ICAgICAgIDE1IDBhICAgICAg
ICAgICBtb3YudyAgIHIxLEAocjAscjEwKQ0KPiBJIGhhdmUgYXR0YWNoZWQgdGhlIG9iamR1bXAg
YXN3ZWxsIC4uDQo+DQo+Pj4gVGhlIGZpeCBjYW1lIHdpdGggY29tbWl0IGI2YjY3ZGYzZjI0YzQ1
YWYwMDEyZWUsIHdoaWNoIGlzIGRhdGVkIEp1bCAyOS4NCj4gV2hhdCBpcyB0aGlzIGFsbCBhYm91
dD8gQ291bGQgeW91IHBvaW50IHRvICB0aGlzIGNvbW1pdD8NCg0KS2VybmVsIHNvdXJjZSBpcyBu
b3cgbWFpbnRhaW5lZCB1c2luZyBnaXQsIHdoaWNoIGtlZXBzIHRyYWNrIG9mIGNoYW5nZXMgdXNp
bmcgdGhlIHNoYTFzdW0gb2YgdGhlIGNoYW5nZXMuIFRoZSBJRCBhYm92ZSBpcyB0aGUgbGVhZGlu
ZyBkaWdpdHMgb2YgdGhhdCBzdW0uDQoNClRoZSBwYXRjaCBpbiBxdWVzdGlvbiBpcyBhdHRhY2hl
ZC4gSXQgaGFuZGxlcyB0aGUgY2FzZXMgd2hlcmUgdGhlIHNlbGYgbWVtYmVyIG9mIHRoZSBwY2lf
YnVzIHN0cnVjdCBpcyBub3QgcHJlc2VudC4gSXQgYXBwZWFycyBub3QgdG8gaGF2ZSBiZWVuIGFw
cGxpZWQgdG8geW91ciBzb3VyY2UuIERvZXMgdGhpcyBwYXRjaCBmaXggeW91ciBwcm9ibGVtPw0K
DQpMYXJyeQ0KDQoNCg==

Re: insmod RTL8192CE OOPS on 2.6.32.16

[Larry Finger]

On 12/23/2011 03:02 AM, Darshan Kumar NANDANWAR wrote:
> Larry ,
> Many thanks .Your patch helped me get over that issue.. But now  I am getting following error which is may be because of firmware is not responding:
>
> PCI: Enabling device 0000:00:01.0 (0000 ->  0003)
> rtl8192ce 0000:00:01.0: enabling bus mastering
> PCI: Setting latency timer of device 0000:00:01.0 to 64
> rtl8192ce:rtl92ce_read_eeprom_info():<0-0>  Autoload ERR!!
> rtl8192ce:rtl92c_init_sw_vars():<0-0>  Failed to request firmware!
> rtlwifi:rtl_pci_probe():<0-0>  Can't init_sw_vars.
>
> I have pulled up latest branch  of linux-firmware.git and using firmware rtlwifi/rtl8192cfw.bin located in /lib/firmware .. Please give me some pointers so that I can get over this now...

Please grab the latest version of the compat-wireless sources. That way we will 
not be chasing bugs that are already fixed.

After you get that package implemented, then use "modprobe rtl8192ce debug=4" 
when you load the module, and send me that dmesg output.

Larry

Re: insmod RTL8192CE OOPS on 2.6.32.16

[Larry Finger]

On 12/23/2011 12:09 PM, Darshan Nandanwar wrote:
> Larry ,
>   i am using compat-wireless-2011-12-08.tar.bz2
> <http://linuxwireless.org/download/compat-wireless-2.6/compat-wireless-2011-12-08.tar.bz2>..I
> find the same issue with 8192cU driver as well.. Could you suggest me the commit
> which fixed the issue? i went through your git log , but don't find the issue
> regarding this...
> Once i have the setup ready , i will try to give you debug=4 log .

I'm confused. The 2011-12-08 version of compat-wireless has the patch I sent 
yesterday already built in - you should not have needed to apply it. In fact, it 
should not have applied to that source.

You would only see the git commit log when you have a full git tree from either 
mainline or wireless-testing.

I'm also confused about your statement "I find the same issue with 8192cU driver 
as well.". I guess you must mean that the firmware does not load. If so, do you 
have firmware loading configured in your kernel?

Larry