* [PATCH] Add USB ID of HP's Broadcom BCM2035 Bluetooth
@ 2011-12-21 20:23 Albert Pool
2011-12-21 23:59 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Albert Pool @ 2011-12-21 20:23 UTC (permalink / raw)
To: Marcel Holtmann, Gustavo F. Padovan; +Cc: linux-bluetooth
HP's Broadcom Bluetooth 1.2 interface (USB 03f0:011d) found in HP Compaq
nc6120 laptop, fails to detect other devices, and pair with them.
With BTUSB_BCM92035 it now works.
I've also tried using BTUSB_WRONG_SCO_MTU, but with that setting it
failed to enable the device 50% of the time.
If I didn't properly submit the patch, please let me know.
Signed-off-by: Albert Pool <albertpool@solcon.nl>
- - -
drivers/bluetooth/btusb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -142,7 +142,8 @@ static struct usb_device_id blacklist_ta
{ USB_DEVICE(0x0a5c, 0x201e), .driver_info = BTUSB_WRONG_SCO_MTU },
{ USB_DEVICE(0x0a5c, 0x2110), .driver_info = BTUSB_WRONG_SCO_MTU },
- /* HP laptop with Broadcom chip */
+ /* HP laptops with Broadcom chip */
+ { USB_DEVICE(0x03f0, 0x011d), .driver_info = BTUSB_BCM92035 },
{ USB_DEVICE(0x03f0, 0x171d), .driver_info = BTUSB_WRONG_SCO_MTU },
/* Dell laptop with Broadcom chip */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Add USB ID of HP's Broadcom BCM2035 Bluetooth
2011-12-21 20:23 [PATCH] Add USB ID of HP's Broadcom BCM2035 Bluetooth Albert Pool
@ 2011-12-21 23:59 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2011-12-21 23:59 UTC (permalink / raw)
To: Albert Pool; +Cc: Gustavo F. Padovan, linux-bluetooth
Hi Albert,
> HP's Broadcom Bluetooth 1.2 interface (USB 03f0:011d) found in HP Compaq
> nc6120 laptop, fails to detect other devices, and pair with them.
> With BTUSB_BCM92035 it now works.
>
> I've also tried using BTUSB_WRONG_SCO_MTU, but with that setting it
> failed to enable the device 50% of the time.
>
> If I didn't properly submit the patch, please let me know.
don't include such a sentence in the commit message. It belongs after
--- and before the diffstat.
Include the output of usb-devices in the commit message.
>
> Signed-off-by: Albert Pool <albertpool@solcon.nl>
> - - -
And please fix your email client. It is messing up whitespaces.
> drivers/bluetooth/btusb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -142,7 +142,8 @@ static struct usb_device_id blacklist_ta
> { USB_DEVICE(0x0a5c, 0x201e), .driver_info = BTUSB_WRONG_SCO_MTU },
> { USB_DEVICE(0x0a5c, 0x2110), .driver_info = BTUSB_WRONG_SCO_MTU },
>
> - /* HP laptop with Broadcom chip */
> + /* HP laptops with Broadcom chip */
> + { USB_DEVICE(0x03f0, 0x011d), .driver_info = BTUSB_BCM92035 },
You need a tab here and not space.
> { USB_DEVICE(0x03f0, 0x171d), .driver_info = BTUSB_WRONG_SCO_MTU },
>
> /* Dell laptop with Broadcom chip */
>
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-21 23:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-21 20:23 [PATCH] Add USB ID of HP's Broadcom BCM2035 Bluetooth Albert Pool
2011-12-21 23:59 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.