* [PATCH] stmmac: Add missing LF to pr_info() in stmmac_main.c
@ 2012-01-10 11:47 Stefan Roese
2012-01-10 14:50 ` Giuseppe CAVALLARO
2012-01-10 22:57 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Roese @ 2012-01-10 11:47 UTC (permalink / raw)
To: netdev; +Cc: Giuseppe Cavallaro
Otherwise the output looks like this:
...
STMMAC - user ID: 0x10, Synopsys ID: 0x32
No HW DMA feature register supported
Normal descriptors
Remote wake-up capable
Checksum Offload Engine supported
No MAC Management Counters availableIP-Config: Complete:
device=eth0, addr=192.168.20.42, mask=255.255.0.0, gw=192.168.1.254,
...
Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 3738b47..ee85a14 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -772,7 +772,7 @@ static void stmmac_mmc_setup(struct stmmac_priv *priv)
dwmac_mmc_ctrl(priv->ioaddr, mode);
memset(&priv->mmc, 0, sizeof(struct stmmac_counters));
} else
- pr_info(" No MAC Management Counters available");
+ pr_info(" No MAC Management Counters available\n");
}
static u32 stmmac_get_synopsys_id(struct stmmac_priv *priv)
--
1.7.8.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] stmmac: Add missing LF to pr_info() in stmmac_main.c
2012-01-10 11:47 [PATCH] stmmac: Add missing LF to pr_info() in stmmac_main.c Stefan Roese
@ 2012-01-10 14:50 ` Giuseppe CAVALLARO
2012-01-10 22:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Giuseppe CAVALLARO @ 2012-01-10 14:50 UTC (permalink / raw)
To: Stefan Roese; +Cc: netdev
On 1/10/2012 12:47 PM, Stefan Roese wrote:
> Otherwise the output looks like this:
>
> ...
> STMMAC - user ID: 0x10, Synopsys ID: 0x32
> No HW DMA feature register supported
> Normal descriptors
> Remote wake-up capable
> Checksum Offload Engine supported
> No MAC Management Counters availableIP-Config: Complete:
> device=eth0, addr=192.168.20.42, mask=255.255.0.0, gw=192.168.1.254,
> ...
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 3738b47..ee85a14 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -772,7 +772,7 @@ static void stmmac_mmc_setup(struct stmmac_priv *priv)
> dwmac_mmc_ctrl(priv->ioaddr, mode);
> memset(&priv->mmc, 0, sizeof(struct stmmac_counters));
> } else
> - pr_info(" No MAC Management Counters available");
> + pr_info(" No MAC Management Counters available\n");
> }
>
> static u32 stmmac_get_synopsys_id(struct stmmac_priv *priv)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] stmmac: Add missing LF to pr_info() in stmmac_main.c
2012-01-10 11:47 [PATCH] stmmac: Add missing LF to pr_info() in stmmac_main.c Stefan Roese
2012-01-10 14:50 ` Giuseppe CAVALLARO
@ 2012-01-10 22:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-01-10 22:57 UTC (permalink / raw)
To: sr; +Cc: netdev, peppe.cavallaro
From: Stefan Roese <sr@denx.de>
Date: Tue, 10 Jan 2012 12:47:51 +0100
> Otherwise the output looks like this:
>
> ...
> STMMAC - user ID: 0x10, Synopsys ID: 0x32
> No HW DMA feature register supported
> Normal descriptors
> Remote wake-up capable
> Checksum Offload Engine supported
> No MAC Management Counters availableIP-Config: Complete:
> device=eth0, addr=192.168.20.42, mask=255.255.0.0, gw=192.168.1.254,
> ...
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-10 22:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-10 11:47 [PATCH] stmmac: Add missing LF to pr_info() in stmmac_main.c Stefan Roese
2012-01-10 14:50 ` Giuseppe CAVALLARO
2012-01-10 22:57 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.