* [PATCH] 98usrmount: don't pass fstab fs options as fsck options
@ 2012-01-12 11:48 Amadeusz Żołnowski
2012-01-13 17:07 ` Cong Wang
0 siblings, 1 reply; 4+ messages in thread
From: Amadeusz Żołnowski @ 2012-01-12 11:48 UTC (permalink / raw)
To: initramfs-u79uwXL29TY76Z2rM5mHXA; +Cc: Amadeusz Żołnowski
For example for line in /etc/fstab:
/dev/vg/usr /usr ext4 nosuid,nodev 0 2
fsck_single is called as follows:
fsck_single /dev/vg/usr ext4 nosuid,nodev
and this eventually resolves to:
e2fsck -a nosuid,nodev /dev/vg/usr
which causes e2fsck usage error.
---
modules.d/98usrmount/mount-usr.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/modules.d/98usrmount/mount-usr.sh b/modules.d/98usrmount/mount-usr.sh
index a61f935..fc205d5 100755
--- a/modules.d/98usrmount/mount-usr.sh
+++ b/modules.d/98usrmount/mount-usr.sh
@@ -19,7 +19,7 @@ mount_usr()
if [ "x$_usr_found" != "x" ]; then
# we have to mount /usr
- fsck_single "$_dev" "$_fs" "$_opts"
+ fsck_single "$_dev" "$_fs"
_ret=$?
echo $_ret >/run/initramfs/usr-fsck
if [ $_ret -ne 255 ]; then
@@ -29,4 +29,4 @@ mount_usr()
fi
}
-mount_usr
\ No newline at end of file
+mount_usr
--
1.7.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] 98usrmount: don't pass fstab fs options as fsck options
2012-01-12 11:48 [PATCH] 98usrmount: don't pass fstab fs options as fsck options Amadeusz Żołnowski
@ 2012-01-13 17:07 ` Cong Wang
2012-01-16 10:10 ` Harald Hoyer
0 siblings, 1 reply; 4+ messages in thread
From: Cong Wang @ 2012-01-13 17:07 UTC (permalink / raw)
To: initramfs-u79uwXL29TY76Z2rM5mHXA
On Thu, 12 Jan 2012 at 11:48 GMT, Amadeusz Żołnowski <aidecoe@aidecoe.name> wrote:
> For example for line in /etc/fstab:
>
> /dev/vg/usr /usr ext4 nosuid,nodev 0 2
>
> fsck_single is called as follows:
>
> fsck_single /dev/vg/usr ext4 nosuid,nodev
>
> and this eventually resolves to:
>
> e2fsck -a nosuid,nodev /dev/vg/usr
>
> which causes e2fsck usage error.
> ---
> modules.d/98usrmount/mount-usr.sh | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/modules.d/98usrmount/mount-usr.sh b/modules.d/98usrmount/mount-usr.sh
> index a61f935..fc205d5 100755
> --- a/modules.d/98usrmount/mount-usr.sh
> +++ b/modules.d/98usrmount/mount-usr.sh
> @@ -19,7 +19,7 @@ mount_usr()
>
> if [ "x$_usr_found" != "x" ]; then
> # we have to mount /usr
> - fsck_single "$_dev" "$_fs" "$_opts"
> + fsck_single "$_dev" "$_fs"
Yes, this change makes sense.
> _ret=$?
> echo $_ret >/run/initramfs/usr-fsck
> if [ $_ret -ne 255 ]; then
> @@ -29,4 +29,4 @@ mount_usr()
> fi
> }
>
> -mount_usr
> \ No newline at end of file
> +mount_usr
But what is this one??
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] 98usrmount: don't pass fstab fs options as fsck options
2012-01-13 17:07 ` Cong Wang
@ 2012-01-16 10:10 ` Harald Hoyer
2012-01-25 13:10 ` Cong Wang
0 siblings, 1 reply; 4+ messages in thread
From: Harald Hoyer @ 2012-01-16 10:10 UTC (permalink / raw)
To: Cong Wang; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA
On 13.01.2012 18:07, Cong Wang wrote:
> On Thu, 12 Jan 2012 at 11:48 GMT, Amadeusz Żołnowski <aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org> wrote:
>> For example for line in /etc/fstab:
>>
>> /dev/vg/usr /usr ext4 nosuid,nodev 0 2
>>
>> fsck_single is called as follows:
>>
>> fsck_single /dev/vg/usr ext4 nosuid,nodev
>>
>> and this eventually resolves to:
>>
>> e2fsck -a nosuid,nodev /dev/vg/usr
>>
>> which causes e2fsck usage error.
>> ---
>> modules.d/98usrmount/mount-usr.sh | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/modules.d/98usrmount/mount-usr.sh b/modules.d/98usrmount/mount-usr.sh
>> index a61f935..fc205d5 100755
>> --- a/modules.d/98usrmount/mount-usr.sh
>> +++ b/modules.d/98usrmount/mount-usr.sh
>> @@ -19,7 +19,7 @@ mount_usr()
>>
>> if [ "x$_usr_found" != "x" ]; then
>> # we have to mount /usr
>> - fsck_single "$_dev" "$_fs" "$_opts"
>> + fsck_single "$_dev" "$_fs"
>
> Yes, this change makes sense.
>
>> _ret=$?
>> echo $_ret >/run/initramfs/usr-fsck
>> if [ $_ret -ne 255 ]; then
>> @@ -29,4 +29,4 @@ mount_usr()
>> fi
>> }
>>
>> -mount_usr
>> \ No newline at end of file
>> +mount_usr
>
> But what is this one??
That just adds a newline at the end of the file, IIRC
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] 98usrmount: don't pass fstab fs options as fsck options
2012-01-16 10:10 ` Harald Hoyer
@ 2012-01-25 13:10 ` Cong Wang
0 siblings, 0 replies; 4+ messages in thread
From: Cong Wang @ 2012-01-25 13:10 UTC (permalink / raw)
To: initramfs-u79uwXL29TY76Z2rM5mHXA
On Mon, 16 Jan 2012 at 10:10 GMT, Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>>>
>>> -mount_usr
>>> \ No newline at end of file
>>> +mount_usr
>>
>> But what is this one??
>
> That just adds a newline at the end of the file, IIRC
>
As long as this patch can be applied, I have no objections. :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-25 13:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-12 11:48 [PATCH] 98usrmount: don't pass fstab fs options as fsck options Amadeusz Żołnowski
2012-01-13 17:07 ` Cong Wang
2012-01-16 10:10 ` Harald Hoyer
2012-01-25 13:10 ` Cong Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.