* [PATCH] can: ti_hecc: use netif_rx in the interrupt
@ 2012-02-01 9:50 Wolfgang Grandegger
2012-02-01 10:00 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Wolfgang Grandegger @ 2012-02-01 9:50 UTC (permalink / raw)
To: Linux-CAN
This patch fixes locking problems by using netif_rx() instead of
netif_receive_skb() in ti_hecc_error() called from the interrupt
context.
Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
---
drivers/net/can/ti_hecc.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
index df809e3..5a2e1e3 100644
--- a/drivers/net/can/ti_hecc.c
+++ b/drivers/net/can/ti_hecc.c
@@ -745,9 +745,10 @@ static int ti_hecc_error(struct net_device *ndev, int int_status,
}
}
- netif_receive_skb(skb);
+ netif_rx(skb);
stats->rx_packets++;
stats->rx_bytes += cf->can_dlc;
+
return 0;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] can: ti_hecc: use netif_rx in the interrupt
2012-02-01 9:50 [PATCH] can: ti_hecc: use netif_rx in the interrupt Wolfgang Grandegger
@ 2012-02-01 10:00 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2012-02-01 10:00 UTC (permalink / raw)
To: Wolfgang Grandegger; +Cc: Linux-CAN
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
On 02/01/2012 10:50 AM, Wolfgang Grandegger wrote:
> This patch fixes locking problems by using netif_rx() instead of
> netif_receive_skb() in ti_hecc_error() called from the interrupt
> context.
>
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
applied to can-next
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-01 10:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-01 9:50 [PATCH] can: ti_hecc: use netif_rx in the interrupt Wolfgang Grandegger
2012-02-01 10:00 ` Marc Kleine-Budde
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.