[Qemu-devel] Sanity

[Qemu-devel] Sanity

[malc]

This is a 32bit machine, the target is i386-softmmu, yet,
libhw32 is mostly empty and libhw64 is populated, furthermore[1]:

$ rm libhw64/ac97.o
$ make V=1
make  BUILD_DIR=/home/malc/x/bld/qemu/master -C libhw64 V="1" TARGET_DIR="libhw64/" all
make[1]: Entering directory `/home/malc/x/bld/qemu/master/libhw64'
ccache gcc -fno-working-directory -I/home/malc/x/rcs/git/qemuorg/slirp -I. -I/home/malc/x/rcs/git/qemuorg -I/home/malc/x/rcs/git/qemuorg/fpu -Werror -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing  -fstack-protector-all -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -I/usr/include/libpng14   -DTARGET_PHYS_ADDR_BITS=64 -I.. -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I/home/malc/x/rcs/git/qemuorg/include -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -MMD -MP -MT ac97.o -MF ./ac97.d -O -g  -U_FORTIFY_SOURCE -fno-stack-protector -c -o ac97.o /home/malc/x/rcs/git/qemuorg/hw/ac97.c
make[1]: Leaving directory `/home/malc/x/bld/qemu/master/libhw64'

Why does it say the same thing many times (-pthread -I/usr/include/glib-2.0...),
is gcc suffering from ADD or something?

[1] Just an example.

-- 
mailto:av1474@comtv.ru

Re: [Qemu-devel] Sanity

[Stefan Weil]

Am 07.02.2012 19:22, schrieb malc:
> This is a 32bit machine, the target is i386-softmmu, yet,
> libhw32 is mostly empty and libhw64 is populated, furthermore[1]:
>
> $ rm libhw64/ac97.o
> $ make V=1
> make  BUILD_DIR=/home/malc/x/bld/qemu/master -C libhw64 V="1" TARGET_DIR="libhw64/" all
> make[1]: Entering directory `/home/malc/x/bld/qemu/master/libhw64'
> ccache gcc -fno-working-directory -I/home/malc/x/rcs/git/qemuorg/slirp -I. -I/home/malc/x/rcs/git/qemuorg -I/home/malc/x/rcs/git/qemuorg/fpu -Werror -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing  -fstack-protector-all -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -I/usr/include/libpng14   -DTARGET_PHYS_ADDR_BITS=64 -I.. -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I/home/malc/x/rcs/git/qemuorg/include -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -MMD -MP -MT ac97.o -MF ./ac97.d -O -g  -U_FORTIFY_SOURCE -fno-stack-protector -c -o ac97.o /home/malc/x/rcs/git/qemuorg/hw/ac97.c
> make[1]: Leaving directory `/home/malc/x/bld/qemu/master/libhw64'
>
> Why does it say the same thing many times (-pthread -I/usr/include/glib-2.0...),
> is gcc suffering from ADD or something?
>
> [1] Just an example.
>
>    

That's caused by too many of these statements:

QEMU_CFLAGS+=$(GLIB_CFLAGS)

It should be removed from Makefile.objs and added to
Makefile.dis and Makefile.user.

Re: [Qemu-devel] Sanity

[Andreas Färber]

Am 07.02.2012 19:22, schrieb malc:
> This is a 32bit machine, the target is i386-softmmu, yet,
> libhw32 is mostly empty and libhw64 is populated,
[snip]

I believe some people felt a need to emulate PAE or something which
needed a physical address space of 36 bits, therefore i386 was switched
from 32 bits to 64 bits.

Similar for ppc recently.

Lately there was also some discussion about dropping libhw32 and
target_phys_addr_t altogether and making all devices 64-bit.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg