[PATCH] ath6kl: Fix firmware crash dump

[PATCH] ath6kl: Fix firmware crash dump

[Naveen Gangadharan]

Fixed a bug when we dump the firmware crash log.

Signed-off-by: Naveen Gangadharan <ngangadh@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath6kl/hif.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/hif.c b/drivers/net/wireless/ath/ath6kl/hif.c
index e911737..78d0018 100644
--- a/drivers/net/wireless/ath/ath6kl/hif.c
+++ b/drivers/net/wireless/ath/ath6kl/hif.c
@@ -106,7 +106,7 @@ static void ath6kl_hif_dump_fw_crash(struct ath6kl *ar)
 
 	BUILD_BUG_ON(REG_DUMP_COUNT_AR6003 % 4);
 
-	for (i = 0; i < REG_DUMP_COUNT_AR6003 / 4; i++) {
+	for (i = 0; i < REG_DUMP_COUNT_AR6003; i += 4) {
 		ath6kl_info("%d: 0x%8.8x 0x%8.8x 0x%8.8x 0x%8.8x\n",
 			    4 * i,
 			    le32_to_cpu(regdump_val[i]),
-- 
1.7.0.4

Re: [PATCH] ath6kl: Fix firmware crash dump

[Kalle Valo]

On 02/08/2012 08:53 AM, Naveen Gangadharan wrote:
> Fixed a bug when we dump the firmware crash log.
> 
> Signed-off-by: Naveen Gangadharan <ngangadh@qca.qualcomm.com>

Thanks, applied with these changes:

commit 3b96d49a79021ce4c1ca26aecd784d16aeb91a7c
Author: Naveen Gangadharan <ngangadh@qca.qualcomm.com>
Date:   Tue Feb 7 22:53:32 2012 -0800

    ath6kl: Fix firmware crash dump

    The firmware crash dump printout was wrong as it was using incorrect
    offsets.

    kvalo: improve commit log, change the "%d:" to print word indexes,
not bytes

    Signed-off-by: Naveen Gangadharan <ngangadh@qca.qualcomm.com>
    Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

Kalle